From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B198DC433E1 for ; Mon, 15 Jun 2020 23:37:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88C57207D4 for ; Mon, 15 Jun 2020 23:37:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="cNdeCxMZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88C57207D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CFE1E6E55E; Mon, 15 Jun 2020 23:37:09 +0000 (UTC) Received: from m43-7.mailgun.net (m43-7.mailgun.net [69.72.43.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id E79586E55E for ; Mon, 15 Jun 2020 23:37:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1592264228; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=2DtTXOmQcCDu/XLc8Y9feTA+UARZggV+DWpANCHY8bY=; b=cNdeCxMZ67V1IYkpk+wC2aXMdu+Nqu1ftuV7/W8Exb/WtscRP47I5i0B/INbjN4Q4sy4B8D5 5Mcssjr79hZYHKCj7XU/NhpatDZlbOeVDQ9Jy4tXKtVEZGCGbajd2EdkenJy6/KbSk/Cd42R 6YwaTBbOCj7fTurR6foyl5ixzeY= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 5ee80615fe1db4db89eea134 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 15 Jun 2020 23:36:53 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 35A3AC43395; Mon, 15 Jun 2020 23:36:53 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: tanmay) by smtp.codeaurora.org (Postfix) with ESMTPSA id 650E9C433CA; Mon, 15 Jun 2020 23:36:52 +0000 (UTC) MIME-Version: 1.0 Date: Mon, 15 Jun 2020 16:36:52 -0700 From: tanmay@codeaurora.org To: Jeffrey Hugo Subject: Re: [Freedreno] [PATCH v6 0/5] Add support for DisplayPort driver on In-Reply-To: References: <20200612015030.16072-1-tanmay@codeaurora.org> <159200440578.62212.5195358467251573190@swboyd.mtv.corp.google.com> <1eda01da33b620ddee5162be3326853f@codeaurora.org> Message-ID: X-Sender: tanmay@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DTML , Sam Ravnborg , MSM , lkml , "open list:DRM PANEL DRIVERS" , Stephen Boyd , Rob Herring , Sean Paul , Abhinav Kumar , aravindh@codeaurora.org, freedreno Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2020-06-15 16:04, Jeffrey Hugo wrote: > On Mon, Jun 15, 2020 at 4:51 PM wrote: >> >> On 2020-06-12 16:26, Stephen Boyd wrote: >> >> Thanks for reviews Stephen. >> >> > Quoting Tanmay Shah (2020-06-11 18:50:25) >> >> These patches add support for Display-Port driver on SnapDragon >> >> hardware. It adds >> >> DP driver and DP PLL driver files along with the needed device-tree >> >> bindings. >> >> >> >> The block diagram of DP driver is shown below: >> >> >> >> >> >> +-------------+ >> >> |DRM FRAMEWORK| >> >> +------+------+ >> >> | >> >> +----v----+ >> >> | DP DRM | >> >> +----+----+ >> >> | >> >> +----v----+ >> >> +------------+| DP +----------++------+ >> >> + +---+| DISPLAY |+---+ | | >> >> | + +-+-----+-+ | | | >> >> | | | | | | | >> >> | | | | | | | >> >> | | | | | | | >> >> v v v v v v v >> >> +------+ +------+ +---+ +----+ +----+ +---+ +-----+ >> >> | DP | | DP | |DP | | DP | | DP | |DP | | DP | >> >> |PARSER| | HPD | |AUX| |LINK| |CTRL| |PHY| |POWER| >> >> +--+---+ +---+--+ +---+ +----+ +--+-+ +-+-+ +-----+ >> >> | | | >> >> +--v---+ +v-----v+ >> >> |DEVICE| | DP | >> >> | TREE | |CATALOG| >> >> +------+ +---+---+ >> >> | >> >> +---v----+ >> >> |CTRL/PHY| >> >> | HW | >> >> +--------+ >> >> >> > >> > I've never seen a block diagram for a driver before... >> > >> It is here for v5. https://patchwork.freedesktop.org/series/74312/ > > I think Stephen is nitpicking your wording, and you seem to not be > understanding his comment. I'm sorry if I am mistaken. > > The "DP driver" would seem to refer to the linux software driver you > are proposing patches for, however this diagram looks like a hardware > diagram of the various hardware blocks that the Linux driver code (the > "DP driver") is expected to interact with. I believe you should > re-word "The block diagram of DP driver is shown below:" to be more > specific of what you are describing with your figure. IE your words > say this is a block diagram of the software, when it looks like it is > a block diagram of the hardware. Thanks for reviews. I am not sure what Stephen meant, but this diagram was available before. Just for clarification this is not hardware diagram at all. This is modeling of DP driver for msm. Each box name above except "DRM framework", is file name in driver i.e. software module. Each line and arrow shows how modules interact with each other. For example, "DP PARSER" Box is pointing towards "DEVICE TREE" Box, that means dp_parser.c file contains functions which are parsing device tree properties and so on... _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel