From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=1.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90AB4C433ED for ; Tue, 27 Apr 2021 12:06:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3856960FDC for ; Tue, 27 Apr 2021 12:06:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3856960FDC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2EB076E94E; Tue, 27 Apr 2021 12:06:07 +0000 (UTC) Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 807416E93D; Tue, 27 Apr 2021 12:06:05 +0000 (UTC) Received: by mail-ed1-x52e.google.com with SMTP id i3so43944105edt.1; Tue, 27 Apr 2021 05:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=tNPbveeKspBLTwE6zKikLWyxT9ZVsz/VIuPHAwuRS8U=; b=RWAoQrm9HWqdOD7rO4WJ+WMheyyG53XyYC7WRF27V9MznG0AO2akoJVblpgSPAfZ3s IVdmMpfzxUPiyysUVMduN93nSQSj+duadJp/kqC+2ocN2NKEI0fuFgWIotE7gLEbPlLb GOc8UJbwK6b4oYtvGuaPy3s5kouW+QUa2X2/4psiZr55HxCfqfQqXNHp2ffGU9NunkSF cJWJLCXbWIEmX6JfbnQ5UaiLFTzT2wjLOLb74Ix/Ns9/TJax5lLz69T/HdXJ9gFV0c/w gSIyNNviJgB1DKSQwbThqniyTZuh99IC+cg0blU0NZTUYFcHSHaXFEyuHg0RuA9+gbL2 1B4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=tNPbveeKspBLTwE6zKikLWyxT9ZVsz/VIuPHAwuRS8U=; b=dlL05vX76BJqpniY7dz8RKrzxdBD0XWtQuJZpyTkQCYvve0YR2fSQ5ZyvTn7v10OBe wpMO0kAyc4aC8rL5tqBdITJFTqhnlIfWYi0CeRbjz+hRQGLLrX5PmzE0GyJCkk9yoIZN xGxu2vbqimYOklPRcO7U+m1rzG6rQBlYzRpWgkppOwAA2mFHah6qaMMp9rzKMHSWpxUf spTjz+DWevaBsk1n8Z/Usr4Dx2xFV/NAfZwqlH4eF+bpzQgPNLb9uAfPdGddrYHN/tum 3AY47Ttl0h79Ck1N/XlfiB/KaDcVbSIwYniqdlZMsF1Piv6O0bgxiSi/e80NrX2bX2Rp LIyQ== X-Gm-Message-State: AOAM530PZPm9wq911eHKAysKKYbAor3/Z4VqnZQ7EZcDpU41l5x2HvKI N6BmfBVcorZG2rbAFJpHAo/0yT6RQOA= X-Google-Smtp-Source: ABdhPJyFm5gPeJnnOMbESWIvA78QnrszNe04nvy/7G3U/fQ5XoGv2oX2QT0mv2rK5VjXKzejxpHVwg== X-Received: by 2002:aa7:de8b:: with SMTP id j11mr3881356edv.363.1619525163711; Tue, 27 Apr 2021 05:06:03 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:a79d:3e10:541f:6c50? ([2a02:908:1252:fb60:a79d:3e10:541f:6c50]) by smtp.gmail.com with ESMTPSA id hc43sm13583908ejc.97.2021.04.27.05.06.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Apr 2021 05:06:03 -0700 (PDT) Subject: Re: [Mesa-dev] [RFC] Linux Graphics Next: Explicit fences everywhere and no BO fences - initial proposal To: =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , Daniel Vetter References: From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Tue, 27 Apr 2021 14:06:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ML Mesa-dev , dri-devel Content-Type: multipart/mixed; boundary="===============0027441916==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is a multi-part message in MIME format. --===============0027441916== Content-Type: multipart/alternative; boundary="------------FAA7710A7490BF0C39D9677F" Content-Language: en-US This is a multi-part message in MIME format. --------------FAA7710A7490BF0C39D9677F Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Correct, we wouldn't have synchronization between device with and without user queues any more. That could only be a problem for A+I Laptops. Memory management will just work with preemption fences which pause the user queues of a process before evicting something. That will be a dma_fence, but also a well known approach. Christian. Am 27.04.21 um 13:49 schrieb Marek Olšák: > If we don't use future fences for DMA fences at all, e.g. we don't use > them for memory management, it can work, right? Memory management can > suspend user queues anytime. It doesn't need to use DMA fences. There > might be something that I'm missing here. > > What would we lose without DMA fences? Just inter-device > synchronization? I think that might be acceptable. > > The only case when the kernel will wait on a future fence is before a > page flip. Everything today already depends on userspace not hanging > the gpu, which makes everything a future fence. > > Marek > > On Tue., Apr. 27, 2021, 04:02 Daniel Vetter, > wrote: > > On Mon, Apr 26, 2021 at 04:59:28PM -0400, Marek Olšák wrote: > > Thanks everybody. The initial proposal is dead. Here are some > thoughts on > > how to do it differently. > > > > I think we can have direct command submission from userspace via > > memory-mapped queues ("user queues") without changing window > systems. > > > > The memory management doesn't have to use GPU page faults like HMM. > > Instead, it can wait for user queues of a specific process to go > idle and > > then unmap the queues, so that userspace can't submit anything. > Buffer > > evictions, pinning, etc. can be executed when all queues are > unmapped > > (suspended). Thus, no BO fences and page faults are needed. > > > > Inter-process synchronization can use timeline semaphores. > Userspace will > > query the wait and signal value for a shared buffer from the > kernel. The > > kernel will keep a history of those queries to know which process is > > responsible for signalling which buffer. There is only the > wait-timeout > > issue and how to identify the culprit. One of the solutions is > to have the > > GPU send all GPU signal commands and all timed out wait commands > via an > > interrupt to the kernel driver to monitor and validate userspace > behavior. > > With that, it can be identified whether the culprit is the > waiting process > > or the signalling process and which one. Invalid signal/wait > parameters can > > also be detected. The kernel can force-signal only the > semaphores that time > > out, and punish the processes which caused the timeout or used > invalid > > signal/wait parameters. > > > > The question is whether this synchronization solution is robust > enough for > > dma_fence and whatever the kernel and window systems need. > > The proper model here is the preempt-ctx dma_fence that amdkfd uses > (without page faults). That means dma_fence for synchronization is > doa, at > least as-is, and we're back to figuring out the winsys problem. > > "We'll solve it with timeouts" is very tempting, but doesn't work. > It's > akin to saying that we're solving deadlock issues in a locking > design by > doing a global s/mutex_lock/mutex_lock_timeout/ in the kernel. Sure it > avoids having to reach the reset button, but that's about it. > > And the fundamental problem is that once you throw in userspace > command > submission (and syncing, at least within the userspace driver, > otherwise > there's kinda no point if you still need the kernel for > cross-engine sync) > means you get deadlocks if you still use dma_fence for sync under > perfectly legit use-case. We've discussed that one ad nauseam last > summer: > > https://dri.freedesktop.org/docs/drm/driver-api/dma-buf.html?highlight=dma_fence#indefinite-dma-fences > > > See silly diagramm at the bottom. > > Now I think all isn't lost, because imo the first step to getting > to this > brave new world is rebuilding the driver on top of userspace > fences, and > with the adjusted cmd submit model. You probably don't want to use > amdkfd, > but port that as a context flag or similar to render nodes for > gl/vk. Of > course that means you can only use this mode in headless, without > glx/wayland winsys support, but it's a start. > -Daniel > > > > > Marek > > > > On Tue, Apr 20, 2021 at 4:34 PM Daniel Stone > > wrote: > > > > > Hi, > > > > > > On Tue, 20 Apr 2021 at 20:30, Daniel Vetter > wrote: > > > > > >> The thing is, you can't do this in drm/scheduler. At least > not without > > >> splitting up the dma_fence in the kernel into separate memory > fences > > >> and sync fences > > > > > > > > > I'm starting to think this thread needs its own glossary ... > > > > > > I propose we use 'residency fence' for execution fences which > enact > > > memory-residency operations, e.g. faulting in a page > ultimately depending > > > on GPU work retiring. > > > > > > And 'value fence' for the pure-userspace model suggested by > timeline > > > semaphores, i.e. fences being (*addr == val) rather than being > able to look > > > at ctx seqno. > > > > > > Cheers, > > > Daniel > > > _______________________________________________ > > > mesa-dev mailing list > > > mesa-dev@lists.freedesktop.org > > > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > > > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch > > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev --------------FAA7710A7490BF0C39D9677F Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit Correct, we wouldn't have synchronization between device with and without user queues any more.

That could only be a problem for A+I Laptops.

Memory management will just work with preemption fences which pause the user queues of a process before evicting something. That will be a dma_fence, but also a well known approach.

Christian.

Am 27.04.21 um 13:49 schrieb Marek Olšák:
If we don't use future fences for DMA fences at all, e.g. we don't use them for memory management, it can work, right? Memory management can suspend user queues anytime. It doesn't need to use DMA fences. There might be something that I'm missing here.

What would we lose without DMA fences? Just inter-device synchronization? I think that might be acceptable.

The only case when the kernel will wait on a future fence is before a page flip. Everything today already depends on userspace not hanging the gpu, which makes everything a future fence.

Marek

On Tue., Apr. 27, 2021, 04:02 Daniel Vetter, <daniel@ffwll.ch> wrote:
On Mon, Apr 26, 2021 at 04:59:28PM -0400, Marek Olšák wrote:
> Thanks everybody. The initial proposal is dead. Here are some thoughts on
> how to do it differently.
>
> I think we can have direct command submission from userspace via
> memory-mapped queues ("user queues") without changing window systems.
>
> The memory management doesn't have to use GPU page faults like HMM.
> Instead, it can wait for user queues of a specific process to go idle and
> then unmap the queues, so that userspace can't submit anything. Buffer
> evictions, pinning, etc. can be executed when all queues are unmapped
> (suspended). Thus, no BO fences and page faults are needed.
>
> Inter-process synchronization can use timeline semaphores. Userspace will
> query the wait and signal value for a shared buffer from the kernel. The
> kernel will keep a history of those queries to know which process is
> responsible for signalling which buffer. There is only the wait-timeout
> issue and how to identify the culprit. One of the solutions is to have the
> GPU send all GPU signal commands and all timed out wait commands via an
> interrupt to the kernel driver to monitor and validate userspace behavior.
> With that, it can be identified whether the culprit is the waiting process
> or the signalling process and which one. Invalid signal/wait parameters can
> also be detected. The kernel can force-signal only the semaphores that time
> out, and punish the processes which caused the timeout or used invalid
> signal/wait parameters.
>
> The question is whether this synchronization solution is robust enough for
> dma_fence and whatever the kernel and window systems need.

The proper model here is the preempt-ctx dma_fence that amdkfd uses
(without page faults). That means dma_fence for synchronization is doa, at
least as-is, and we're back to figuring out the winsys problem.

"We'll solve it with timeouts" is very tempting, but doesn't work. It's
akin to saying that we're solving deadlock issues in a locking design by
doing a global s/mutex_lock/mutex_lock_timeout/ in the kernel. Sure it
avoids having to reach the reset button, but that's about it.

And the fundamental problem is that once you throw in userspace command
submission (and syncing, at least within the userspace driver, otherwise
there's kinda no point if you still need the kernel for cross-engine sync)
means you get deadlocks if you still use dma_fence for sync under
perfectly legit use-case. We've discussed that one ad nauseam last summer:

https://dri.freedesktop.org/docs/drm/driver-api/dma-buf.html?highlight=dma_fence#indefinite-dma-fences

See silly diagramm at the bottom.

Now I think all isn't lost, because imo the first step to getting to this
brave new world is rebuilding the driver on top of userspace fences, and
with the adjusted cmd submit model. You probably don't want to use amdkfd,
but port that as a context flag or similar to render nodes for gl/vk. Of
course that means you can only use this mode in headless, without
glx/wayland winsys support, but it's a start.
-Daniel

>
> Marek
>
> On Tue, Apr 20, 2021 at 4:34 PM Daniel Stone <daniel@fooishbar.org> wrote:
>
> > Hi,
> >
> > On Tue, 20 Apr 2021 at 20:30, Daniel Vetter <daniel@ffwll.ch> wrote:
> >
> >> The thing is, you can't do this in drm/scheduler. At least not without
> >> splitting up the dma_fence in the kernel into separate memory fences
> >> and sync fences
> >
> >
> > I'm starting to think this thread needs its own glossary ...
> >
> > I propose we use 'residency fence' for execution fences which enact
> > memory-residency operations, e.g. faulting in a page ultimately depending
> > on GPU work retiring.
> >
> > And 'value fence' for the pure-userspace model suggested by timeline
> > semaphores, i.e. fences being (*addr == val) rather than being able to look
> > at ctx seqno.
> >
> > Cheers,
> > Daniel
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

--------------FAA7710A7490BF0C39D9677F-- --===============0027441916== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0027441916==--