dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Liu Ying <victor.liu@nxp.com>
To: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Cc: devicetree@vger.kernel.org, kernel@pengutronix.de,
	airlied@linux.ie, s.hauer@pengutronix.de,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	robh+dt@kernel.org, linux-imx@nxp.com, tzimmermann@suse.de,
	shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/8] drm/imx: Introduce i.MX8qxp DPU DRM
Date: Fri, 20 Nov 2020 10:23:03 +0800	[thread overview]
Message-ID: <fb134d2ac1e9cebdb27b780ebacf9d944d517205.camel@nxp.com> (raw)
In-Reply-To: <20201119173055.geaaori62wgtrfvh@fsr-ub1864-141>

Hi Laurentiu,

On Thu, 2020-11-19 at 19:30 +0200, Laurentiu Palcu wrote:
> Hi Liu Ying,
> 
> On Thu, Nov 19, 2020 at 05:22:17PM +0800, Liu Ying wrote:
> > Hi,
> > 
> > 
> > This patch set introduces i.MX8qxp Display Processing Unit(DPU) DRM support.
> 
> Glad to see this series out. However, something went wrong with it as
> patch 5/8 didn't make it to dri-devel mailing list... :/
> 
> https://lists.freedesktop.org/archives/dri-devel/2020-November/thread.html
> 
> So, people on to dri-devel may not be able to review it...

I think that patch was held for a moment, it appears on dri-devel
archive now:

https://lists.freedesktop.org/archives/dri-devel/2020-November/287958.html

I did receive an email from 'linux-arm-kernel' that says the msg body
of that patch is too big(> 100KB), thus being held for moderator's
review(I hope it pass now).
Maybe, dri-devel did sth similar.

Regards,
Liu Ying

> 
> However, it did make it to LKML:
> 
> https://lkml.org/lkml/2020/11/19/249
> 
> Not sure what happened here... :/
> 
> Thanks,
> laurentiu
> 
> 
> > DPU is comprised of a blit engine for 2D graphics, a display controller
> > and a command sequencer.  Outside of DPU, optional prefetch engines can
> > fetch data from memory prior to some DPU fetchunits of blit engine and
> > display controller.  The pre-fetchers support linear formats and Vivante
> > GPU tile formats.
> > 
> > Reference manual can be found at:
> > https://www.nxp.com/webapp/Download?colCode=IMX8DQXPRM
> > 
> > 
> > This patch set adds kernel modesetting support for the display controller part.
> > It supports two CRTCs per display controller, several planes, prefetch
> > engines and some properties of CRTC and plane.  Currently, the registers of
> > the controller is accessed without command sequencer involved, instead just by
> > using CPU.  DRM connectors would be created from the DPU KMS driver.
> > 
> > 
> > If people want to try this series, clock patches can be found at:
> > https://www.spinics.net/lists/arm-kernel/msg856137.html
> > 
> > and, power domain patches at:
> > https://www.spinics.net/lists/arm-kernel/msg856097.html
> > 
> > 
> > I will send other patch sets to add downstream bridges(embedded in i.MX8qxp)
> > to support LVDS displays.
> > 
> > A brief look at the pipe:
> > prefetch eng -> DPU -> pixel combiner -> pixel link -> pixel to DPI(pxl2dpi) ->
> > LVDS display bridge(LDB)
> > 
> > 
> > Patch 1 ~ 3 add dt-bindings for DPU and prefetch engines.
> > Patch 4 is a minor improvement of a macro to suppress warning as the KMS driver
> > uses it.
> > Patch 5 introduces the DPU DRM support.
> > Patch 6 updates MAINTAINERS.
> > Patch 7 & 8 add DPU and prefetch engines support in the device tree of
> > i.MX8qxp MEK platform.
> > 
> > 
> > Welcome comments, thanks.
> > 
> > 
> > Liu Ying (8):
> >   dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding
> >   dt-bindings: display: imx: Add i.MX8qxp/qm PRG binding
> >   dt-bindings: display: imx: Add i.MX8qxp/qm DPR channel binding
> >   drm/atomic: Avoid unused-but-set-variable warning on
> >     for_each_old_plane_in_state
> >   drm/imx: Introduce i.MX8qxp DPU DRM
> >   MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver
> >   arm64: imx8qxp:dtsi: Introduce DC0 subsystem
> >   arm64: dts: imx8qxp-mek: Enable DPU and it's prefetch engines
> > 
> >  .../bindings/display/imx/fsl,imx8qxp-dprc.yaml     |  87 ++
> >  .../bindings/display/imx/fsl,imx8qxp-dpu.yaml      | 358 ++++++++
> >  .../bindings/display/imx/fsl,imx8qxp-prg.yaml      |  60 ++
> >  MAINTAINERS                                        |   9 +
> >  arch/arm64/boot/dts/freescale/imx8qxp-mek.dts      |  64 ++
> >  arch/arm64/boot/dts/freescale/imx8qxp.dtsi         | 313 +++++++
> >  drivers/gpu/drm/imx/Kconfig                        |   1 +
> >  drivers/gpu/drm/imx/Makefile                       |   1 +
> >  drivers/gpu/drm/imx/dpu/Kconfig                    |  10 +
> >  drivers/gpu/drm/imx/dpu/Makefile                   |  10 +
> >  drivers/gpu/drm/imx/dpu/dpu-constframe.c           | 170 ++++
> >  drivers/gpu/drm/imx/dpu/dpu-core.c                 | 880 ++++++++++++++++++++
> >  drivers/gpu/drm/imx/dpu/dpu-crtc.c                 | 926 +++++++++++++++++++++
> >  drivers/gpu/drm/imx/dpu/dpu-crtc.h                 |  62 ++
> >  drivers/gpu/drm/imx/dpu/dpu-disengcfg.c            | 114 +++
> >  drivers/gpu/drm/imx/dpu/dpu-dprc.c                 | 721 ++++++++++++++++
> >  drivers/gpu/drm/imx/dpu/dpu-dprc.h                 |  40 +
> >  drivers/gpu/drm/imx/dpu/dpu-drv.c                  | 296 +++++++
> >  drivers/gpu/drm/imx/dpu/dpu-drv.h                  |  28 +
> >  drivers/gpu/drm/imx/dpu/dpu-extdst.c               | 296 +++++++
> >  drivers/gpu/drm/imx/dpu/dpu-fetchdecode.c          | 291 +++++++
> >  drivers/gpu/drm/imx/dpu/dpu-fetcheco.c             | 221 +++++
> >  drivers/gpu/drm/imx/dpu/dpu-fetchlayer.c           | 151 ++++
> >  drivers/gpu/drm/imx/dpu/dpu-fetchunit.c            | 609 ++++++++++++++
> >  drivers/gpu/drm/imx/dpu/dpu-fetchunit.h            | 191 +++++
> >  drivers/gpu/drm/imx/dpu/dpu-fetchwarp.c            | 247 ++++++
> >  drivers/gpu/drm/imx/dpu/dpu-framegen.c             | 392 +++++++++
> >  drivers/gpu/drm/imx/dpu/dpu-gammacor.c             | 220 +++++
> >  drivers/gpu/drm/imx/dpu/dpu-hscaler.c              | 272 ++++++
> >  drivers/gpu/drm/imx/dpu/dpu-kms.c                  | 543 ++++++++++++
> >  drivers/gpu/drm/imx/dpu/dpu-kms.h                  |  23 +
> >  drivers/gpu/drm/imx/dpu/dpu-layerblend.c           | 345 ++++++++
> >  drivers/gpu/drm/imx/dpu/dpu-plane.c                | 703 ++++++++++++++++
> >  drivers/gpu/drm/imx/dpu/dpu-plane.h                |  56 ++
> >  drivers/gpu/drm/imx/dpu/dpu-prg.c                  | 389 +++++++++
> >  drivers/gpu/drm/imx/dpu/dpu-prg.h                  |  45 +
> >  drivers/gpu/drm/imx/dpu/dpu-prv.h                  | 203 +++++
> >  drivers/gpu/drm/imx/dpu/dpu-tcon.c                 | 249 ++++++
> >  drivers/gpu/drm/imx/dpu/dpu-vscaler.c              | 305 +++++++
> >  drivers/gpu/drm/imx/dpu/dpu.h                      | 389 +++++++++
> >  include/drm/drm_atomic.h                           |   4 +-
> >  41 files changed, 10293 insertions(+), 1 deletion(-)
> >  create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dprc.yaml
> >  create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dpu.yaml
> >  create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-prg.yaml
> >  create mode 100644 drivers/gpu/drm/imx/dpu/Kconfig
> >  create mode 100644 drivers/gpu/drm/imx/dpu/Makefile
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-constframe.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-core.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-crtc.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-crtc.h
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-disengcfg.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-dprc.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-dprc.h
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-drv.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-drv.h
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-extdst.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-fetchdecode.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-fetcheco.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-fetchlayer.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-fetchunit.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-fetchunit.h
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-fetchwarp.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-framegen.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-gammacor.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-hscaler.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-kms.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-kms.h
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-layerblend.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-plane.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-plane.h
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-prg.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-prg.h
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-prv.h
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-tcon.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu-vscaler.c
> >  create mode 100644 drivers/gpu/drm/imx/dpu/dpu.h
> > 
> > -- 
> > 2.7.4
> > 
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2020-11-20  2:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19  9:22 [PATCH 0/8] drm/imx: Introduce i.MX8qxp DPU DRM Liu Ying
2020-11-19  9:22 ` [PATCH 1/8] dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding Liu Ying
2020-11-19 15:46   ` Rob Herring
2020-11-20  3:40     ` Liu Ying
2020-11-19  9:22 ` [PATCH 2/8] dt-bindings: display: imx: Add i.MX8qxp/qm PRG binding Liu Ying
2020-11-19 15:48   ` Rob Herring
2020-11-19  9:22 ` [PATCH 3/8] dt-bindings: display: imx: Add i.MX8qxp/qm DPR channel binding Liu Ying
2020-11-19 15:48   ` Rob Herring
2020-11-19  9:22 ` [PATCH 4/8] drm/atomic: Avoid unused-but-set-variable warning on for_each_old_plane_in_state Liu Ying
2020-11-19  9:22 ` [PATCH 5/8] drm/imx: Introduce i.MX8qxp DPU DRM Liu Ying
2020-11-20 14:38   ` Laurentiu Palcu
2020-11-23  2:45     ` Liu Ying
2020-11-23 12:33       ` Laurentiu Palcu
2020-11-19  9:22 ` [PATCH 6/8] MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver Liu Ying
2020-11-19  9:22 ` [PATCH 7/8] arm64: imx8qxp:dtsi: Introduce DC0 subsystem Liu Ying
2020-11-19  9:22 ` [PATCH 8/8] arm64: dts: imx8qxp-mek: Enable DPU and it's prefetch engines Liu Ying
2020-11-19 17:30 ` [PATCH 0/8] drm/imx: Introduce i.MX8qxp DPU DRM Laurentiu Palcu
2020-11-20  2:23   ` Liu Ying [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb134d2ac1e9cebdb27b780ebacf9d944d517205.camel@nxp.com \
    --to=victor.liu@nxp.com \
    --cc=airlied@linux.ie \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    --cc=laurentiu.palcu@oss.nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).