From: Sui jingfeng <suijingfeng@loongson.cn>
To: Thomas Zimmermann <tzimmermann@suse.de>,
javierm@redhat.com, daniel@ffwll.ch, airlied@gmail.com,
mripard@kernel.org, maarten.lankhorst@linux.intel.com,
zackr@vmware.com, kraxel@redhat.com,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
linux-graphics-maintainer@vmware.com
Subject: Re: [v2,2/8] drm/fbdev-generic: Remove unused prefer_shadow_fbdev flag
Date: Tue, 21 Mar 2023 20:09:34 +0800 [thread overview]
Message-ID: <fcf01f46-1349-205a-f51f-a188670c5728@loongson.cn> (raw)
In-Reply-To: <20230320150751.20399-3-tzimmermann@suse.de>
Well, this patch looks good to me.
Tested-by: Sui Jingfeng <suijingfeng@loongson.cn>
On 2023/3/20 23:07, Thomas Zimmermann wrote:
> Remove the flag prefer_shadow_fbdev from struct drm_mode_config.
> Drivers set this flag to enable shadow buffering in the generic
> fbdev emulation. Such shadow buffering is now mandatory, so the
> flag is unused.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> Reviewed-by: Zack Rusin <zackr@vmware.com>
> ---
> drivers/gpu/drm/tiny/bochs.c | 1 -
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 1 -
> include/drm/drm_mode_config.h | 7 -------
> 3 files changed, 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
> index 024346054c70..d254679a136e 100644
> --- a/drivers/gpu/drm/tiny/bochs.c
> +++ b/drivers/gpu/drm/tiny/bochs.c
> @@ -545,7 +545,6 @@ static int bochs_kms_init(struct bochs_device *bochs)
>
> bochs->dev->mode_config.preferred_depth = 24;
> bochs->dev->mode_config.prefer_shadow = 0;
> - bochs->dev->mode_config.prefer_shadow_fbdev = 1;
> bochs->dev->mode_config.quirk_addfb_prefer_host_byte_order = true;
>
> bochs->dev->mode_config.funcs = &bochs_mode_funcs;
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> index 84d6380b9895..5162a7a12792 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> @@ -2112,7 +2112,6 @@ int vmw_kms_init(struct vmw_private *dev_priv)
> dev->mode_config.max_width = dev_priv->texture_max_width;
> dev->mode_config.max_height = dev_priv->texture_max_height;
> dev->mode_config.preferred_depth = dev_priv->assume_16bpp ? 16 : 32;
> - dev->mode_config.prefer_shadow_fbdev = !dev_priv->has_mob;
>
> drm_mode_create_suggested_offset_properties(dev);
> vmw_kms_create_hotplug_mode_update_property(dev_priv);
> diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
> index e5b053001d22..973119a9176b 100644
> --- a/include/drm/drm_mode_config.h
> +++ b/include/drm/drm_mode_config.h
> @@ -890,13 +890,6 @@ struct drm_mode_config {
> /* dumb ioctl parameters */
> uint32_t preferred_depth, prefer_shadow;
>
> - /**
> - * @prefer_shadow_fbdev:
> - *
> - * Hint to framebuffer emulation to prefer shadow-fb rendering.
> - */
> - bool prefer_shadow_fbdev;
> -
> /**
> * @quirk_addfb_prefer_xbgr_30bpp:
> *
next prev parent reply other threads:[~2023-03-21 12:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 15:07 [PATCH v2 0/8] drm/fbdev-generic: Mandatory shadow buffering Thomas Zimmermann
2023-03-20 15:07 ` [PATCH v2 1/8] drm/fbdev-generic: Always use " Thomas Zimmermann
2023-03-21 15:23 ` [v2,1/8] " Sui jingfeng
2023-03-21 19:12 ` Thomas Zimmermann
2023-03-22 4:24 ` Sui Jingfeng
2023-03-20 15:07 ` [PATCH v2 2/8] drm/fbdev-generic: Remove unused prefer_shadow_fbdev flag Thomas Zimmermann
2023-03-21 12:09 ` Sui jingfeng [this message]
2023-03-20 15:07 ` [PATCH v2 3/8] drm/fb-helper: Export drm_fb_helper_release_info() Thomas Zimmermann
2023-03-21 16:34 ` [v2,3/8] " Sui jingfeng
2023-03-20 15:07 ` [PATCH v2 4/8] drm/fb-helper: Support smem_len in deferred I/O Thomas Zimmermann
2023-03-20 16:31 ` Javier Martinez Canillas
2023-03-22 7:39 ` [v2,4/8] " Sui Jingfeng
2023-03-20 15:07 ` [PATCH v2 5/8] drm/fbdev-generic: Set screen size to size of GEM buffer Thomas Zimmermann
2023-03-20 16:32 ` Javier Martinez Canillas
2023-03-22 7:28 ` [v2, " Sui Jingfeng
2023-03-20 15:07 ` [PATCH v2 6/8] drm/fbdev-generic: Clean up after failed probing Thomas Zimmermann
2023-03-22 7:26 ` [v2,6/8] " Sui Jingfeng
2023-03-20 15:07 ` [PATCH v2 7/8] drm/fb-helper: Consolidate CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM Thomas Zimmermann
2023-03-21 16:22 ` [v2,7/8] " Sui jingfeng
2023-03-20 15:07 ` [PATCH v2 8/8] drm/fbdev-generic: Rename symbols Thomas Zimmermann
2023-03-21 16:07 ` [v2,8/8] " Sui jingfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcf01f46-1349-205a-f51f-a188670c5728@loongson.cn \
--to=suijingfeng@loongson.cn \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=kraxel@redhat.com \
--cc=linux-graphics-maintainer@vmware.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=zackr@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).