From: Javier Martinez Canillas <javierm@redhat.com>
To: Xi Ruoyao <xry111@linuxfromscratch.org>,
Zack Rusin <zackr@vmware.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"deller@gmx.de" <deller@gmx.de>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
Linux-graphics-maintainer <Linux-graphics-maintainer@vmware.com>,
"kraxel@redhat.com" <kraxel@redhat.com>,
"tzimmermann@suse.de" <tzimmermann@suse.de>,
"daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
"lersek@redhat.com" <lersek@redhat.com>
Subject: Re: [PATCH v6 3/5] fbdev: Disable sysfb device registration when removing conflicting FBs
Date: Mon, 4 Jul 2022 13:04:21 +0200 [thread overview]
Message-ID: <fddf5ca6-77dc-88f9-c191-7de09717063c@redhat.com> (raw)
In-Reply-To: <61f2e4e2af40cb9d853504d0a6fe01829ff8ca60.camel@linuxfromscratch.org>
Hello Xi,
On 7/4/22 12:29, Xi Ruoyao wrote:
> On Mon, 2022-07-04 at 17:36 +0800, Xi Ruoyao wrote:
>
>>> Yes, please do. Either with CONFIG_SYSFB_SIMPLEFB disabled and CONFIG_FB_EFI
>>> enabled (so that "efi-framebuffer" is registered and efifb probed) or with
>>> CONFIG_SYSFB_SIMPLEFB but CONFIG_FB_SIMPLE enabled (so "simple-framebuffer
>>> is used too but with simplefb instead of simpledrm).
>>>
>>> I'm not able to reproduce, it would be useful to have another data point.
>>
>> Also happening for me with CONFIG_SYSFB_SIMPLEFB, on a Intel Core i7-
>> 1065G7 (with iGPU).
>>
>> Reverting this commit on top of 5.19-rc5 "fixes" the issue.
>
> With CONFIG_SYSFB_SIMPLEFB and CONFIG_FB_SIMPLE enabled, there is no
> issue.
>
> I guess it's something going wrong on a "drm -> drm" pass over. For now
> I'll continue to use simpledrm with this commit reverted.
>
Yes, we need to also cherry-pick b84efa28a48 ("drm/aperture: Run fbdev
removal before internal helpers") now that the sysfb_disable() patches
are in v5.19-rc5.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-07-04 16:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 18:23 [PATCH v6 0/5] Fix some races between sysfb device registration and drivers probe Javier Martinez Canillas
2022-06-07 18:23 ` [PATCH v6 1/5] firmware: sysfb: Make sysfb_create_simplefb() return a pdev pointer Javier Martinez Canillas
2022-06-07 18:23 ` [PATCH v6 2/5] firmware: sysfb: Add sysfb_disable() helper function Javier Martinez Canillas
2022-06-07 18:23 ` [PATCH v6 3/5] fbdev: Disable sysfb device registration when removing conflicting FBs Javier Martinez Canillas
2022-06-16 19:29 ` Zack Rusin
2022-06-16 19:55 ` Javier Martinez Canillas
2022-06-16 21:03 ` Zack Rusin
2022-06-16 22:18 ` Javier Martinez Canillas
2022-06-16 23:21 ` Javier Martinez Canillas
2022-06-17 1:35 ` Zack Rusin
2022-06-17 6:46 ` Javier Martinez Canillas
2022-07-04 9:36 ` Xi Ruoyao
2022-07-04 10:29 ` Xi Ruoyao
2022-07-04 11:04 ` Javier Martinez Canillas [this message]
2022-07-04 12:11 ` Xi Ruoyao
2022-07-04 12:22 ` Javier Martinez Canillas
2022-07-04 12:22 ` Thomas Zimmermann
2022-06-07 18:23 ` [PATCH v6 4/5] Revert "fbdev: Prevent probing generic drivers if a FB is already registered" Javier Martinez Canillas
2022-06-07 18:23 ` [PATCH v6 5/5] fbdev: Make registered_fb[] private to fbmem.c Javier Martinez Canillas
2022-06-09 11:49 ` Thomas Zimmermann
2022-06-09 13:09 ` Javier Martinez Canillas
2022-06-09 17:23 ` Mark olpc_dcon BROKEN [Was: [PATCH v6 5/5] fbdev: Make registered_fb[] private to fbmem.c] Sam Ravnborg
2022-06-09 17:38 ` Javier Martinez Canillas
2022-06-09 14:28 ` [PATCH v6 0/5] Fix some races between sysfb device registration and drivers probe Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fddf5ca6-77dc-88f9-c191-7de09717063c@redhat.com \
--to=javierm@redhat.com \
--cc=Linux-graphics-maintainer@vmware.com \
--cc=alex.williamson@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lersek@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=xry111@linuxfromscratch.org \
--cc=zackr@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).