From: Thomas Zimmermann <tzimmermann@suse.de>
To: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: airlied@linux.ie, jenmin_yuan@aspeedtech.com,
tommy_huang@aspeedtech.com, arc_sung@aspeedtech.com,
airlied@redhat.com
Subject: Re: [PATCH] drm/ast: Update the sequence of Clearing Fast-reset
Date: Thu, 21 Jan 2021 08:55:56 +0100 [thread overview]
Message-ID: <fe524173-058a-1e6b-503a-6c2294e7594a@suse.de> (raw)
In-Reply-To: <20210118085755.107804-1-kuohsiang_chou@aspeedtech.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 2004 bytes --]
Hi
Am 18.01.21 um 09:57 schrieb KuoHsiang Chou:
> [Bug][AST2500]
> If SCU00 is not unlocked, just enter its password again.
> It is unnecessary to clear AHB lock condition and restore WDT default
> setting again, before Fast-reset clearing.
>
> Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com>
Is this a separate issue? This patch looks like a fix for the previous
patch. [1] Can you add this change to v3 of the other patch?
Best regards
Thomas
[1]
https://lore.kernel.org/dri-devel/20210112075811.9354-1-kuohsiang_chou@aspeedtech.com/
> ---
> drivers/gpu/drm/ast/ast_post.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_post.c b/drivers/gpu/drm/ast/ast_post.c
> index 1f0007daa005..4f194c5fd2c2 100644
> --- a/drivers/gpu/drm/ast/ast_post.c
> +++ b/drivers/gpu/drm/ast/ast_post.c
> @@ -2030,7 +2030,6 @@ void ast_patch_ahb_2500(struct ast_private *ast)
> {
> u32 data;
>
> -patch_ahb_lock:
> /* Clear bus lock condition */
> ast_moutdwm(ast, 0x1e600000, 0xAEED1A03);
> ast_moutdwm(ast, 0x1e600084, 0x00010000);
> @@ -2044,11 +2043,9 @@ void ast_patch_ahb_2500(struct ast_private *ast)
> ast_moutdwm(ast, 0x1E78500c, 0x00000033);
> udelay(1000);
> }
> - ast_moutdwm(ast, 0x1e6e2000, 0x1688A8A8);
> do {
> + ast_moutdwm(ast, 0x1e6e2000, 0x1688A8A8);
> data = ast_mindwm(ast, 0x1e6e2000);
> - if (data == 0xffffffff)
> - goto patch_ahb_lock;
> } while (data != 1);
> ast_moutdwm(ast, 0x1e6e207c, 0x08000000); /* clear fast reset */
> }
> --
> 2.18.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-21 7:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 8:57 [PATCH] drm/ast: Update the sequence of Clearing Fast-reset KuoHsiang Chou
2021-01-21 7:55 ` Thomas Zimmermann [this message]
2021-01-21 8:42 ` Kuo-Hsiang Chou
2021-03-19 9:23 ` [PATCH V3] drm/ast: Disable fast reset after DRAM initial KuoHsiang Chou
2021-03-29 9:17 ` Thomas Zimmermann
2021-03-31 6:56 ` Kuo-Hsiang Chou
2021-03-31 7:20 ` Thomas Zimmermann
2021-04-08 9:30 ` [PATCH v4] drm/ast: Fixed CVE for DP501 KuoHsiang Chou
2021-04-12 7:45 ` Thomas Zimmermann
2021-04-21 8:58 ` [PATCH v5] " KuoHsiang Chou
2021-04-27 11:01 ` Thomas Zimmermann
2021-04-29 9:21 ` Kuo-Hsiang Chou
2021-08-03 8:58 ` Thomas Zimmermann
2021-08-04 2:20 ` Kuo-Hsiang Chou
2021-05-07 9:27 ` [PATCH v4] drm/ast: Disable fast reset after DRAM initial KuoHsiang Chou
2021-05-26 10:24 ` Kuo-Hsiang Chou
2021-06-21 11:06 ` Kuo-Hsiang Chou
2021-06-21 12:46 ` Thomas Zimmermann
2021-06-23 8:02 ` Thomas Zimmermann
2021-07-09 8:09 ` [PATCH v5] " KuoHsiang Chou
2021-07-20 8:49 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe524173-058a-1e6b-503a-6c2294e7594a@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=arc_sung@aspeedtech.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jenmin_yuan@aspeedtech.com \
--cc=kuohsiang_chou@aspeedtech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tommy_huang@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).