From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=R2cM=A5=lists.freedesktop.org=dri-devel-bounces@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_INVALID,
	DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,
	SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1
	autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 67D0EC433E0
	for <dri-devel@archiver.kernel.org>; Sat, 18 Jul 2020 03:13:28 +0000 (UTC)
Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id 2F19D2073E
	for <dri-devel@archiver.kernel.org>; Sat, 18 Jul 2020 03:13:27 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="f7mjMYz5"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F19D2073E
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org
Received: from gabe.freedesktop.org (localhost [127.0.0.1])
	by gabe.freedesktop.org (Postfix) with ESMTP id 0CB956E0E2;
	Sat, 18 Jul 2020 03:13:24 +0000 (UTC)
Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com
 [216.228.121.143])
 by gabe.freedesktop.org (Postfix) with ESMTPS id A278B6E0A6;
 Sat, 18 Jul 2020 03:13:22 +0000 (UTC)
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by
 hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
 id <B5f12685d0000>; Fri, 17 Jul 2020 20:11:25 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
 by hqpgpgate101.nvidia.com (PGP Universal service);
 Fri, 17 Jul 2020 20:13:22 -0700
X-PGP-Universal: processed;
 by hqpgpgate101.nvidia.com on Fri, 17 Jul 2020 20:13:22 -0700
Received: from [172.20.40.65] (172.20.13.39) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 18 Jul
 2020 03:13:21 +0000
Subject: Re: [PATCH] drm/nouveau: Accept 'legacy' format modifiers
To: "Kirill A. Shutemov" <kirill@shutemov.name>
References: <20200717185757.2786-1-jajones@nvidia.com>
 <20200717213026.eisp7qaf4ckskemx@box>
From: James Jones <jajones@nvidia.com>
Message-ID: <ff5a8c9b-fe3d-48dd-93bc-3e1a18e0ff55@nvidia.com>
Date: Fri, 17 Jul 2020 20:13:19 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200717213026.eisp7qaf4ckskemx@box>
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Language: en-US
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
 t=1595041885; bh=oYARuV4SO6Vp0UAdLAUsR1SAG2c8FJk47l2wqhE3wWw=;
 h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
 User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
 X-ClientProxiedBy:Content-Type:Content-Language:
 Content-Transfer-Encoding;
 b=f7mjMYz5bNX+EV+/rswcQQfV2qmfMcbPIm78Ei+0UH75R8CxCCdT5Q5a2ByUgguir
 P3x64OgRtjPEOHKV8HxmglyuE++2UgpK45KIUAOxq+zDnBUw7oSKeRPsvRzGWUmWw0
 9xdiXEx+HUoCHrxIfmeXQz7mKWG7jRw0Kum8aXFOamipxrXl4rBC4e4o7UqD0e9aFR
 6EwsqeeXBg/aLh84Xwv3wH5dWCuUZVnXeEsNlMphKAtB1ATN6kuP8nP+MB1MxCCw5u
 IyfQ3TEg2Y+C5vDfPMQs9RfHKUNoX4FgJsA7wleiFjLVYP3Ag+NFhEMliZjd6QIXe5
 N7+v3L0hM5Nwg==
X-BeenThere: dri-devel@lists.freedesktop.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Direct Rendering Infrastructure - Development
 <dri-devel.lists.freedesktop.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Ben Skeggs <bskeggs@redhat.com>,
 dri-devel <dri-devel@lists.freedesktop.org>,
 Nouveau <nouveau@lists.freedesktop.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>

This doesn't look related.

-James

On 7/17/20 2:30 PM, Kirill A. Shutemov wrote:
> On Fri, Jul 17, 2020 at 11:57:57AM -0700, James Jones wrote:
>> Accept the DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK()
>> family of modifiers to handle broken userspace
>> Xorg modesetting and Mesa drivers.
>>
>> Tested with Xorg 1.20 modesetting driver,
>> weston@c46c70dac84a4b3030cd05b380f9f410536690fc,
>> gnome & KDE wayland desktops from Ubuntu 18.04,
>> and sway 1.5
>>
>> Signed-off-by: James Jones <jajones@nvidia.com>
> 
> I tried and it crashes. Not sure if it's related.
> 
> [drm:drm_ioctl] pid=3327, dev=0xe200, auth=1, NOUVEAU_GEM_PUSHBUF
> [drm:vblank_disable_fn] disabling vblank on crtc 0
> [drm:drm_ioctl] pid=3351, dev=0xe200, auth=1, NOUVEAU_GEM_PUSHBUF
> [drm:drm_ioctl] pid=3351, dev=0xe200, auth=1, NOUVEAU_GEM_CPU_PREP
> [drm:drm_ioctl] pid=3351, dev=0xe200, auth=1, NOUVEAU_GEM_PUSHBUF
> [drm:drm_ioctl] pid=3351, dev=0xe200, auth=1, NOUVEAU_GEM_PUSHBUF
> BUG: unable to handle page fault for address: 00000000ffff059c
> #PF: supervisor read access in kernel mode
> #PF: error_code(0x0000) - not-present page
> PGD 0 P4D 0
> Oops: 0000 [#1] PREEMPT SMP PTI
> CPU: 13 PID: 3351 Comm: alacritty Tainted: G          I       5.8.0-rc5-00191-g086f86c033f9 #53
> Hardware name: Gigabyte Technology Co., Ltd. X299 AORUS Gaming 3 Pro/X299 AORUS Gaming 3 Pro-CF, BIOS F5d 11/28/2019
> RIP: 0010:kmem_cache_alloc_trace (/home/kas/linux/torvalds/mm/slub.c:272 /home/kas/linux/torvalds/mm/slub.c:278 /home/kas/linux/torvalds/mm/slub.c:292 /home/kas/linux/torvalds/mm/slub.c:2791 /home/kas/linux/torvalds/mm/slub.c:2832 /home/kas/linux/torvalds/mm/slub.c:2849)
> Code: 8b 51 08 48 89 c8 65 48 03 05 d4 0e ca 70 48 8b 70 08 48 39 f2 75 e7 4c 8b 38 4d 85 ff 0f 84 8f 01 00 00 8b 45 20 48 8b 7d 00 <49> 8b 1c 07 40 f6 c7 0f 0f 85 95 01 00 00 48 8d 8a 80 00 00 00 4c
> All code
> ========
>     0:	8b 51 08             	mov    0x8(%rcx),%edx
>     3:	48 89 c8             	mov    %rcx,%rax
>     6:	65 48 03 05 d4 0e ca 	add    %gs:0x70ca0ed4(%rip),%rax        # 0x70ca0ee2
>     d:	70
>     e:	48 8b 70 08          	mov    0x8(%rax),%rsi
>    12:	48 39 f2             	cmp    %rsi,%rdx
>    15:	75 e7                	jne    0xfffffffffffffffe
>    17:	4c 8b 38             	mov    (%rax),%r15
>    1a:	4d 85 ff             	test   %r15,%r15
>    1d:	0f 84 8f 01 00 00    	je     0x1b2
>    23:	8b 45 20             	mov    0x20(%rbp),%eax
>    26:	48 8b 7d 00          	mov    0x0(%rbp),%rdi
>    2a:*	49 8b 1c 07          	mov    (%r15,%rax,1),%rbx		<-- trapping instruction
>    2e:	40 f6 c7 0f          	test   $0xf,%dil
>    32:	0f 85 95 01 00 00    	jne    0x1cd
>    38:	48 8d 8a 80 00 00 00 	lea    0x80(%rdx),%rcx
>    3f:	4c                   	rex.WR
> 
> Code starting with the faulting instruction
> ===========================================
>     0:	49 8b 1c 07          	mov    (%r15,%rax,1),%rbx
>     4:	40 f6 c7 0f          	test   $0xf,%dil
>     8:	0f 85 95 01 00 00    	jne    0x1a3
>     e:	48 8d 8a 80 00 00 00 	lea    0x80(%rdx),%rcx
>    15:	4c                   	rex.WR
> RSP: 0018:ffffa8a381bcfba0 EFLAGS: 00010206
> RAX: 0000000000000030 RBX: ffff9c0b15e05e00 RCX: 000000000003fe50
> RDX: 000000000000fc8d RSI: 000000000000fc8d RDI: 000000000003fe50
> RBP: ffff9c0b18407840 R08: 0000000000000000 R09: 0000000000000001
> R10: ffff9c0b06c28000 R11: 0000000000000001 R12: 0000000000000dc0
> [drm:drm_ioctl] pid=3327, dev=0xe200, auth=1, DRM_IOCTL_CRTC_GET_SEQUENCE
> R13: 0000000000000060 R14: ffffffff8fa35a47 R15: 00000000ffff056c
> FS:  00007fbe7a8e3900(0000) GS:ffff9c0b1f880000(0000) knlGS:0000000000000000
> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 00000000ffff059c CR3: 000000103c7fe004 CR4: 00000000003606e0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> Call Trace:
> nouveau_fence_new (/home/kas/linux/torvalds/include/linux/slab.h:555 /home/kas/linux/torvalds/include/linux/slab.h:669 /home/kas/linux/torvalds/drivers/gpu/drm/nouveau/nouveau_fence.c:423)
> [drm:drm_vblank_enable] enabling vblank on crtc 0, ret: 0
> nouveau_gem_ioctl_pushbuf (/home/kas/linux/torvalds/drivers/gpu/drm/nouveau/nouveau_gem.c:852)
> [drm:drm_ioctl] pid=3327, dev=0xe200, auth=1, DRM_IOCTL_CRTC_QUEUE_SEQUENCE
> ? nouveau_gem_ioctl_new (/home/kas/linux/torvalds/drivers/gpu/drm/nouveau/nouveau_gem.c:680)
> ? drm_ioctl_kernel (/home/kas/linux/torvalds/drivers/gpu/drm/drm_ioctl.c:793)
> ? nouveau_gem_ioctl_new (/home/kas/linux/torvalds/drivers/gpu/drm/nouveau/nouveau_gem.c:680)
> drm_ioctl_kernel (/home/kas/linux/torvalds/drivers/gpu/drm/drm_ioctl.c:793)
> drm_ioctl (/home/kas/linux/torvalds/drivers/gpu/drm/drm_ioctl.c:888)
> ? nouveau_gem_ioctl_new (/home/kas/linux/torvalds/drivers/gpu/drm/nouveau/nouveau_gem.c:680)
> ? _raw_spin_unlock_irqrestore (/home/kas/linux/torvalds/arch/x86/include/asm/irqflags.h:41 /home/kas/linux/torvalds/arch/x86/include/asm/irqflags.h:84 /home/kas/linux/torvalds/include/linux/spinlock_api_smp.h:160 /home/kas/linux/torvalds/kernel/locking/spinlock.c:191)
> ? lockdep_hardirqs_on (/home/kas/linux/torvalds/kernel/locking/lockdep.c:3727 (discriminator 3))
> ? _raw_spin_unlock_irqrestore (/home/kas/linux/torvalds/arch/x86/include/asm/preempt.h:102 /home/kas/linux/torvalds/include/linux/spinlock_api_smp.h:161 /home/kas/linux/torvalds/kernel/locking/spinlock.c:191)
> nouveau_drm_ioctl (/home/kas/linux/torvalds/drivers/gpu/drm/nouveau/nouveau_drm.c:1120)
> ksys_ioctl (/home/kas/linux/torvalds/fs/ioctl.c:48 /home/kas/linux/torvalds/fs/ioctl.c:753)
> __x64_sys_ioctl (/home/kas/linux/torvalds/fs/ioctl.c:762 /home/kas/linux/torvalds/fs/ioctl.c:760 /home/kas/linux/torvalds/fs/ioctl.c:760)
> do_syscall_64 (/home/kas/linux/torvalds/arch/x86/entry/common.c:384)
> entry_SYSCALL_64_after_hwframe (/home/kas/linux/torvalds/arch/x86/entry/entry_64.S:124)
> RIP: 0033:0x7fbe7ab9cd37
> Code: Bad RIP value.
> 
> Code starting with the faulting instruction
> ===========================================
> RSP: 002b:00007fff4c0cf0e8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> RAX: ffffffffffffffda RBX: 00007fff4c0cf150 RCX: 00007fbe7ab9cd37
> RDX: 00007fff4c0cf150 RSI: 00000000c0406481 RDI: 0000000000000009
> RBP: 00000000c0406481 R08: 000055db823225e8 R09: 000055db8231b5e8
> R10: 00007fbe79ce0920 R11: 0000000000000246 R12: 000055db823115e0
> R13: 0000000000000009 R14: 000055db8230ffc0 R15: 000055db8230f380
> Modules linked in:
> CR2: 00000000ffff059c
> ---[ end trace 9db4c132a431e9c9 ]---
> RIP: 0010:kmem_cache_alloc_trace (/home/kas/linux/torvalds/mm/slub.c:272 /home/kas/linux/torvalds/mm/slub.c:278 /home/kas/linux/torvalds/mm/slub.c:292 /home/kas/linux/torvalds/mm/slub.c:2791 /home/kas/linux/torvalds/mm/slub.c:2832 /home/kas/linux/torvalds/mm/slub.c:2849)
> Code: 8b 51 08 48 89 c8 65 48 03 05 d4 0e ca 70 48 8b 70 08 48 39 f2 75 e7 4c 8b 38 4d 85 ff 0f 84 8f 01 00 00 8b 45 20 48 8b 7d 00 <49> 8b 1c 07 40 f6 c7 0f 0f 85 95 01 00 00 48 8d 8a 80 00 00 00 4c
> All code
> ========
>     0:	8b 51 08             	mov    0x8(%rcx),%edx
>     3:	48 89 c8             	mov    %rcx,%rax
>     6:	65 48 03 05 d4 0e ca 	add    %gs:0x70ca0ed4(%rip),%rax        # 0x70ca0ee2
>     d:	70
>     e:	48 8b 70 08          	mov    0x8(%rax),%rsi
>    12:	48 39 f2             	cmp    %rsi,%rdx
>    15:	75 e7                	jne    0xfffffffffffffffe
>    17:	4c 8b 38             	mov    (%rax),%r15
>    1a:	4d 85 ff             	test   %r15,%r15
>    1d:	0f 84 8f 01 00 00    	je     0x1b2
>    23:	8b 45 20             	mov    0x20(%rbp),%eax
>    26:	48 8b 7d 00          	mov    0x0(%rbp),%rdi
>    2a:*	49 8b 1c 07          	mov    (%r15,%rax,1),%rbx		<-- trapping instruction
>    2e:	40 f6 c7 0f          	test   $0xf,%dil
>    32:	0f 85 95 01 00 00    	jne    0x1cd
>    38:	48 8d 8a 80 00 00 00 	lea    0x80(%rdx),%rcx
>    3f:	4c                   	rex.WR
> 
> Code starting with the faulting instruction
> ===========================================
>     0:	49 8b 1c 07          	mov    (%r15,%rax,1),%rbx
>     4:	40 f6 c7 0f          	test   $0xf,%dil
>     8:	0f 85 95 01 00 00    	jne    0x1a3
>     e:	48 8d 8a 80 00 00 00 	lea    0x80(%rdx),%rcx
>    15:	4c                   	rex.WR
> RSP: 0018:ffffa8a381bcfba0 EFLAGS: 00010206
> RAX: 0000000000000030 RBX: ffff9c0b15e05e00 RCX: 000000000003fe50
> RDX: 000000000000fc8d RSI: 000000000000fc8d RDI: 000000000003fe50
> RBP: ffff9c0b18407840 R08: 0000000000000000 R09: 0000000000000001
> R10: ffff9c0b06c28000 R11: 0000000000000001 R12: 0000000000000dc0
> R13: 0000000000000060 R14: ffffffff8fa35a47 R15: 00000000ffff056c
> FS:  00007fbe7a8e3900(0000) GS:ffff9c0b1f880000(0000) knlGS:0000000000000000
> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 00000000ffff059c CR3: 000000103c7fe004 CR4: 00000000003606e0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> BUG: sleeping function called from invalid context at include/linux/percpu-rwsem.h:49
> in_atomic(): 0, irqs_disabled(): 1, non_block: 0, pid: 3351, name: alacritty
> INFO: lockdep is turned off.
> irq event stamp: 302346
> hardirqs last enabled at (302345): kfree_call_rcu (/home/kas/linux/torvalds/arch/x86/include/asm/irqflags.h:41 (discriminator 2) /home/kas/linux/torvalds/arch/x86/include/asm/irqflags.h:84 (discriminator 2) /home/kas/linux/torvalds/kernel/rcu/tree.c:3287 (discriminator 2))
> hardirqs last disabled at (302346): idtentry_enter_cond_rcu (/home/kas/linux/torvalds/arch/x86/entry/common.c:652)
> softirqs last enabled at (302186): __do_softirq (/home/kas/linux/torvalds/arch/x86/include/asm/preempt.h:26 /home/kas/linux/torvalds/kernel/softirq.c:320)
> softirqs last disabled at (302175): asm_call_on_stack (/home/kas/linux/torvalds/arch/x86/entry/entry_64.S:719)
> CPU: 13 PID: 3351 Comm: alacritty Tainted: G      D   I       5.8.0-rc5-00191-g086f86c033f9 #53
> Hardware name: Gigabyte Technology Co., Ltd. X299 AORUS Gaming 3 Pro/X299 AORUS Gaming 3 Pro-CF, BIOS F5d 11/28/2019
> Call Trace:
> dump_stack (/home/kas/linux/torvalds/lib/dump_stack.c:120)
> ___might_sleep.cold (/home/kas/linux/torvalds/kernel/sched/core.c:6900)
> exit_signals (/home/kas/linux/torvalds/include/linux/percpu-rwsem.h:51 /home/kas/linux/torvalds/include/linux/cgroup-defs.h:733 /home/kas/linux/torvalds/kernel/signal.c:2828)
> do_exit (/home/kas/linux/torvalds/kernel/exit.c:764)
> ? ksys_ioctl (/home/kas/linux/torvalds/fs/ioctl.c:48 /home/kas/linux/torvalds/fs/ioctl.c:753)
> rewind_stack_do_exit (/home/kas/linux/torvalds/arch/x86/entry/thunk_64.S:40)
> RIP: 0033:0x7fbe7ab9cd37
> Code: Bad RIP value.
> 
> Code starting with the faulting instruction
> ===========================================
> RSP: 002b:00007fff4c0cf0e8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> RAX: ffffffffffffffda RBX: 00007fff4c0cf150 RCX: 00007fbe7ab9cd37
> RDX: 00007fff4c0cf150 RSI: 00000000c0406481 RDI: 0000000000000009
> RBP: 00000000c0406481 R08: 000055db823225e8 R09: 000055db8231b5e8
> R10: 00007fbe79ce0920 R11: 0000000000000246 R12: 000055db823115e0
> R13: 0000000000000009 R14: 000055db8230ffc0 R15: 000055db8230f380
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel