From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15888EB64D9 for ; Thu, 15 Jun 2023 12:25:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 21F8310E18C; Thu, 15 Jun 2023 12:25:44 +0000 (UTC) Received: from relay08.th.seeweb.it (relay08.th.seeweb.it [5.144.164.169]) by gabe.freedesktop.org (Postfix) with ESMTPS id 50A6810E18C for ; Thu, 15 Jun 2023 12:25:41 +0000 (UTC) Received: from SoMainline.org (82-72-63-87.cable.dynamic.v4.ziggo.nl [82.72.63.87]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 4F5AF3FB06; Thu, 15 Jun 2023 14:25:37 +0200 (CEST) Date: Thu, 15 Jun 2023 14:25:35 +0200 From: Marijn Suijten To: Dmitry Baryshkov Subject: Re: [PATCH v6 0/6] Add DSC v1.2 Support for DSI Message-ID: References: <20230405-add-dsc-support-v6-0-95eab864d1b6@quicinc.com> <168682860387.384026.9115594076193676039.b4-ty@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <168682860387.384026.9115594076193676039.b4-ty@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Sean Paul , Abhinav Kumar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio , linux-arm-msm@vger.kernel.org, Jessica Zhang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2023-06-15 14:31:26, Dmitry Baryshkov wrote: > > On Fri, 09 Jun 2023 15:57:12 -0700, Jessica Zhang wrote: > > This is a series of changes for DSI to enable command mode support > > for DSC v1.2. > > > > This includes: > > > > 1) Rounding up `hdisplay / 3` in dsc_timing_setup() > > 2) Adjusting pclk_rate to account for compression > > 3) Fixing incorrect uses of slice_count in DSI DSC calculations > > 4) Setting the DATA_COMPRESS bit when DSC is enabled > > > > [...] > > Applied, thanks! > > [1/6] msm/drm/dsi: Round up DSC hdisplay calculation > https://gitlab.freedesktop.org/lumag/msm/-/commit/21bf617110ba > [2/6] drm/msm/dsi: Reduce pclk rate for compression > https://gitlab.freedesktop.org/lumag/msm/-/commit/7c9e4a554d4a > [3/6] drm/msm/dpu: Add DPU_INTF_DATA_COMPRESS feature flag for DPU >= 7.0 > https://gitlab.freedesktop.org/lumag/msm/-/commit/22598cfc94bb > [4/6] drm/msm/dpu: Set DATA_COMPRESS on command mode for DCE/DSC 1.2 > https://gitlab.freedesktop.org/lumag/msm/-/commit/1642b5803473 > [5/6] drm/msm/dsi: Remove incorrect references to slice_count > https://gitlab.freedesktop.org/lumag/msm/-/commit/155fa3a91d64 > > Note, patch 6 is skipped for now Note that we also haven't finished discussions on where the ratio in patch 2/6 comes from and how that should be outlined in patch 6. Related to the widebus patches which affect the ratio as well. - Marijn