From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7E30C2BB54 for ; Thu, 9 Apr 2020 07:34:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A181F206F7 for ; Thu, 9 Apr 2020 07:34:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="U8ETg0PM"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=fluxnic.net header.i=@fluxnic.net header.b="BpSnWiZO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A181F206F7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fluxnic.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C83696EB6B; Thu, 9 Apr 2020 07:33:39 +0000 (UTC) X-Greylist: delayed 311 seconds by postgrey-1.36 at gabe; Wed, 08 Apr 2020 20:43:49 UTC Received: from pb-smtp20.pobox.com (pb-smtp20.pobox.com [173.228.157.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id 26C3C6EAFB for ; Wed, 8 Apr 2020 20:43:49 +0000 (UTC) Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 64119B233D; Wed, 8 Apr 2020 16:38:36 -0400 (EDT) (envelope-from nico@fluxnic.net) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=date:from:to :cc:subject:in-reply-to:message-id:references:mime-version :content-type; s=sasl; bh=FXs96PD9q6AihpPiIw66bQCCq08=; b=U8ETg0 PMUzCxd1Etp4NTyjwzMVnSGylSOEkCEBXTKQYzm7o3Acpusy+ZC2z7Ra8sWzvHP9 pnt3xOIbUpkedWag6NuNCVdmiLjRH674iDjF8gcmVmbVPGZCZuNTyiYLda7vq6lL RYQd+jNEdW+/AJGlaJ8XO2ozC2x4gdHJmqJFw= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 5B0C5B233C; Wed, 8 Apr 2020 16:38:36 -0400 (EDT) (envelope-from nico@fluxnic.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=fluxnic.net; h=date:from:to:cc:subject:in-reply-to:message-id:references:mime-version:content-type; s=2016-12.pbsmtp; bh=qLgNDpEXsnrm/8QYj83jowhEfOt5/wA6l8IQuAQGxlY=; b=BpSnWiZOUdexci0KAuec0G+2jfPVozIKdqH97mGEA108YctqFuRxRffnGzGrPwh2foY4yVjd0fKDiPFWkJWkdmQthCj9TJyaqJ7SNxaaysIuRmFzGAdaXTKY7K1rT6cxW0LYK3KBQUU/n1fyLp+kXrbsfctkypwMeTILo06PQv4= Received: from yoda.home (unknown [24.203.50.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id D8611B2338; Wed, 8 Apr 2020 16:38:31 -0400 (EDT) (envelope-from nico@fluxnic.net) Received: from xanadu.home (xanadu.home [192.168.2.2]) by yoda.home (Postfix) with ESMTPSA id F39562DA0D3A; Wed, 8 Apr 2020 16:38:29 -0400 (EDT) Date: Wed, 8 Apr 2020 16:38:29 -0400 (EDT) From: Nicolas Pitre To: Arnd Bergmann Subject: Re: [RFC 0/6] Regressions for "imply" behavior change In-Reply-To: <20200408202711.1198966-1-arnd@arndb.de> Message-ID: References: <20200408202711.1198966-1-arnd@arndb.de> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 X-Pobox-Relay-ID: E91C3C66-79D8-11EA-84B4-B0405B776F7B-78420484!pb-smtp20.pobox.com X-Mailman-Approved-At: Thu, 09 Apr 2020 07:33:24 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Leon Romanovsky , Jonas Karlman , David Airlie , netdev@vger.kernel.org, Masahiro Yamada , Neil Armstrong , Saeed Mahameed , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Andrzej Hajda , Kieran Bingham , Laurent Pinchart , "David S. Miller" , linux-rdma@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 8 Apr 2020, Arnd Bergmann wrote: > Hi everyone, > > I've just restarted doing randconfig builds on top of mainline Linux and > found a couple of regressions with missing dependency from the recent > change in the "imply" keyword in Kconfig, presumably these two patches: > > 3a9dd3ecb207 kconfig: make 'imply' obey the direct dependency > def2fbffe62c kconfig: allow symbols implied by y to become m > > I have created workarounds for the Kconfig files, which now stop using > imply and do something else in each case. I don't know whether there was > a bug in the kconfig changes that has led to allowing configurations that > were not meant to be legal even with the new semantics, or if the Kconfig > files have simply become incorrect now and the tool works as expected. In most cases it is the code that has to be fixed. It typically does: if (IS_ENABLED(CONFIG_FOO)) foo_init(); Where it should rather do: if (IS_REACHABLE(CONFIG_FOO)) foo_init(); A couple of such patches have been produced and queued in their respective trees already. Nicolas _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel