From: Takashi Iwai <tiwai@suse.de>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: "Maxime Ripard" <maxime.ripard@bootlin.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Sean Paul" <sean@poorly.run>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 2/2] drm/nouveau: Add HD-audio component notifier support
Date: Mon, 22 Jul 2019 17:09:29 +0200 [thread overview]
Message-ID: <s5ho91m6r86.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAKb7UviZ_+6T5yz=p29dTGmVzFov02S+68QZ4_3M5g83pAonLg@mail.gmail.com>
On Mon, 22 Jul 2019 17:00:15 +0200,
Ilia Mirkin wrote:
>
> On Mon, Jul 22, 2019 at 10:38 AM Takashi Iwai <tiwai@suse.de> wrote:
> > +static void
> > +nv50_audio_component_init(struct nouveau_drm *drm)
> > +{
> > + if (!component_add(drm->dev->dev, &nv50_audio_component_bind_ops))
> > + drm->audio.component_registered = true;
> > +}
>
> Pardon my ignorance on this topic ... but are there any ill effects
> from always doing this? For example, the board in question might not
> have ELD support at all (the original G80, covered by dispnv50), or it
> might not have any HDMI/DP ports, or it may have them but just nothing
> is plugged in.
In general, this change shouldn't do anything worse than what we have
currently.
If the board has no ELD support, the HDMI audio won't work at all, and
HD-audio side would know that it's an invalid ELD.
If the nvidia chips has no audio support and it doesn't have the
corresponding HD-audio audio driver exposed as a PCI device, this
component registration is also harmless, just a placeholder until it's
bound.
> Could you confirm that this is all OK?
At least I tested other way round -- the nvidia component implemented
but without HD-audio master component.
Thanks!
Takashi
>
> Thanks,
>
> -ilia
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-07-22 15:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 14:38 [PATCH 0/2] Audio component support for radeon and nouveau Takashi Iwai
2019-07-22 14:38 ` [PATCH 1/2] drm/radeon: Add HD-audio component notifier support Takashi Iwai
2019-07-22 14:44 ` Koenig, Christian
2019-07-22 14:53 ` Takashi Iwai
2019-07-22 15:07 ` Koenig, Christian
2019-07-22 15:21 ` Takashi Iwai
2019-07-22 15:35 ` Alex Deucher
2019-07-22 15:47 ` Takashi Iwai
2019-07-22 16:13 ` Alex Deucher
2019-07-22 15:38 ` Koenig, Christian
2019-07-22 16:00 ` Takashi Iwai
2019-08-27 12:57 ` Alex Deucher
2019-07-22 14:38 ` [PATCH 2/2] drm/nouveau: " Takashi Iwai
2019-07-22 15:00 ` Ilia Mirkin
2019-07-22 15:09 ` Takashi Iwai [this message]
2019-08-27 10:30 ` Takashi Iwai
2020-01-03 23:01 ` Lyude Paul
2020-01-04 8:21 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5ho91m6r86.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alexander.deucher@amd.com \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=imirkin@alum.mit.edu \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).