From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EA66C433ED for ; Wed, 21 Apr 2021 08:02:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7CB4613ED for ; Wed, 21 Apr 2021 08:02:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7CB4613ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B1B46E95B; Wed, 21 Apr 2021 08:02:35 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF40D6E95B for ; Wed, 21 Apr 2021 08:02:33 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7405BB127; Wed, 21 Apr 2021 08:02:32 +0000 (UTC) Date: Wed, 21 Apr 2021 10:02:32 +0200 Message-ID: From: Takashi Iwai To: Gerd Hoffmann Subject: Re: [PATCH] drm/bochs: Add screen blanking support In-Reply-To: <20210421071942.eyzbao63pn54loj2@sirius.home.kraxel.org> References: <20210420165659.23163-1-tiwai@suse.de> <6d2f59c0-113f-2d9e-1fb3-a794dafbd74a@suse.de> <20210421071942.eyzbao63pn54loj2@sirius.home.kraxel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Thomas Zimmermann , virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 21 Apr 2021 09:19:42 +0200, Gerd Hoffmann wrote: > > > > However, a tricky part is that the QEMU vga code does treat VGA_ATT_IW > > > register always as "flip-flop"; the first write is for index and the > > > second write is for the data like palette. Meanwhile, in the current > > > bochs DRM driver, the flip-flop wasn't considered, and it calls only > > > the register update once with the value 0x20. > > > > > > > Unless bochs does things very different, the index should first be reset by > > reading 0x3da. Then write the index, then the data. > > > > https://web.stanford.edu/class/cs140/projects/pintos/specs/freevga/vga/vgareg.htm#attribute > > bochs should follow standard vga logic here. > Also a bochs_set_blank(true/false) helper function probably makes sense. OK, I factored it out to bochs_hw_blank() in v2 patch. thanks, Takashi _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel