From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAA4AEB64D9 for ; Thu, 15 Jun 2023 17:30:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B21B810E0F7; Thu, 15 Jun 2023 17:30:20 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A75810E499; Thu, 15 Jun 2023 08:07:41 +0000 (UTC) Received: from ideasonboard.com (unknown [IPv6:2001:b07:5d2e:52c9:72c3:346:a663:c82d]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BA3F69CA; Thu, 15 Jun 2023 10:07:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1686816427; bh=kbuJJORB55uG1rpi8Q5Xqtf8uPJC39lWv6+lZ0HWqHw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LWH6Z3asRysr0usrMPrOlUIs4Wtu7UOEdOGa0eqA6zv2x8ce0WQxGZkSjIieAFOgb 3QuoClM2c3pnvzYu46v+Aq/qCZ1TQzmcmQkrRf9nlcecqh3CVuQu4wmcBHRielBqJJ gXIKAYaPm7yOZmoQDIDxLNQfdnD6k7ePTZTLOp7g= Date: Thu, 15 Jun 2023 10:07:35 +0200 From: Jacopo Mondi To: Pekka Paalanen Subject: Re: [RFC PATCH v2 00/18] Add DRM CRTC 3D LUT interface Message-ID: References: <20230109143846.1966301-1-mwen@igalia.com> <20230615101405.09745e65@eldfell> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3apr2dpqo7izt23g" Content-Disposition: inline In-Reply-To: <20230615101405.09745e65@eldfell> X-Mailman-Approved-At: Thu, 15 Jun 2023 17:30:19 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, laurent.pinchart+renesas@ideasonboard.com, Shashank Sharma , Rodrigo.Siqueira@amd.com, amd-gfx@lists.freedesktop.org, alex.hung@amd.com, tzimmermann@suse.de, sunpeng.li@amd.com, mripard@kernel.org, Melissa Wen , seanpaul@chromium.org, Jacopo Mondi , bhawanpreet.lakha@amd.com, sungjoon.kim@amd.com, Xinhui.Pan@amd.com, linux-kernel@vger.kernel.org, nicholas.kazlauskas@amd.com, kernel-dev@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com, Joshua Ashton Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --3apr2dpqo7izt23g Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Subject: Re: [RFC PATCH v2 00/18] Add DRM CRTC 3D LUT interface MIME-Version: 1.0 Hi Pekka thanks for the reply On Thu, Jun 15, 2023 at 10:14:05AM +0300, Pekka Paalanen wrote: > On Tue, 13 Jun 2023 17:43:55 +0200 > Jacopo Mondi wrote: > > > Hello > > > > I'm completing the support for 3D LUT on R-Car DU peripheral > > and I have used this series as a base. > > > > I'm wondering, since quite some time has passed without any update if > > this series is still a thing and it makes any sense for me to try to > > bring it forward. > > > > I'm asking as I've noticed: > > "[PATCH 00/36] drm/amd/display: add AMD driver-specific properties for color mgmt" > > > > which seems to supersede this proposal with driver-specific > > properties. > > > > I asked Melissa privately but I wasn't able to get an hold of her, so > > if anyone has any clue feel free to reply :) > > Hi, > > since no-one else replied, I'll point you to the thread starting at > https://lists.freedesktop.org/archives/dri-devel/2023-May/403173.html Yes, Melissa pointed me to that series privately yesterday. However, and here I might be missing something, per-plane properties do not apply well to the HW pipeline I'm looking at. The R-Car DU has a 1D LUT and a 3D LUT at the CRTC level (I guess 'post blending' is the right term here) ? A per-plane property doesn't seem to match how the HW work, but please feel free to correct me as this is all rather new to me and I might be overlooking something. My plan at the moment would have been to base my work on Melissa's RFC and re-send to prop discussions, unless it is certainly a dead-end and I have missed how to properly use per-plane properties on our HW. Thank you! > and continuing to June. That is the plan of getting a common UAPI for > these things. > > > Thanks, > pq > > > > > > Thanks > > j > > > > On Mon, Jan 09, 2023 at 01:38:28PM -0100, Melissa Wen wrote: > > > Hi, > > > > > > After collecting comments in different places, here is a second version > > > of the work on adding DRM CRTC 3D LUT support to the current DRM color > > > mgmt interface. In comparison to previous proposals [1][2][3], here we > > > add 3D LUT before gamma 1D LUT, but also a shaper 1D LUT before 3D LUT, > > > that means the following DRM CRTC color correction pipeline: > > > > > > Blend -> Degamma 1D LUT -> CTM -> Shaper 1D LUT -> 3D LUT -> Gamma 1D LUT > > > > > > and we also add a DRM CRTC LUT3D_MODE property, based on Alex Hung > > > proposal for pre-blending 3D LUT [4] (Thanks!), instead of just a > > > LUT3D_SIZE, that allows userspace to use different supported settings of > > > 3D LUT, fitting VA-API and new color API better. In this sense, I > > > adjusted the pre-blending proposal for post-blending usage. > > > > > > Patches 1-6 targets the addition of shaper LUT and 3D LUT properties to > > > the current DRM CRTC color mgmt pipeline. Patch 6 can be considered an > > > extra/optional patch to define a default value for LUT3D_MODE, inspired > > > by what we do for the plane blend mode property (pre-multiplied). > > > > > > Patches 7-18 targets AMD display code to enable shaper and 3D LUT usage > > > on DCN 301 (our HW case). Patches 7-9 performs code cleanups on current > > > AMD DM colors code, patch 10 updates AMD stream in case of user 3D LUT > > > changes, patch 11/12 rework AMD MPC 3D LUT resource handling by context > > > for DCN 301 (easily extendible to other DCN families). Finally, from > > > 13-18, we wire up SHAPER LUT, LUT3D and LUT3D MODE to AMD display > > > driver, exposing modes supported by HW and programming user shaper and > > > 3D LUT accordingly. > > > > > > Our target userspace is Gamescope/SteamOS. > > > > > > Basic IGT tests were based on [5][6] and are available here (in-progress): > > > https://gitlab.freedesktop.org/mwen/igt-gpu-tools/-/commits/crtc-lut3d-api > > > > > > [1] https://lore.kernel.org/all/20201221015730.28333-1-laurent.pinchart+renesas@ideasonboard.com/ > > > [2] https://github.com/vsyrjala/linux/commit/4d28e8ddf2a076f30f9e5bdc17cbb4656fe23e69 > > > [3] https://lore.kernel.org/amd-gfx/20220619223104.667413-1-mwen@igalia.com/ > > > [4] https://lore.kernel.org/dri-devel/20221004211451.1475215-1-alex.hung@amd.com/ > > > [5] https://patchwork.freedesktop.org/series/90165/ > > > [6] https://patchwork.freedesktop.org/series/109402/ > > > [VA_API] http://intel.github.io/libva/structVAProcFilterParameterBuffer3DLUT.html > > > [KMS_pipe_API] https://gitlab.freedesktop.org/pq/color-and-hdr/-/issues/11 > > > > > > Let me know your thoughts. > > > > > > Thanks, > > > > > > Melissa > > > > > > Alex Hung (2): > > > drm: Add 3D LUT mode and its attributes > > > drm/amd/display: Define 3D LUT struct for HDR planes > > > > > > Melissa Wen (16): > > > drm/drm_color_mgmt: add shaper LUT to color mgmt properties > > > drm/drm_color_mgmt: add 3D LUT props to DRM color mgmt > > > drm/drm_color_mgmt: add function to create 3D LUT modes supported > > > drm/drm_color_mgmt: add function to attach 3D LUT props > > > drm/drm_color_mgmt: set first lut3d mode as default > > > drm/amd/display: remove unused regamma condition > > > drm/amd/display: add comments to describe DM crtc color mgmt behavior > > > drm/amd/display: encapsulate atomic regamma operation > > > drm/amd/display: update lut3d and shaper lut to stream > > > drm/amd/display: handle MPC 3D LUT resources for a given context > > > drm/amd/display: acquire/release 3D LUT resources for ctx on DCN301 > > > drm/amd/display: expand array of supported 3D LUT modes > > > drm/amd/display: enable 3D-LUT DRM properties if supported > > > drm/amd/display: add user 3D LUT support to the amdgpu_dm color > > > pipeline > > > drm/amd/display: decouple steps to reuse in shaper LUT support > > > drm/amd/display: add user shaper LUT support to amdgpu_dm color > > > pipeline > > > > > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 + > > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 + > > > .../amd/display/amdgpu_dm/amdgpu_dm_color.c | 370 ++++++++++++++++-- > > > .../amd/display/amdgpu_dm/amdgpu_dm_crtc.c | 2 + > > > drivers/gpu/drm/amd/display/dc/core/dc.c | 49 ++- > > > drivers/gpu/drm/amd/display/dc/dc.h | 8 + > > > .../amd/display/dc/dcn301/dcn301_resource.c | 47 ++- > > > .../amd/display/modules/color/color_gamma.h | 43 ++ > > > drivers/gpu/drm/drm_atomic_state_helper.c | 7 + > > > drivers/gpu/drm/drm_atomic_uapi.c | 24 ++ > > > drivers/gpu/drm/drm_color_mgmt.c | 127 ++++++ > > > drivers/gpu/drm/drm_fb_helper.c | 5 + > > > drivers/gpu/drm/drm_mode_config.c | 21 + > > > include/drm/drm_color_mgmt.h | 8 + > > > include/drm/drm_crtc.h | 32 +- > > > include/drm/drm_mode_config.h | 25 ++ > > > include/drm/drm_mode_object.h | 2 +- > > > include/uapi/drm/drm_mode.h | 17 + > > > 18 files changed, 757 insertions(+), 39 deletions(-) > > > > > > -- > > > 2.35.1 > > > > --3apr2dpqo7izt23g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEtcQ9SICaIIqPWDjAcjQGjxahVjwFAmSKxscACgkQcjQGjxah VjzSlxAAllnfZnIYDF6MKvj99AQNFUV1mFvbBvOgTD6LMnvqsKjnQitsiKsjFLxa /pop4FiZ9chjQOND5uSl4fKuLooZ7rhntQGr0qzKOXhs9y0VSC6Gw9h9nHaehc+/ KqfJ97meuZp4UVODtcT/dkj1n9SLltqCK3CTsYjsHL825jxuduAA1OjwY4mF3UpH AG+7ESSh/3Auykg2Kr5xEXRzYqZI7MydtkB5Yoqv1HKBW9KGQgOhWKqhLmSLU6Gn G5OnoHynmqAv9x777p/nu/blt2xTeCnvSpqz2wtQ2sH8KHgcctpA6OJJLPVUq8wW CKLsKOA6Dr01rhzaj64O7K5dPzkN3GMz8bDsMVZ8NMIhCEts3WduOSElszB1tCbu bXHUZSWDcQFyRKVpDQI8+F/QyjzclbKH3Ybr5VS0hAw17PGdTORPyf7hrfREmVXk DmcV3yvBPkZeVZGLsllp000O3MWSM/uAL2c8vGP2Dhu9eelrnpnduq9h2B0apoXS gP/GyHNDS+MpOSvAs6CS0ENjj2L7wBVuC2+dtuiNraHy6uYtWNM+2SjxKh5aRINs wb3mnN4wzhn81dowXV83LhHdWuGufqTurIIP6NuVPzMhrIvU2shLml2I+gFgpHYC SKqWEHAOjaDnNzYGPy3zDrFB0l6rHvvxlea+hudwuZ//uTNPPDY= =XmNk -----END PGP SIGNATURE----- --3apr2dpqo7izt23g--