From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4076DC433EF for ; Tue, 21 Dec 2021 10:39:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3F4ED10FC1C; Tue, 21 Dec 2021 10:39:41 +0000 (UTC) Received: from mail-4323.proton.ch (mail-4323.proton.ch [185.70.43.23]) by gabe.freedesktop.org (Postfix) with ESMTPS id 540F210FC19 for ; Tue, 21 Dec 2021 10:39:39 +0000 (UTC) Date: Tue, 21 Dec 2021 10:39:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail; t=1640083177; bh=hPRELDBRRxQ+cyI0/AOFM+F6eiRHj96W1420vRye73Y=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc; b=uFr8Orra0Ypm//GJVgoue4hVc9jVAaOnvqnnPkJ55rVCVgBHmCUuBctPubEruiJql 0FWTcs9TVmwfVHOWvcBDgQv/QuZcixe7jcVnvLUdkrmRNzkNrj9jStSD6+ULP8Wcty 5OxqcGqufMOSKvWXiLsjasCiMziIWQv8co+CVqz2NZxHK8qY1DRn44z06y4wKjV4HX ooQgMAPzEyVdXeQ1VLNiy7aEvvwZunZEyTQdm8I94jvf/UscKWsfcE5knqz/1kDIZL +dWqCJs00R3RExBDMkQP72U7aSjkbLf3GDIqkr4TJ6c7uCEILLWi/O7o8Ka0/o10Zm +KDnlxAXVsQKQ== To: =?utf-8?Q?Jos=C3=A9_Exp=C3=B3sito?= From: Simon Ser Subject: Re: [PATCH v2 2/2] drm/vkms: set plane modifiers Message-ID: In-Reply-To: <20211216170140.15803-2-jose.exposito89@gmail.com> References: <20211216170140.15803-1-jose.exposito89@gmail.com> <20211216170140.15803-2-jose.exposito89@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Simon Ser Cc: hamohammed.sa@gmail.com, rodrigosiqueiramelo@gmail.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, melissa.srw@gmail.com, cphealy@gmail.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Overall looks good, but it is a bit repetitive to copy & paste this in all drivers. It'd be nice to provide a core helper to do this, and then drivers can just set format_mod_supported to the helper if they don't have more involved logic. Thoughts? See drm_plane_check_pixel_format, where the logic is already implemented. Alternatively=E2=80=A6 We can just support a missing format_mod_supported i= n create_in_format_blob. This sounds like this was the original intention of db1689aa61bd ("drm: Create a format/modifier blob") and drm_plane_check_pixel_format.