* [PATCH 1/6] staging: bcm2835-audio: Remove set but not used variable 'status'
2019-10-08 5:38 [PATCH 0/6] staging: Remove a bounch set of set but not used variables zhengbin
@ 2019-10-08 5:38 ` zhengbin
2019-10-08 6:04 ` Dan Carpenter
2019-10-08 5:38 ` [PATCH 2/6] staging: sm750fb: Remove set but not used variable 'uiActualPixelClk' zhengbin
` (4 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: zhengbin @ 2019-10-08 5:38 UTC (permalink / raw)
To: gregkh, eric, wahrenst, abbotti, hsweeten, devel; +Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c: In function audio_vchi_callback:
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c:99:6: warning: variable status set but not used [-Wunused-but-set-variable]
It is not used since commit 23b028c871e1 ("staging:
bcm2835-audio: initial staging submission")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
index c6f9cf1..8a94c5b 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
@@ -96,13 +96,12 @@ static void audio_vchi_callback(void *param,
struct bcm2835_audio_instance *instance = param;
struct vc_audio_msg m;
int msg_len;
- int status;
if (reason != VCHI_CALLBACK_MSG_AVAILABLE)
return;
- status = vchi_msg_dequeue(instance->vchi_handle,
- &m, sizeof(m), &msg_len, VCHI_FLAGS_NONE);
+ vchi_msg_dequeue(instance->vchi_handle,
+ &m, sizeof(m), &msg_len, VCHI_FLAGS_NONE);
if (m.type == VC_AUDIO_MSG_TYPE_RESULT) {
instance->result = m.result.success;
complete(&instance->msg_avail_comp);
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/6] staging: bcm2835-audio: Remove set but not used variable 'status'
2019-10-08 5:38 ` [PATCH 1/6] staging: bcm2835-audio: Remove set but not used variable 'status' zhengbin
@ 2019-10-08 6:04 ` Dan Carpenter
0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2019-10-08 6:04 UTC (permalink / raw)
To: zhengbin; +Cc: devel, eric, gregkh, abbotti, wahrenst
On Tue, Oct 08, 2019 at 01:38:57PM +0800, zhengbin wrote:
> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
> index c6f9cf1..8a94c5b 100644
> --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
> +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
> @@ -96,13 +96,12 @@ static void audio_vchi_callback(void *param,
> struct bcm2835_audio_instance *instance = param;
> struct vc_audio_msg m;
> int msg_len;
> - int status;
>
> if (reason != VCHI_CALLBACK_MSG_AVAILABLE)
> return;
>
> - status = vchi_msg_dequeue(instance->vchi_handle,
> - &m, sizeof(m), &msg_len, VCHI_FLAGS_NONE);
> + vchi_msg_dequeue(instance->vchi_handle,
> + &m, sizeof(m), &msg_len, VCHI_FLAGS_NONE);
This looks like a bug in the code. flags is VCHI_FLAGS_NONE so it can
return -1 and we should check for that.
> if (m.type == VC_AUDIO_MSG_TYPE_RESULT) {
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/6] staging: sm750fb: Remove set but not used variable 'uiActualPixelClk'
2019-10-08 5:38 [PATCH 0/6] staging: Remove a bounch set of set but not used variables zhengbin
2019-10-08 5:38 ` [PATCH 1/6] staging: bcm2835-audio: Remove set but not used variable 'status' zhengbin
@ 2019-10-08 5:38 ` zhengbin
2019-10-08 6:06 ` Dan Carpenter
2019-10-08 5:38 ` [PATCH 3/6] staging: sm750fb: Remove set but not used variable 'actual_mx_clk' zhengbin
` (3 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: zhengbin @ 2019-10-08 5:38 UTC (permalink / raw)
To: gregkh, eric, wahrenst, abbotti, hsweeten, devel; +Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/sm750fb/ddk750_mode.c: In function ddk750_setModeTiming:
drivers/staging/sm750fb/ddk750_mode.c:212:15: warning: variable uiActualPixelClk set but not used [-Wunused-but-set-variable]
It is not used since commit 81dee67e215b ("staging:
sm750fb: add sm750 to staging")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/staging/sm750fb/ddk750_mode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
index 9722692..e0230f4 100644
--- a/drivers/staging/sm750fb/ddk750_mode.c
+++ b/drivers/staging/sm750fb/ddk750_mode.c
@@ -209,12 +209,11 @@ static int programModeRegisters(struct mode_parameter *pModeParam,
int ddk750_setModeTiming(struct mode_parameter *parm, enum clock_type clock)
{
struct pll_value pll;
- unsigned int uiActualPixelClk;
pll.input_freq = DEFAULT_INPUT_CLOCK;
pll.clock_type = clock;
- uiActualPixelClk = sm750_calc_pll_value(parm->pixel_clock, &pll);
+ sm750_calc_pll_value(parm->pixel_clock, &pll);
if (sm750_get_chip_type() == SM750LE) {
/* set graphic mode via IO method */
outb_p(0x88, 0x3d4);
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 2/6] staging: sm750fb: Remove set but not used variable 'uiActualPixelClk'
2019-10-08 5:38 ` [PATCH 2/6] staging: sm750fb: Remove set but not used variable 'uiActualPixelClk' zhengbin
@ 2019-10-08 6:06 ` Dan Carpenter
2019-10-08 6:08 ` Dan Carpenter
0 siblings, 1 reply; 10+ messages in thread
From: Dan Carpenter @ 2019-10-08 6:06 UTC (permalink / raw)
To: zhengbin; +Cc: devel, eric, gregkh, abbotti, wahrenst
On Tue, Oct 08, 2019 at 01:38:58PM +0800, zhengbin wrote:
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> index 9722692..e0230f4 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -209,12 +209,11 @@ static int programModeRegisters(struct mode_parameter *pModeParam,
> int ddk750_setModeTiming(struct mode_parameter *parm, enum clock_type clock)
> {
> struct pll_value pll;
> - unsigned int uiActualPixelClk;
>
> pll.input_freq = DEFAULT_INPUT_CLOCK;
> pll.clock_type = clock;
>
> - uiActualPixelClk = sm750_calc_pll_value(parm->pixel_clock, &pll);
> + sm750_calc_pll_value(parm->pixel_clock, &pll);
Get rid of this function as well.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/6] staging: sm750fb: Remove set but not used variable 'uiActualPixelClk'
2019-10-08 6:06 ` Dan Carpenter
@ 2019-10-08 6:08 ` Dan Carpenter
0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2019-10-08 6:08 UTC (permalink / raw)
To: zhengbin; +Cc: devel, eric, gregkh, abbotti, wahrenst
On Tue, Oct 08, 2019 at 09:06:11AM +0300, Dan Carpenter wrote:
> On Tue, Oct 08, 2019 at 01:38:58PM +0800, zhengbin wrote:
> > diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> > index 9722692..e0230f4 100644
> > --- a/drivers/staging/sm750fb/ddk750_mode.c
> > +++ b/drivers/staging/sm750fb/ddk750_mode.c
> > @@ -209,12 +209,11 @@ static int programModeRegisters(struct mode_parameter *pModeParam,
> > int ddk750_setModeTiming(struct mode_parameter *parm, enum clock_type clock)
> > {
> > struct pll_value pll;
> > - unsigned int uiActualPixelClk;
> >
> > pll.input_freq = DEFAULT_INPUT_CLOCK;
> > pll.clock_type = clock;
> >
> > - uiActualPixelClk = sm750_calc_pll_value(parm->pixel_clock, &pll);
> > + sm750_calc_pll_value(parm->pixel_clock, &pll);
>
> Get rid of this function as well.
Oops. I'm wrong. Sorry for the noise. Leave the function.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/6] staging: sm750fb: Remove set but not used variable 'actual_mx_clk'
2019-10-08 5:38 [PATCH 0/6] staging: Remove a bounch set of set but not used variables zhengbin
2019-10-08 5:38 ` [PATCH 1/6] staging: bcm2835-audio: Remove set but not used variable 'status' zhengbin
2019-10-08 5:38 ` [PATCH 2/6] staging: sm750fb: Remove set but not used variable 'uiActualPixelClk' zhengbin
@ 2019-10-08 5:38 ` zhengbin
2019-10-08 5:39 ` [PATCH 4/6] staging: comedi: Remove set but not used variable 'data' zhengbin
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: zhengbin @ 2019-10-08 5:38 UTC (permalink / raw)
To: gregkh, eric, wahrenst, abbotti, hsweeten, devel; +Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/sm750fb/ddk750_chip.c: In function set_chip_clock:
drivers/staging/sm750fb/ddk750_chip.c:59:15: warning: variable actual_mx_clk set but not used [-Wunused-but-set-variable]
It is not used since commit f0977109a577 ("staging:
sm750fb: lower case to fix camelcase checkpatch warning")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/staging/sm750fb/ddk750_chip.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index e5988813..02860d3 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -56,7 +56,6 @@ static unsigned int get_mxclk_freq(void)
static void set_chip_clock(unsigned int frequency)
{
struct pll_value pll;
- unsigned int actual_mx_clk;
/* Cheok_0509: For SM750LE, the chip clock is fixed. Nothing to set. */
if (sm750_get_chip_type() == SM750LE)
@@ -76,7 +75,7 @@ static void set_chip_clock(unsigned int frequency)
* Return value of sm750_calc_pll_value gives the actual
* possible clock.
*/
- actual_mx_clk = sm750_calc_pll_value(frequency, &pll);
+ sm750_calc_pll_value(frequency, &pll);
/* Master Clock Control: MXCLK_PLL */
poke32(MXCLK_PLL_CTRL, sm750_format_pll_reg(&pll));
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/6] staging: comedi: Remove set but not used variable 'data'
2019-10-08 5:38 [PATCH 0/6] staging: Remove a bounch set of set but not used variables zhengbin
` (2 preceding siblings ...)
2019-10-08 5:38 ` [PATCH 3/6] staging: sm750fb: Remove set but not used variable 'actual_mx_clk' zhengbin
@ 2019-10-08 5:39 ` zhengbin
2019-10-08 5:39 ` [PATCH 5/6] staging: comedi: Remove set but not used variable 'hi' zhengbin
2019-10-08 5:39 ` [PATCH 6/6] staging: comedi: Remove set but not used variable 'aref' zhengbin
5 siblings, 0 replies; 10+ messages in thread
From: zhengbin @ 2019-10-08 5:39 UTC (permalink / raw)
To: gregkh, eric, wahrenst, abbotti, hsweeten, devel; +Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/comedi/drivers/dt2814.c: In function dt2814_interrupt:
drivers/staging/comedi/drivers/dt2814.c:193:6: warning: variable data set but not used [-Wunused-but-set-variable]
It is not used since commit 7806012e97ed ("staging:
comedi: refactor dt2814 driver and use module_comedi_driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/staging/comedi/drivers/dt2814.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt2814.c b/drivers/staging/comedi/drivers/dt2814.c
index d2c7157..4825168 100644
--- a/drivers/staging/comedi/drivers/dt2814.c
+++ b/drivers/staging/comedi/drivers/dt2814.c
@@ -190,7 +190,6 @@ static irqreturn_t dt2814_interrupt(int irq, void *d)
struct comedi_device *dev = d;
struct dt2814_private *devpriv = dev->private;
struct comedi_subdevice *s = dev->read_subdev;
- int data;
if (!dev->attached) {
dev_err(dev->class_dev, "spurious interrupt\n");
@@ -200,8 +199,6 @@ static irqreturn_t dt2814_interrupt(int irq, void *d)
hi = inb(dev->iobase + DT2814_DATA);
lo = inb(dev->iobase + DT2814_DATA);
- data = (hi << 4) | (lo >> 4);
-
if (!(--devpriv->ntrig)) {
int i;
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 5/6] staging: comedi: Remove set but not used variable 'hi'
2019-10-08 5:38 [PATCH 0/6] staging: Remove a bounch set of set but not used variables zhengbin
` (3 preceding siblings ...)
2019-10-08 5:39 ` [PATCH 4/6] staging: comedi: Remove set but not used variable 'data' zhengbin
@ 2019-10-08 5:39 ` zhengbin
2019-10-08 5:39 ` [PATCH 6/6] staging: comedi: Remove set but not used variable 'aref' zhengbin
5 siblings, 0 replies; 10+ messages in thread
From: zhengbin @ 2019-10-08 5:39 UTC (permalink / raw)
To: gregkh, eric, wahrenst, abbotti, hsweeten, devel; +Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/comedi/drivers/dt2815.c: In function dt2815_ao_insn:
drivers/staging/comedi/drivers/dt2815.c:91:19: warning: variable hi set but not used [-Wunused-but-set-variable]
It is not used since commit d6a929b7608a ("Staging:
comedi: add dt2815 driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/staging/comedi/drivers/dt2815.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt2815.c b/drivers/staging/comedi/drivers/dt2815.c
index 83026ba..bcf85ec 100644
--- a/drivers/staging/comedi/drivers/dt2815.c
+++ b/drivers/staging/comedi/drivers/dt2815.c
@@ -88,12 +88,11 @@ static int dt2815_ao_insn(struct comedi_device *dev, struct comedi_subdevice *s,
struct dt2815_private *devpriv = dev->private;
int i;
int chan = CR_CHAN(insn->chanspec);
- unsigned int lo, hi;
+ unsigned int lo;
int ret;
for (i = 0; i < insn->n; i++) {
lo = ((data[i] & 0x0f) << 4) | (chan << 1) | 0x01;
- hi = (data[i] & 0xff0) >> 4;
ret = comedi_timeout(dev, s, insn, dt2815_ao_status, 0x00);
if (ret)
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 6/6] staging: comedi: Remove set but not used variable 'aref'
2019-10-08 5:38 [PATCH 0/6] staging: Remove a bounch set of set but not used variables zhengbin
` (4 preceding siblings ...)
2019-10-08 5:39 ` [PATCH 5/6] staging: comedi: Remove set but not used variable 'hi' zhengbin
@ 2019-10-08 5:39 ` zhengbin
5 siblings, 0 replies; 10+ messages in thread
From: zhengbin @ 2019-10-08 5:39 UTC (permalink / raw)
To: gregkh, eric, wahrenst, abbotti, hsweeten, devel; +Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/comedi/drivers/dt3000.c: In function dt3k_ai_insn_read:
drivers/staging/comedi/drivers/dt3000.c:511:27: warning: variable aref set but not used [-Wunused-but-set-variable]
It is not used since commit 2e310235ca8f ("staging:
comedi: dt3000: rename dt3k_ai_insn()")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/staging/comedi/drivers/dt3000.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt3000.c b/drivers/staging/comedi/drivers/dt3000.c
index caf4d4d..f7c365b 100644
--- a/drivers/staging/comedi/drivers/dt3000.c
+++ b/drivers/staging/comedi/drivers/dt3000.c
@@ -508,12 +508,11 @@ static int dt3k_ai_insn_read(struct comedi_device *dev,
unsigned int *data)
{
int i;
- unsigned int chan, gain, aref;
+ unsigned int chan, gain;
chan = CR_CHAN(insn->chanspec);
gain = CR_RANGE(insn->chanspec);
/* XXX docs don't explain how to select aref */
- aref = CR_AREF(insn->chanspec);
for (i = 0; i < insn->n; i++)
data[i] = dt3k_readsingle(dev, DPR_SUBSYS_AI, chan, gain);
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread