From mboxrd@z Thu Jan  1 00:00:00 1970
From: yakui.zhao@intel.com (Zhao, Yakui)
Date: Tue, 20 Aug 2019 10:25:51 +0800
Subject: [RFC PATCH 08/15] drivers/acrn: add VM memory management for ACRN
 char device
In-Reply-To: <20190819073958.GC4451@kadam>
References: <1565922356-4488-1-git-send-email-yakui.zhao@intel.com>
 <1565922356-4488-9-git-send-email-yakui.zhao@intel.com>
 <20190816124757.GW1974@kadam>
 <8b909c22-3873-2b5d-4845-1fee1a5d81ce@intel.com>
 <20190819073958.GC4451@kadam>
Message-ID: <1896e9f8-7947-3c7a-4328-ddbdeee892e3@intel.com>
List-Id: Linux Driver Project Developer List
 <driverdev-devel.linuxdriverproject.org>



On 2019?08?19? 15:39, Dan Carpenter wrote:
> On Mon, Aug 19, 2019@01:32:54PM +0800, Zhao, Yakui wrote:
>> In fact as this driver is mainly used for embedded IOT usage, it doesn't
>> handle the complex cleanup when such error is encountered. Instead the clean
>> up is handled in free_guest_vm.
> 
> A use after free here seems like a potential security problem.  Security
> matters for IoT...  :(

Thanks for pointing out the issue.
The cleanup will be considered carefully.

> 
> regards,
> dan carpenter
>