DriverDev-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	Dan Carpenter <dan.carpenter@oracle.com>,
	p.zabel@pengutronix.de, linux-tegra@vger.kernel.org,
	ac100@lists.launchpad.net
Subject: Re: [PATCH v4] staging: nvec: change usage of slave to secondary
Date: Sat, 25 Jul 2020 18:32:42 +0530
Message-ID: <1a717bdc-a321-04a8-0a0e-3cff887ff380@gmail.com> (raw)
In-Reply-To: <20200725125054.GB18633@qmqm.qmqm.pl>

On 25/07/20 6:20 pm, Michał Mirosław wrote:
> On Sat, Jul 25, 2020 at 06:01:19PM +0530, Rohit K Bharadwaj wrote:
>> On 25/07/20 5:31 pm, Michał Mirosław wrote:
>>> On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote:
>>>> changed usage of slave (which is deprecated) to secondary without breaking the driver
>>>
>>> The relevant I2C and SMBus standards use master/slave terminology. Why are
>>> you changing the names to something unfamiliar?
>>>
>>> If the reason are the recent coding-style changes, then please note they
>>> are about avoiding introducing *NEW* uses of the specific words and not
>>> about blindly replacing existing occurrences.
>>
>> I'm really sorry sir, I didn't knew about this, yes the reason for my change is according to the script checkpatch.pl to suit the coding style, I would try to fix some other coding style related issues if this patch seems to be a bad idea.
> 
> I didn't know checkpatch does this (it doesn't in current Linus' master
> tree).  I can see there is a commit in next adding this, but seems that
> it uses a test far from the original coding-style wording...
> 
> Best Regards
> Michał Mirosław
> 
yes sir, in the linux-next tree, when I ran the script on this file it showed me it had style issues and the usage of slave is deprecated and it suggested me to replace it with secondary or target. and hence I made this patch, please do let me know if this patch can be acceptable or not.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply index

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23 15:15 [PATCH] change slave occurence to secondary everywhere Rohit K Bharadwaj
2020-07-23 17:06 ` Greg KH
2020-07-24  4:55   ` Rohit Bharadwaj
2020-07-24  4:36 ` [PATCH v3] staging: nvec: change usage of slave to secondary Rohit K Bharadwaj
2020-07-24  8:14   ` Rohit Bharadwaj
2020-07-24  8:28     ` Greg KH
2020-07-24  8:35       ` Rohit Bharadwaj
2020-07-24 16:33         ` Marc Dietrich
2020-07-24 16:36           ` Marc Dietrich
2020-07-24 16:57             ` Rohit K Bharadwaj
2020-07-24 20:42               ` Marc Dietrich
2020-07-25  6:50                 ` Rohit K Bharadwaj
2020-07-24 14:09   ` Dan Carpenter
2020-07-24 15:51     ` Rohit K Bharadwaj
2020-07-24 16:23       ` Greg KH
2020-07-25  6:29   ` [PATCH v4] " Rohit K Bharadwaj
2020-07-25 12:01     ` Michał Mirosław
2020-07-25 12:31       ` Rohit K Bharadwaj
2020-07-25 12:50         ` Michał Mirosław
2020-07-25 13:02           ` Rohit K Bharadwaj [this message]
2020-08-02  8:07           ` Marc Dietrich
2020-08-02  8:13     ` Marc Dietrich
2020-08-02  9:09       ` Rohit K Bharadwaj
2020-07-24 14:07 ` [PATCH] change slave occurence to secondary everywhere Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a717bdc-a321-04a8-0a0e-3cff887ff380@gmail.com \
    --to=bharadwaj.rohit8@gmail.com \
    --cc=ac100@lists.launchpad.net \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DriverDev-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/driverdev-devel/0 driverdev-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 driverdev-devel driverdev-devel/ https://lore.kernel.org/driverdev-devel \
		driverdev-devel@linuxdriverproject.org devel@driverdev.osuosl.org
	public-inbox-index driverdev-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxdriverproject.driverdev-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git