From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
Subject: [PATCH v3 2/2] binder: Validate the default binderfs device names.
Date: Fri, 9 Aug 2019 16:51:23 +0200 [thread overview]
Message-ID: <20190809145123.GC16262@kroah.com> (raw)
In-Reply-To: <20190808222727.132744-3-hridya@google.com>
On Thu, Aug 08, 2019@03:27:26PM -0700, Hridya Valsaraju wrote:
> Length of a binderfs device name cannot exceed BINDERFS_MAX_NAME.
> This patch adds a check in binderfs_init() to ensure the same
> for the default binder devices that will be created in every
> binderfs instance.
>
> Co-developed-by: Christian Brauner <christian.brauner at ubuntu.com>
> Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
> Signed-off-by: Hridya Valsaraju <hridya at google.com>
> ---
> drivers/android/binderfs.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
> index aee46dd1be91..55c5adb87585 100644
> --- a/drivers/android/binderfs.c
> +++ b/drivers/android/binderfs.c
> @@ -570,6 +570,18 @@ static struct file_system_type binder_fs_type = {
> int __init init_binderfs(void)
> {
> int ret;
> + const char *name;
> + size_t len;
> +
> + /* Verify that the default binderfs device names are valid. */
> + name = binder_devices_param;
> + for (len = strcspn(name, ","); len > 0; len = strcspn(name, ",")) {
> + if (len > BINDERFS_MAX_NAME)
> + return -E2BIG;
> + name += len;
> + if (*name == ',')
> + name++;
> + }
Shouldn't this be a bugfix separate from patch 1/2?
And shouldn't it be backported to older kernels that currently have this
issue?
thanks,
greg k-h
next prev parent reply other threads:[~2019-08-09 14:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 22:27 [PATCH v3 0/2] Add default binderfs devices Hridya Valsaraju
2019-08-08 22:27 ` [PATCH v3 1/2] binder: Add default binder devices through binderfs when configured Hridya Valsaraju
2019-08-09 14:50 ` Greg Kroah-Hartman
2019-08-09 18:22 ` Christian Brauner
2019-08-09 20:08 ` Hridya Valsaraju
2019-08-15 16:28 ` Joel Fernandes
2019-08-15 16:30 ` Joel Fernandes
2019-08-08 22:27 ` [PATCH v3 2/2] binder: Validate the default binderfs device names Hridya Valsaraju
2019-08-09 14:51 ` Greg Kroah-Hartman [this message]
2019-08-09 14:55 ` Greg Kroah-Hartman
2019-08-09 18:14 ` Christian Brauner
2019-08-09 18:41 ` Hridya Valsaraju
2019-09-04 7:19 ` Greg Kroah-Hartman
2019-09-04 10:44 ` Christian Brauner
2019-09-04 10:49 ` Greg Kroah-Hartman
2019-09-04 11:07 ` Christian Brauner
2019-08-15 16:31 ` Joel Fernandes
2019-08-15 16:00 ` [PATCH v3 0/2] Add default binderfs devices Greg Kroah-Hartman
2019-09-04 11:07 ` [RESEND PATCH " Christian Brauner
2019-09-04 11:07 ` [RESEND PATCH v3 1/2] binder: Add default binder devices through binderfs when configured Christian Brauner
2019-09-04 11:07 ` [RESEND PATCH v3 2/2] binder: Validate the default binderfs device names Christian Brauner
2019-09-04 11:18 ` [RESEND PATCH v3 0/2] Add default binderfs devices Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809145123.GC16262@kroah.com \
--to=gregkh@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).