From mboxrd@z Thu Jan  1 00:00:00 1970
From: bp@alien8.de (Borislav Petkov)
Date: Mon, 19 Aug 2019 09:46:14 +0200
Subject: [RFC PATCH 08/15] drivers/acrn: add VM memory management for
 ACRN char device
In-Reply-To: <20190819073958.GC4451@kadam>
References: <1565922356-4488-1-git-send-email-yakui.zhao@intel.com>
 <1565922356-4488-9-git-send-email-yakui.zhao@intel.com>
 <20190816124757.GW1974@kadam>
 <8b909c22-3873-2b5d-4845-1fee1a5d81ce@intel.com>
 <20190819073958.GC4451@kadam>
Message-ID: <20190819074614.GD4841@zn.tnic>
List-Id: Linux Driver Project Developer List
 <driverdev-devel.linuxdriverproject.org>

On Mon, Aug 19, 2019@10:39:58AM +0300, Dan Carpenter wrote:
> On Mon, Aug 19, 2019@01:32:54PM +0800, Zhao, Yakui wrote:
> > In fact as this driver is mainly used for embedded IOT usage, it doesn't
> > handle the complex cleanup when such error is encountered. Instead the clean
> > up is handled in free_guest_vm.
> 
> A use after free here seems like a potential security problem.  Security
> matters for IoT...  :(

Yeah, the "S" in "IoT" stands for security.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.