DriverDev-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Gao Xiang <gaoxiang25@huawei.com>
Cc: Jan Kara <jack@suse.cz>, Chao Yu <yuchao0@huawei.com>,
	Dave Chinner <david@fromorbit.com>,
	David Sterba <dsterba@suse.cz>, Miao Xie <miaoxie@huawei.com>,
	devel@driverdev.osuosl.org,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	"Darrick J . Wong" <darrick.wong@oracle.com>,
	Richard Weinberger <richard@nod.at>,
	Christoph Hellwig <hch@infradead.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Amir Goldstein <amir73il@gmail.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Jaegeuk Kim <jaegeuk@kernel.org>, Theodore Ts'o <tytso@mit.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Li Guifu <bluce.liguifu@huawei.com>,
	Fang Wei <fangwei1@huawei.com>, Pavel Machek <pavel@denx.de>,
	linux-fsdevel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH v8 20/24] erofs: introduce generic decompression backend
Date: Fri, 30 Aug 2019 09:55:33 -0700
Message-ID: <20190830165533.GA10909@infradead.org> (raw)
In-Reply-To: <20190830165217.GB107220@architecture4>

On Sat, Aug 31, 2019 at 12:52:17AM +0800, Gao Xiang wrote:
> Hi Christoph,
> 
> On Fri, Aug 30, 2019 at 09:35:34AM -0700, Christoph Hellwig wrote:
> > On Thu, Aug 15, 2019 at 12:41:51PM +0800, Gao Xiang wrote:
> > > +static bool use_vmap;
> > > +module_param(use_vmap, bool, 0444);
> > > +MODULE_PARM_DESC(use_vmap, "Use vmap() instead of vm_map_ram() (default 0)");
> > 
> > And how would anyone know which to pick?
> 
> It has significant FIO benchmark difference on sequential read least on arm64...
> I have no idea whether all platform vm_map_ram() behaves better than vmap(),
> so I leave an option for users here...

vm_map_ram is supposed to generally behave better.  So if it doesn't
please report that that to the arch maintainer and linux-mm so that
they can look into the issue.  Having user make choices of deep down
kernel internals is just a horrible interface.

Please talk to maintainers of other bits of the kernel if you see issues
and / or need enhancements.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply index

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15  4:41 [PATCH v8 00/24] erofs: promote erofs from staging v8 gaoxiang25
2019-08-15  4:41 ` [PATCH v8 01/24] erofs: add on-disk layout gaoxiang25
2019-08-15  4:41 ` [PATCH v8 02/24] erofs: add erofs in-memory stuffs gaoxiang25
2019-08-15  4:41 ` [PATCH v8 03/24] erofs: add super block operations gaoxiang25
2019-08-15  4:41 ` [PATCH v8 04/24] erofs: add raw address_space operations gaoxiang25
2019-08-15  4:41 ` [PATCH v8 05/24] erofs: add inode operations gaoxiang25
2019-08-15  4:41 ` [PATCH v8 06/24] erofs: support special inode gaoxiang25
2019-08-15  4:41 ` [PATCH v8 07/24] erofs: add directory operations gaoxiang25
2019-08-15 16:13   ` torvalds
2019-08-15 16:46     ` hsiangkao
2019-08-15  4:41 ` [PATCH v8 08/24] erofs: add namei functions gaoxiang25
2019-08-15  4:41 ` [PATCH v8 09/24] erofs: support tracepoint gaoxiang25
2019-08-15  4:41 ` [PATCH v8 10/24] erofs: update Kconfig and Makefile gaoxiang25
2019-08-15  4:41 ` [PATCH v8 11/24] erofs: introduce xattr & posixacl support gaoxiang25
2019-09-02 12:57   ` Christoph Hellwig
2019-09-02 13:05     ` Gao Xiang
2019-09-02 13:06     ` David Sterba
2019-09-02 13:51       ` Chao Yu
2019-09-02 14:20         ` David Sterba
2019-09-02 15:06           ` Christoph Hellwig
2019-09-02 15:10             ` Gao Xiang
2019-09-02 15:21             ` Gao Xiang
2019-09-03  6:30           ` Chao Yu
2019-08-15  4:41 ` [PATCH v8 12/24] erofs: introduce tagged pointer gaoxiang25
2019-08-15  4:41 ` [PATCH v8 13/24] erofs: add compression indexes support gaoxiang25
2019-08-15  4:41 ` [PATCH v8 14/24] erofs: introduce superblock registration gaoxiang25
2019-08-15  4:41 ` [PATCH v8 15/24] erofs: introduce erofs shrinker gaoxiang25
2019-08-15  4:41 ` [PATCH v8 16/24] erofs: introduce workstation for decompression gaoxiang25
2019-08-15  4:41 ` [PATCH v8 17/24] erofs: introduce per-CPU buffers implementation gaoxiang25
2019-08-15  4:41 ` [PATCH v8 18/24] erofs: introduce pagevec for decompression subsystem gaoxiang25
2019-08-15  4:41 ` [PATCH v8 19/24] erofs: add erofs_allocpage() gaoxiang25
2019-08-15  4:41 ` [PATCH v8 20/24] erofs: introduce generic decompression backend gaoxiang25
2019-08-30 16:35   ` Christoph Hellwig
2019-08-30 16:52     ` Gao Xiang
2019-08-30 16:55       ` Christoph Hellwig [this message]
2019-08-15  4:41 ` [PATCH v8 21/24] erofs: introduce LZ4 decompression inplace gaoxiang25
2019-08-15  4:41 ` [PATCH v8 22/24] erofs: introduce the decompression frontend gaoxiang25
2019-08-15  4:41 ` [PATCH v8 23/24] erofs: introduce cached decompression gaoxiang25
2019-08-15  4:41 ` [PATCH v8 24/24] erofs: add document gaoxiang25
2019-08-15  9:06 ` [PATCH v8 00/24] erofs: promote erofs from staging v8 gregkh
2019-08-15 16:18   ` torvalds
2019-08-15 17:04     ` hsiangkao

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190830165533.GA10909@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=amir73il@gmail.com \
    --cc=bluce.liguifu@huawei.com \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dsterba@suse.cz \
    --cc=fangwei1@huawei.com \
    --cc=gaoxiang25@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jack@suse.cz \
    --cc=jaegeuk@kernel.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miaoxie@huawei.com \
    --cc=pavel@denx.de \
    --cc=richard@nod.at \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DriverDev-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/driverdev-devel/0 driverdev-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 driverdev-devel driverdev-devel/ https://lore.kernel.org/driverdev-devel \
		driverdev-devel@linuxdriverproject.org devel@driverdev.osuosl.org
	public-inbox-index driverdev-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxdriverproject.driverdev-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git