From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C588C3A59E for ; Mon, 2 Sep 2019 15:54:31 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D448217D7 for ; Mon, 2 Sep 2019 15:54:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EbRvuexg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D448217D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 0B34D860C4; Mon, 2 Sep 2019 15:54:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B71aSq-QlHJA; Mon, 2 Sep 2019 15:54:29 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 8287386081; Mon, 2 Sep 2019 15:54:29 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 0F9921BF32D for ; Mon, 2 Sep 2019 15:54:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 0996B85C98 for ; Mon, 2 Sep 2019 15:54:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b6EMC8L-wlPE for ; Mon, 2 Sep 2019 15:54:26 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id D3062857D0 for ; Mon, 2 Sep 2019 15:54:26 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3822D217D7; Mon, 2 Sep 2019 15:54:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567439666; bh=HMwyh/e6yuiazEWDmWTrxtN8R7FLKODjf5dUfshAxQc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EbRvuexgwBsiQlMqtf0kEICmFvBY8Pcf7VhHUI5k8CyEzoS0+Bc50hycoq273oGOB kN6W1UMx/Szw7MIj5e6zeVveRR5neZTYnsERXyEDf3eRsL1f7LKqE2XrgLQ0IUBAhG dFniv99KVFplEhrchKtJE3C6fJ4ISwdL5U2CdSmc= Date: Mon, 2 Sep 2019 17:54:24 +0200 From: Greg Kroah-Hartman To: Tyler Hicks Subject: Re: [PATCH AUTOSEL 4.19 11/29] binder: take read mode of mmap_sem in binder_alloc_free_page() Message-ID: <20190902155424.GA21884@kroah.com> References: <20190829105009.2265-1-sashal@kernel.org> <20190829105009.2265-11-sashal@kernel.org> <20190829151320.GC27650@elm> <20190830062910.GC15257@kroah.com> <20190830073019.GA16891@elm> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190830073019.GA16891@elm> User-Agent: Mutt/1.12.1 (2019-06-15) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , devel@driverdev.osuosl.org, Todd Kjos , linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Fri, Aug 30, 2019 at 02:30:19AM -0500, Tyler Hicks wrote: > On 2019-08-30 08:29:10, Greg Kroah-Hartman wrote: > > On Thu, Aug 29, 2019 at 10:13:20AM -0500, Tyler Hicks wrote: > > > Hello, Sasha! > > > > > > On 2019-08-29 06:49:51, Sasha Levin wrote: > > > > From: Tyler Hicks > > > > > > > > [ Upstream commit 60d4885710836595192c42d3e04b27551d30ec91 ] > > > > > > > > Restore the behavior of locking mmap_sem for reading in > > > > binder_alloc_free_page(), as was first done in commit 3013bf62b67a > > > > ("binder: reduce mmap_sem write-side lock"). That change was > > > > inadvertently reverted by commit 5cec2d2e5839 ("binder: fix race between > > > > munmap() and direct reclaim"). > > > > > > > > In addition, change the name of the label for the error path to > > > > accurately reflect that we're taking the lock for reading. > > > > > > > > Backporting note: This fix is only needed when *both* of the commits > > > > mentioned above are applied. That's an unlikely situation since they > > > > both landed during the development of v5.1 but only one of them is > > > > targeted for stable. > > > > > > This patch isn't meant to be applied to 4.19 since commit 3013bf62b67a > > > ("binder: reduce mmap_sem write-side lock") was never brought back to > > > 4.19. > > > > > > Tyler > > > > > > > > > > > Fixes: 5cec2d2e5839 ("binder: fix race between munmap() and direct reclaim") > > > > But this commit is in 4.19.49 > > That's correct but commit 3013bf62b67a isn't present in 4.19.y. See the > "Backporting note" above. Heh, I never read that part of the text, nevermind :) greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel