From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34368C3A5A2 for ; Tue, 3 Sep 2019 15:44:06 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A3152077B for ; Tue, 3 Sep 2019 15:44:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=aol.com header.i=@aol.com header.b="inOkNFLi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A3152077B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=aol.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 8F721882E0; Tue, 3 Sep 2019 15:44:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IYs-XngYg5Ga; Tue, 3 Sep 2019 15:44:02 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 6435B882D8; Tue, 3 Sep 2019 15:44:02 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 3749B1BF593 for ; Tue, 3 Sep 2019 15:44:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 33F4285751 for ; Tue, 3 Sep 2019 15:44:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O6F-Alj8FuM2 for ; Tue, 3 Sep 2019 15:44:00 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sonic305-20.consmr.mail.ir2.yahoo.com (sonic305-20.consmr.mail.ir2.yahoo.com [77.238.177.82]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 4DCAE8535F for ; Tue, 3 Sep 2019 15:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1567525438; bh=amQaLfsn9ULZ6xSgxRvXFlLkkzxAfo+EgjZ/LcStoG0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=inOkNFLiuUBkOB94EFjoigF6vTbXFopGu0YEYVbZPLwjtLIjKIOwqyy6Et6IT8Wyb2sXRW1K6QfGJJR9/wD3Zj0gWhp3ZEnwOdUEwxYmAkETelsEehMsYOhUuTbECcHx1hZyEt8lr2nXaSRNwM2z7VLbG9Si9nbkSCXVK5xNBHL9+kzVeKF0ZmbMvQdvoZhjQKIuEaXaTbFsbtYfzea/UG0MBL6MxEyXCrPkkUj+C8Hc17dO1jVsgExuvBMw6HgoDI846SdPv7eu6Dw8EcTp+ln/LOdTEIxcCrHU/8HQTWFvTIPgYo+Mfc4lNOQe9qUOeYoQfKT/WCckSSMRazciqw== X-YMail-OSG: 8UQ0XYsVM1mLlKEPHcOu0KYQBaMIBtw848cc12eLBxHlDVJ2w2IjOhhuj2pFk6U T3R9.I1jWABZYSe9mKMUnugbuXpSvY8437zunRdkfTBzIhx1fOWNhm_LkQYSOkDkfTWePhvirbiV oMI9XfH0k7A2ZkbVINbccynWxWhC3mHkmXZ8_6nFH1S_498eodVNo2kdToJUm8el0K3WgOHNflvB mR6IhZbxy0HRTIH3ovwGVSgOSE583Tbeua9CP6IMNiz3T8tsvLiirRysAN.5SevMddO1Ocm455ky XMysa6_mYS0fSJ2m7FHbl1JIwcwcTmDnbm7W0bkLEqMJrYEd0j0k6MYHbd13HvsOr.OQpi5h2adx KbW69xlR7sqUN6vg.KGxAcUJAhrxGlCpsHbROjfCNcx9Q67W4MnZn.ZAiCP3bxpiAA3j_jGhwCUy BVU9FP0LUX947erlPjb2SfSpDey_quPTQpgznc6g5lipcwZhL7oJq6ERpyXGmksGV2L8.1efHjN8 1H6R8BTMIVHTMVHUwKrEv8kycX.h4MiSi2JY4vGBcKUxs0tQ1ppOMT9hqV.Nrhoxb.FcuSoXF9mC 68JqSlOWs.1hO5XkwQHEhZ1At7XOh3JpJyYLgSqQID.au34gN.LfMLqCmfvzw2QD.tbMm1lKmDc7 he_4PEXePeC6luG5qmlbvOM5zZyY6haevTqgDM33eb1EjHzKIcrfbipiU03VgT5htJRWt6ymtxVm Q_le.S4qHRSIO8XREEb_kA2.HPJ2FAqN8ZKUW6Lo21qGy.zsSNTtCIGodk0mr4oMcmk5PG9CuvYR j5S.yT4CzdXFsg1Hi6fuHX0Tc8qJxuf68vJmsHgedqF3TNQVQMYee9wfzWHB7VElQKoHFgd1sw7r K5F0P6n_PmVXxc8VaulD9R_JN1xpEPtsZfBhJSwNOscz56j5h6pMDXVs4qsucUOB29ia56jXGlhV _lR3OrwoQ1Iqh663yoCsBhNwe6WiG_ElrZ4n8qR2Zb0xEqAXcwwPtdyPq8Xa2njZMDSv3kD.Fatj taRAoYPOmnLIhSxUB4RkqQnKBfTtiX4eavHlZ4qYLiME2BT5FJhKAqhXlK_srOHfoCCtRC77neKp uEga0Dyh0.1gXkqcn1uYRbjW_tt9S1Z_3Sc44eYRTfkFOq64V1L3TCcXqr46PwbUUA8EdH77ByJH MPFXp55uoVox4gl8Uu2ZB6J7bg9vhjlKGoRiHN9DESPWB4Fkfg6zE36W48BuqCHJyajbUg4oD7X7 1CdDFF7Ym9F2PsdRXYsZQFkSFv5Q3oyk- Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ir2.yahoo.com with HTTP; Tue, 3 Sep 2019 15:43:58 +0000 Received: by smtp405.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 3edcc4dc058dc029291ae38d51f9ff23; Tue, 03 Sep 2019 15:43:55 +0000 (UTC) Date: Tue, 3 Sep 2019 23:43:46 +0800 From: Gao Xiang To: Christoph Hellwig Subject: Re: [PATCH 00/21] erofs: patchset addressing Christoph's comments Message-ID: <20190903154345.GA28846@hsiangkao-HP-ZHAN-66-Pro-G1> References: <20190802125347.166018-1-gaoxiang25@huawei.com> <20190901055130.30572-1-hsiangkao@aol.com> <20190902124645.GA8369@infradead.org> <20190902142452.GE2664@architecture4> <20190902152323.GB14009@infradead.org> <20190902155037.GD179615@architecture4> <20190903065803.GA11205@infradead.org> <20190903081749.GA89379@architecture4> <20190903153704.GA2201@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190903153704.GA2201@infradead.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , Chao Yu , linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, Chao Yu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi Christoph, On Tue, Sep 03, 2019 at 08:37:04AM -0700, Christoph Hellwig wrote: > On Tue, Sep 03, 2019 at 04:17:49PM +0800, Gao Xiang wrote: > > I implement a prelimitary version, but I have no idea it is a really > > cleanup for now. > > The fact that this has to guess the block device address_space > implementation is indeed pretty ugly. I'd much prefer to just use > read_cache_page_gfp, and live with the fact that this allocates > bufferheads behind you for now. I'll try to speed up my attempts to > get rid of the buffer heads on the block device mapping instead. Fully agree with your point. Let me use read_cache_page_gfp instead for now, hoping block device quickly avoiding from buffer_heads... Thanks, Gao Xiang _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel