From: Johan Hovold <johan@kernel.org>
To: joahannes <joahannes@gmail.com>
Cc: devel@driverdev.osuosl.org, elder@kernel.org,
gregkh@linuxfoundation.org, jevsilv@gmail.com, johan@kernel.org,
linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org,
lkcamp@lists.libreplanetbr.org
Subject: Re: [PATCH] staging: greybus: remove blank line after an open brace '{'.
Date: Thu, 5 Sep 2019 09:17:44 +0200 [thread overview]
Message-ID: <20190905071744.GC1701@localhost> (raw)
In-Reply-To: <20190904205558.27666-1-joahannes@gmail.com>
On Wed, Sep 04, 2019 at 08:55:58PM +0000, joahannes wrote:
> Fix checkpatch error
> "CHECK: Blank lines aren't necessary after an open brace '{'"
> in loopback_test.c:742.
Please fix up all of the blank lines before/after closing/opening brace
checkpatch CHECKs in one go. There appears to be many of them.
> Signed-off-by: joahannes <joahannes@gmail.com>
We need your full name here and in the From line.
> ---
> drivers/staging/greybus/tools/loopback_test.c | 1 -
Also, please include the component your modifying in the subject line
even if you need to shorten the description somehow, for example,
staging: greybus: loopback_test: remove unnecessary blank lines
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c
> index ba6f905f2..251b05710 100644
> --- a/drivers/staging/greybus/tools/loopback_test.c
> +++ b/drivers/staging/greybus/tools/loopback_test.c
> @@ -739,7 +739,6 @@ static int wait_for_complete(struct loopback_test *t)
> ts = &t->poll_timeout;
>
> while (1) {
> -
> ret = ppoll(t->fds, t->poll_count, ts, &mask_old);
> if (ret <= 0) {
> stop_tests(t);
Johan
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2019-09-05 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 20:55 [PATCH] staging: greybus: remove blank line after an open brace '{' joahannes
2019-09-05 7:17 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905071744.GC1701@localhost \
--to=johan@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=jevsilv@gmail.com \
--cc=joahannes@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).