From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B869BC43140 for ; Fri, 6 Sep 2019 16:19:03 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EBED2082C for ; Fri, 6 Sep 2019 16:19:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qv7QxCLK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EBED2082C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 5E97E88180; Fri, 6 Sep 2019 16:19:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z+6DBVufdn9h; Fri, 6 Sep 2019 16:19:02 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id D7CE1880CC; Fri, 6 Sep 2019 16:19:02 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id ABFC31BF325 for ; Fri, 6 Sep 2019 16:19:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id A5B8984702 for ; Fri, 6 Sep 2019 16:19:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8LuJ3ACLCpHo for ; Fri, 6 Sep 2019 16:19:01 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id 3818584770 for ; Fri, 6 Sep 2019 16:19:01 +0000 (UTC) Received: from localhost (unknown [89.248.140.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7C2EB206CD; Fri, 6 Sep 2019 16:19:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567786741; bh=9JR/0RztC02zpm+rMuDn4vuBR9pFtNIfq7WpGGMOOk8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qv7QxCLK0akzGp/aWJtCSApckxdhXoDkU3zjElZjYbChWOO/P0UEMvjqq5TVqHKLx r8uorRp2vKP67C3cQ6rffnowSq8geny5GgzA8w0gnzlzaJ4XDsbIq7Mo6DvLXMI/rv tBeg+CB+3Hv3hcgSB0AZgynFArCm9CBVW1vEAV+Y= Date: Fri, 6 Sep 2019 18:18:57 +0200 From: Greg Kroah-Hartman To: Arnd Bergmann Subject: Re: [PATCH 1/2] exfat stopusing CONFIG_FAT_DEFAULT_IOCHARSET Message-ID: <20190906161857.GA2585@kroah.com> References: <20190906150917.1025250-1-arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190906150917.1025250-1-arnd@arndb.de> User-Agent: Mutt/1.12.1 (2019-06-15) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Valentin Vidic , Valdis Kletnieks , linux-kernel@vger.kernel.org, Colin Ian King Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Fri, Sep 06, 2019 at 05:09:04PM +0200, Arnd Bergmann wrote: > When CONFIG_VFAT_FS is disabled, the reference to CONFIG_FAT_DEFAULT_IOCHARSET > causes a link failure: > > drivers/staging/exfat/exfat_super.c:46:41: error: use of undeclared identifier 'CONFIG_FAT_DEFAULT_IOCHARSET' > static char exfat_default_iocharset[] = CONFIG_FAT_DEFAULT_IOCHARSET; > > I could not figure out why the correct code is commented > out, but using that fixes the problem. For some reason I was getting a build error without that, I added those commented out lines. Odd. Oh well, thanks for fixing this :) greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel