From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8E0EC433EF for ; Sun, 8 Sep 2019 16:45:59 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E6F9218AE for ; Sun, 8 Sep 2019 16:45:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="DUuEBmsI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E6F9218AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 0EE20204B9; Sun, 8 Sep 2019 16:45:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dxcuNGvSDB5L; Sun, 8 Sep 2019 16:45:57 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 25C5A20451; Sun, 8 Sep 2019 16:45:57 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id ECD1C1BF2BD for ; Sun, 8 Sep 2019 16:45:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id E603E856B7 for ; Sun, 8 Sep 2019 16:45:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gF5RCjCLW4ut for ; Sun, 8 Sep 2019 16:45:55 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id 6EE488569B for ; Sun, 8 Sep 2019 16:45:55 +0000 (UTC) Received: from localhost (unknown [62.28.240.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C338221479; Sun, 8 Sep 2019 16:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567961155; bh=TLSx0eDVVIR9BUeNWztuRR5XMMb45dshPOmxd+txMxM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DUuEBmsIxz7gPIltGr0dKWkRGL8sQbJeLye44pKH2VyaYTozUwaU2hj89j4t85eqy orUE8bz3ZSvEGj4TK+uerA0IS6iwN5skalvteoeblB+iSPqf4R1h2CU0bfUVETvK0Q xWrFqypwXgivCnpSmny/qzefVHtJg6nejgvKW9G4= Date: Sun, 8 Sep 2019 17:45:52 +0100 From: Greg Kroah-Hartman To: Valentin Vidic Subject: Re: [PATCH v2 1/3] staging: exfat: drop duplicate date_time_t struct Message-ID: <20190908164552.GD8362@kroah.com> References: <20190908161015.26000-1-vvidic@valentin-vidic.from.hr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190908161015.26000-1-vvidic@valentin-vidic.from.hr> User-Agent: Mutt/1.12.1 (2019-06-15) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Valdis Kletnieks , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Sun, Sep 08, 2019 at 04:10:13PM +0000, Valentin Vidic wrote: > Use timestamp_t for everything and cleanup duplicate code. You dropped function parameters in here, which you did not describe in this changelog text :( Please only try to do "one logical thing" per patch to make it easier to review and revert if something goes wrong :) thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel