* [PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style issues.
@ 2019-09-29 0:21 Jesse Barton
2019-09-29 7:26 ` Greg KH
2019-10-01 13:17 ` Dan Carpenter
0 siblings, 2 replies; 5+ messages in thread
From: Jesse Barton @ 2019-09-29 0:21 UTC (permalink / raw)
To: valdis.kletnieks; +Cc: devel, linux-kernel, Jesse Barton
Fixed Coding Style issues
Signed-off-by: Jesse Barton <jessebarton95@gmail.com>
---
drivers/staging/exfat/exfat_super.c | 29 +++++++++--------------------
1 file changed, 9 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index 3c7e2b7c2195..b9656ec06144 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -640,8 +640,7 @@ static int ffs_lookup_file(struct inode *inode, char *path, struct file_id_t *fi
return ret;
}
-static int ffs_create_file(struct inode *inode, char *path, u8 mode,
- struct file_id_t *fid)
+static int ffs_create_file(struct inode *inode, char *path, u8 mode, struct file_id_t *fid)
{
struct chain_t dir;
struct uni_name_t uni_name;
@@ -681,8 +680,7 @@ static int ffs_create_file(struct inode *inode, char *path, u8 mode,
return ret;
}
-static int ffs_read_file(struct inode *inode, struct file_id_t *fid, void *buffer,
- u64 count, u64 *rcount)
+static int ffs_read_file(struct inode *inode, struct file_id_t *fid, void *buffer, u64 count, u64 *rcount)
{
s32 offset, sec_offset, clu_offset;
u32 clu;
@@ -805,8 +803,7 @@ static int ffs_read_file(struct inode *inode, struct file_id_t *fid, void *buffe
return ret;
}
-static int ffs_write_file(struct inode *inode, struct file_id_t *fid,
- void *buffer, u64 count, u64 *wcount)
+static int ffs_write_file(struct inode *inode, struct file_id_t *fid, void *buffer, u64 count, u64 *wcount)
{
bool modified = false;
s32 offset, sec_offset, clu_offset;
@@ -1212,8 +1209,7 @@ static void update_parent_info(struct file_id_t *fid,
}
}
-static int ffs_move_file(struct inode *old_parent_inode, struct file_id_t *fid,
- struct inode *new_parent_inode, struct dentry *new_dentry)
+static int ffs_move_file(struct inode *old_parent_inode, struct file_id_t *fid, struct inode *new_parent_inode, struct dentry *new_dentry)
{
s32 ret;
s32 dentry;
@@ -2061,9 +2057,7 @@ static int ffs_read_dir(struct inode *inode, struct dir_entry_t *dir_entry)
fs_func->get_uni_name_from_ext_entry(sb, &dir, dentry,
uni_name.name);
if (*uni_name.name == 0x0 && p_fs->vol_type != EXFAT)
- get_uni_name_from_dos_entry(sb,
- (struct dos_dentry_t *)ep,
- &uni_name, 0x1);
+ get_uni_name_from_dos_entry(sb, (struct dos_dentry_t *)ep, &uni_name, 0x1);
nls_uniname_to_cstring(sb, dir_entry->Name, &uni_name);
buf_unlock(sb, sector);
@@ -2074,11 +2068,8 @@ static int ffs_read_dir(struct inode *inode, struct dir_entry_t *dir_entry)
goto out;
}
} else {
- get_uni_name_from_dos_entry(sb,
- (struct dos_dentry_t *)ep,
- &uni_name, 0x0);
- nls_uniname_to_cstring(sb, dir_entry->ShortName,
- &uni_name);
+ get_uni_name_from_dos_entry(sb, (struct dos_dentry_t *)ep, &uni_name, 0x0);
+ nls_uniname_to_cstring(sb, dir_entry->ShortName, &uni_name);
}
dir_entry->Size = fs_func->get_entry_size(ep);
@@ -2460,8 +2451,7 @@ static struct dentry *exfat_lookup(struct inode *dir, struct dentry *dentry,
err = -ENOMEM;
goto error;
}
- ffs_read_file(dir, &fid, EXFAT_I(inode)->target,
- i_size_read(inode), &ret);
+ ffs_read_file(dir, &fid, EXFAT_I(inode)->target, i_size_read(inode), &ret);
*(EXFAT_I(inode)->target + i_size_read(inode)) = '\0';
}
@@ -2748,8 +2738,7 @@ static int exfat_rename(struct inode *old_dir, struct dentry *old_dentry,
EXFAT_I(old_inode)->fid.size = i_size_read(old_inode);
- err = ffs_move_file(old_dir, &(EXFAT_I(old_inode)->fid), new_dir,
- new_dentry);
+ err = ffs_move_file(old_dir, &(EXFAT_I(old_inode)->fid), new_dir, new_dentry);
if (err) {
if (err == FFS_PERMISSIONERR)
err = -EPERM;
--
2.23.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style issues.
2019-09-29 0:21 [PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style issues Jesse Barton
@ 2019-09-29 7:26 ` Greg KH
2019-10-01 13:17 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2019-09-29 7:26 UTC (permalink / raw)
To: Jesse Barton; +Cc: devel, valdis.kletnieks, linux-kernel
On Sat, Sep 28, 2019 at 07:21:19PM -0500, Jesse Barton wrote:
> Fixed Coding Style issues
You need to be specific as to _what_ exactly you did here. What you
wrote is very vague :)
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style issues.
2019-09-29 0:21 [PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style issues Jesse Barton
2019-09-29 7:26 ` Greg KH
@ 2019-10-01 13:17 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2019-10-01 13:17 UTC (permalink / raw)
To: Jesse Barton; +Cc: devel, valdis.kletnieks, linux-kernel
On Sat, Sep 28, 2019 at 07:21:19PM -0500, Jesse Barton wrote:
> Fixed Coding Style issues
Which ones?
>
> Signed-off-by: Jesse Barton <jessebarton95@gmail.com>
> ---
> drivers/staging/exfat/exfat_super.c | 29 +++++++++--------------------
> 1 file changed, 9 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
> index 3c7e2b7c2195..b9656ec06144 100644
> --- a/drivers/staging/exfat/exfat_super.c
> +++ b/drivers/staging/exfat/exfat_super.c
> @@ -640,8 +640,7 @@ static int ffs_lookup_file(struct inode *inode, char *path, struct file_id_t *fi
> return ret;
> }
>
> -static int ffs_create_file(struct inode *inode, char *path, u8 mode,
> - struct file_id_t *fid)
> +static int ffs_create_file(struct inode *inode, char *path, u8 mode, struct file_id_t *fid)
I think now checkpatch will complain that the line is too long? What we
want here is:
static int ffs_create_file(struct inode *inode, char *path, u8 mode,
struct file_id_t *fid)
[tab][tab][tab][space][space][space]struct file_id_t *fid)
So they line up.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style issues.
2019-09-29 14:52 Jesse Barton
@ 2019-09-29 14:59 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2019-09-29 14:59 UTC (permalink / raw)
To: Jesse Barton; +Cc: devel, valdis.kletnieks, linux-kernel
On Sun, Sep 29, 2019 at 09:52:45AM -0500, Jesse Barton wrote:
> Removed function argument wrapping to new line.
I don't think you "removed" anything here :(
Writing the changelog is usually harder than writing the patch in the
first place, welcome to programming! :)
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style issues.
@ 2019-09-29 14:52 Jesse Barton
2019-09-29 14:59 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Jesse Barton @ 2019-09-29 14:52 UTC (permalink / raw)
To: valdis.kletnieks; +Cc: devel, gregkh, linux-kernel, Jesse Barton
Removed function argument wrapping to new line.
Signed-off-by: Jesse Barton <jessebarton95@gmail.com>
---
drivers/staging/exfat/exfat_super.c | 29 +++++++++--------------------
1 file changed, 9 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index 3c7e2b7c2195..b9656ec06144 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -640,8 +640,7 @@ static int ffs_lookup_file(struct inode *inode, char *path, struct file_id_t *fi
return ret;
}
-static int ffs_create_file(struct inode *inode, char *path, u8 mode,
- struct file_id_t *fid)
+static int ffs_create_file(struct inode *inode, char *path, u8 mode, struct file_id_t *fid)
{
struct chain_t dir;
struct uni_name_t uni_name;
@@ -681,8 +680,7 @@ static int ffs_create_file(struct inode *inode, char *path, u8 mode,
return ret;
}
-static int ffs_read_file(struct inode *inode, struct file_id_t *fid, void *buffer,
- u64 count, u64 *rcount)
+static int ffs_read_file(struct inode *inode, struct file_id_t *fid, void *buffer, u64 count, u64 *rcount)
{
s32 offset, sec_offset, clu_offset;
u32 clu;
@@ -805,8 +803,7 @@ static int ffs_read_file(struct inode *inode, struct file_id_t *fid, void *buffe
return ret;
}
-static int ffs_write_file(struct inode *inode, struct file_id_t *fid,
- void *buffer, u64 count, u64 *wcount)
+static int ffs_write_file(struct inode *inode, struct file_id_t *fid, void *buffer, u64 count, u64 *wcount)
{
bool modified = false;
s32 offset, sec_offset, clu_offset;
@@ -1212,8 +1209,7 @@ static void update_parent_info(struct file_id_t *fid,
}
}
-static int ffs_move_file(struct inode *old_parent_inode, struct file_id_t *fid,
- struct inode *new_parent_inode, struct dentry *new_dentry)
+static int ffs_move_file(struct inode *old_parent_inode, struct file_id_t *fid, struct inode *new_parent_inode, struct dentry *new_dentry)
{
s32 ret;
s32 dentry;
@@ -2061,9 +2057,7 @@ static int ffs_read_dir(struct inode *inode, struct dir_entry_t *dir_entry)
fs_func->get_uni_name_from_ext_entry(sb, &dir, dentry,
uni_name.name);
if (*uni_name.name == 0x0 && p_fs->vol_type != EXFAT)
- get_uni_name_from_dos_entry(sb,
- (struct dos_dentry_t *)ep,
- &uni_name, 0x1);
+ get_uni_name_from_dos_entry(sb, (struct dos_dentry_t *)ep, &uni_name, 0x1);
nls_uniname_to_cstring(sb, dir_entry->Name, &uni_name);
buf_unlock(sb, sector);
@@ -2074,11 +2068,8 @@ static int ffs_read_dir(struct inode *inode, struct dir_entry_t *dir_entry)
goto out;
}
} else {
- get_uni_name_from_dos_entry(sb,
- (struct dos_dentry_t *)ep,
- &uni_name, 0x0);
- nls_uniname_to_cstring(sb, dir_entry->ShortName,
- &uni_name);
+ get_uni_name_from_dos_entry(sb, (struct dos_dentry_t *)ep, &uni_name, 0x0);
+ nls_uniname_to_cstring(sb, dir_entry->ShortName, &uni_name);
}
dir_entry->Size = fs_func->get_entry_size(ep);
@@ -2460,8 +2451,7 @@ static struct dentry *exfat_lookup(struct inode *dir, struct dentry *dentry,
err = -ENOMEM;
goto error;
}
- ffs_read_file(dir, &fid, EXFAT_I(inode)->target,
- i_size_read(inode), &ret);
+ ffs_read_file(dir, &fid, EXFAT_I(inode)->target, i_size_read(inode), &ret);
*(EXFAT_I(inode)->target + i_size_read(inode)) = '\0';
}
@@ -2748,8 +2738,7 @@ static int exfat_rename(struct inode *old_dir, struct dentry *old_dentry,
EXFAT_I(old_inode)->fid.size = i_size_read(old_inode);
- err = ffs_move_file(old_dir, &(EXFAT_I(old_inode)->fid), new_dir,
- new_dentry);
+ err = ffs_move_file(old_dir, &(EXFAT_I(old_inode)->fid), new_dir, new_dentry);
if (err) {
if (err == FFS_PERMISSIONERR)
err = -EPERM;
--
2.23.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-01 13:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-29 0:21 [PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style issues Jesse Barton
2019-09-29 7:26 ` Greg KH
2019-10-01 13:17 ` Dan Carpenter
2019-09-29 14:52 Jesse Barton
2019-09-29 14:59 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).