From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 914EDC10F14 for ; Tue, 8 Oct 2019 15:12:32 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 666D621721 for ; Tue, 8 Oct 2019 15:12:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="2HjncGEu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 666D621721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 71BEF87EA2; Tue, 8 Oct 2019 15:12:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JW7YNAiKLrl4; Tue, 8 Oct 2019 15:12:29 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 09F0D87EC4; Tue, 8 Oct 2019 15:12:29 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 5D57F1BF2EA for ; Tue, 8 Oct 2019 15:12:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 5942586372 for ; Tue, 8 Oct 2019 15:12:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LBPYBkh4X58I for ; Tue, 8 Oct 2019 15:12:26 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id CE303860D5 for ; Tue, 8 Oct 2019 15:12:26 +0000 (UTC) Received: from localhost (unknown [89.205.136.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 067A8206BB; Tue, 8 Oct 2019 15:12:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570547546; bh=p42gS4RtNG7UoSOthmU6Kr/tgm5UoDEQiZTKBV+2H10=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2HjncGEunDfYJSuoMrFF5QeN+G7qOZn/uPzk4UIKZhphoJuKp01qiyTlT1dTPb0yV DFZSnPGp10m5c2AuT0LFGS5tvI7rVoUodrdgk2QOLbp+BMltwlFqgyrc9F6t8qrpxD HXbg+/Y2Pu3Rqj+EyNj5zhL7GtP+0EvNtF6vqpQg= Date: Tue, 8 Oct 2019 17:12:23 +0200 From: Greg KH To: Ian Abbott Subject: Re: [PATCH v2 5/6] staging: comedi: Remove set but not used variable 'hi' Message-ID: <20191008151223.GB2862237@kroah.com> References: <1570520515-2186-1-git-send-email-zhengbin13@huawei.com> <1570520515-2186-6-git-send-email-zhengbin13@huawei.com> <03d15655-46fb-5312-5770-c0ebde1dc009@mev.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <03d15655-46fb-5312-5770-c0ebde1dc009@mev.co.uk> User-Agent: Mutt/1.12.2 (2019-09-21) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, zhengbin , eric@anholt.net, wahrenst@gmx.net, dan.carpenter@oracle.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Tue, Oct 08, 2019 at 01:56:49PM +0100, Ian Abbott wrote: > On 08/10/2019 08:41, zhengbin wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > drivers/staging/comedi/drivers/dt2815.c: In function dt2815_ao_insn: > > drivers/staging/comedi/drivers/dt2815.c:91:19: warning: variable hi set but not used [-Wunused-but-set-variable] > > > > It is not used since commit d6a929b7608a ("Staging: > > comedi: add dt2815 driver") > > > > Reported-by: Hulk Robot > > Signed-off-by: zhengbin > > --- > > drivers/staging/comedi/drivers/dt2815.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/staging/comedi/drivers/dt2815.c b/drivers/staging/comedi/drivers/dt2815.c > > index 83026ba..bcf85ec 100644 > > --- a/drivers/staging/comedi/drivers/dt2815.c > > +++ b/drivers/staging/comedi/drivers/dt2815.c > > @@ -88,12 +88,11 @@ static int dt2815_ao_insn(struct comedi_device *dev, struct comedi_subdevice *s, > > struct dt2815_private *devpriv = dev->private; > > int i; > > int chan = CR_CHAN(insn->chanspec); > > - unsigned int lo, hi; > > + unsigned int lo; > > int ret; > > > > for (i = 0; i < insn->n; i++) { > > lo = ((data[i] & 0x0f) << 4) | (chan << 1) | 0x01; > > - hi = (data[i] & 0xff0) >> 4; > > > > ret = comedi_timeout(dev, s, insn, dt2815_ao_status, 0x00); > > if (ret) > > -- > > 2.7.4 > > > > There is something fishy going on in this one too. It should be writing the > 'hi' value to the card registers. > > Please could you omit this patch from the series so I can investigate? Now dropped, thanks. greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel