From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3622CA9EB6 for ; Wed, 23 Oct 2019 16:52:58 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB22221925 for ; Wed, 23 Oct 2019 16:52:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bCC1XEBz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB22221925 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 05A2B228EC; Wed, 23 Oct 2019 16:52:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qx76wyEh0jvY; Wed, 23 Oct 2019 16:52:54 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id E1A8B20C41; Wed, 23 Oct 2019 16:52:54 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id E2BA91BF2FF for ; Wed, 23 Oct 2019 16:52:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id DBFA9877E9 for ; Wed, 23 Oct 2019 16:52:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id clcWPDCP9Em4 for ; Wed, 23 Oct 2019 16:52:53 +0000 (UTC) X-Greylist: delayed 00:27:01 by SQLgrey-1.7.6 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by hemlock.osuosl.org (Postfix) with ESMTPS id 221E8875F9 for ; Wed, 23 Oct 2019 16:52:53 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id u23so1798951pgo.0 for ; Wed, 23 Oct 2019 09:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2ozmEBacDU37qdWHmaIXZS/t2e/cIQTfwOrpKCFE/tE=; b=bCC1XEBzNQHigL0d7R6bPEzxm8alb+W4dTu8itjDoIuQnpvCdh21/KVzmfE+Tgs+ET ceWRH1QFAtQCwVmj0wWuvh6QCkQaRgwgCLBTlsOklkfp9LViU9s8B80hK7K0MoC/AGMW ZF1fsM40mC3fIPu5YTFXe03NoKjMsALdc4tX0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2ozmEBacDU37qdWHmaIXZS/t2e/cIQTfwOrpKCFE/tE=; b=ukU3fUOcX9YS2dc5vn50cDH2sDoH7f+tfkGTJZx94L7UscboAntwLKaxtsaFGP7wBv y2hgS+j4OinHKYQaw7ZVOrNVFVaOZv0f/v2FGsmbBNhs86ZT4qbrSzBNfeqjlx01O8tG FiPO+453TXuzpkUIV94a/Yx4ddHgrZs/B6llgug0168ckV5vsFP4r8zfjCm7ssTIjp3T XGVZeBD0trPnDVMDxWtgdC25rdTBMWt8dv7PZ5QrodaF6voxy9hx73zAbvkVwuyOjlzL CTQxBa4PnsK0XRiT75zUqY2VgPfMh2LUg5bwTkBOqNdPC4zTXX+Q7o4oT/WzkDFIg2vU Yqzg== X-Gm-Message-State: APjAAAUZk+1sPQkfO2/OSal7pEph12uK4+izSvFWQNuLfVDkC4vNl8g6 Vkm5+mTudVDuNHFudx0f7TnpsK2qzvI= X-Google-Smtp-Source: APXvYqw1/SgWscVWVYwNzvC56vf/67s2dhZn0DnFv2vyro2EnV66Rhc87hJA64tPAho0TcM73pujSw== X-Received: by 2002:a63:1042:: with SMTP id 2mr11383658pgq.59.1571847952291; Wed, 23 Oct 2019 09:25:52 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y8sm27285047pgs.34.2019.10.23.09.25.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2019 09:25:51 -0700 (PDT) Date: Wed, 23 Oct 2019 09:25:49 -0700 From: Kees Cook To: David Hildenbrand Subject: Re: [PATCH RFC v1 02/12] mm/usercopy.c: Prepare check_page_span() for PG_reserved changes Message-ID: <201910230924.DE879ED80F@keescook> References: <20191022171239.21487-1-david@redhat.com> <20191022171239.21487-3-david@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kate Stewart , Sasha Levin , linux-hyperv@vger.kernel.org, Michal Hocko , Radim =?utf-8?B?S3LEjW3DocWZ?= , kvm@vger.kernel.org, Pavel Tatashin , KarimAllah Ahmed , Benjamin Herrenschmidt , Dave Hansen , Alexander Duyck , Michal Hocko , Paul Mackerras , linux-mm@kvack.org, Paul Mackerras , Michael Ellerman , "H. Peter Anvin" , Wanpeng Li , Alexander Duyck , Pavel Tatashin , devel@driverdev.osuosl.org, Stefano Stabellini , Stephen Hemminger , "Aneesh Kumar K.V" , Joerg Roedel , x86@kernel.org, YueHaibing , Matthew Wilcox , Mike Rapoport , Madhumitha Prabakaran , Peter Zijlstra , Ingo Molnar , Vlastimil Babka , Nishka Dasgupta , Anthony Yznaga , Oscar Salvador , Dan Carpenter , "Isaac J. Manjarres" , Juergen Gross , Anshuman Khandual , Haiyang Zhang , Simon =?iso-8859-1?Q?Sandstr=F6m?= , Dan Williams , kvm-ppc@vger.kernel.org, Qian Cai , Alex Williamson , Mike Rapoport , Borislav Petkov , Nicholas Piggin , Andy Lutomirski , xen-devel@lists.xenproject.org, Boris Ostrovsky , Todd Poynor , Vitaly Kuznetsov , Allison Randal , Jim Mattson , Christophe Leroy , Vandana BN , Mel Gorman , Greg Kroah-Hartman , Cornelia Huck , linux-kernel@vger.kernel.org, Sean Christopherson , Rob Springer , Thomas Gleixner , Johannes Weiner , Paolo Bonzini , Andrew Morton , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Wed, Oct 23, 2019 at 10:20:14AM +0200, David Hildenbrand wrote: > On 22.10.19 19:12, David Hildenbrand wrote: > > Right now, ZONE_DEVICE memory is always set PG_reserved. We want to > > change that. > > > > Let's make sure that the logic in the function won't change. Once we no > > longer set these pages to reserved, we can rework this function to > > perform separate checks for ZONE_DEVICE (split from PG_reserved checks). > > > > Cc: Kees Cook > > Cc: Andrew Morton > > Cc: Kate Stewart > > Cc: Allison Randal > > Cc: "Isaac J. Manjarres" > > Cc: Qian Cai > > Cc: Thomas Gleixner > > Signed-off-by: David Hildenbrand > > --- > > mm/usercopy.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/mm/usercopy.c b/mm/usercopy.c > > index 660717a1ea5c..a3ac4be35cde 100644 > > --- a/mm/usercopy.c > > +++ b/mm/usercopy.c > > @@ -203,14 +203,15 @@ static inline void check_page_span(const void *ptr, unsigned long n, > > * device memory), or CMA. Otherwise, reject since the object spans > > * several independently allocated pages. > > */ > > - is_reserved = PageReserved(page); > > + is_reserved = PageReserved(page) || is_zone_device_page(page); > > is_cma = is_migrate_cma_page(page); > > if (!is_reserved && !is_cma) > > usercopy_abort("spans multiple pages", NULL, to_user, 0, n); > > for (ptr += PAGE_SIZE; ptr <= end; ptr += PAGE_SIZE) { > > page = virt_to_head_page(ptr); > > - if (is_reserved && !PageReserved(page)) > > + if (is_reserved && !(PageReserved(page) || > > + is_zone_device_page(page))) > > usercopy_abort("spans Reserved and non-Reserved pages", > > NULL, to_user, 0, n); > > if (is_cma && !is_migrate_cma_page(page)) > > > > @Kees, would it be okay to stop checking against ZONE_DEVICE pages here or > is there a good rationale behind this? > > (I would turn this patch into a simple update of the comment if we agree > that we don't care) There has been work to actually remove the page span checks entirely, but there wasn't consensus on what the right way forward was. I continue to leaning toward just dropping it entirely, but Matthew Wilcox has some alternative ideas that could use some further thought/testing. -- Kees Cook _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel