From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDF99CA9EB6 for ; Wed, 23 Oct 2019 17:43:11 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D02B321872 for ; Wed, 23 Oct 2019 17:43:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D02B321872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=iki.fi Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 79799860FC; Wed, 23 Oct 2019 17:43:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y00C3bK4UO8I; Wed, 23 Oct 2019 17:43:11 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 85693863E0; Wed, 23 Oct 2019 17:43:10 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id B49301BF873 for ; Wed, 23 Oct 2019 17:43:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 91E99204F7 for ; Wed, 23 Oct 2019 17:43:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jbDayVCd9uR2 for ; Wed, 23 Oct 2019 17:43:07 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from emh07.mail.saunalahti.fi (emh07.mail.saunalahti.fi [62.142.5.117]) by silver.osuosl.org (Postfix) with ESMTPS id 761A122115 for ; Wed, 23 Oct 2019 17:43:07 +0000 (UTC) Received: from darkstar.musicnaut.iki.fi (85-76-128-127-nat.elisa-mobile.fi [85.76.128.127]) by emh07.mail.saunalahti.fi (Postfix) with ESMTP id 02536B006F; Wed, 23 Oct 2019 20:43:04 +0300 (EEST) Date: Wed, 23 Oct 2019 20:43:04 +0300 From: Aaro Koskinen To: Julia Lawall , Wambui Karuga , Greg Kroah-Hartman Subject: Re: [Outreachy kernel] [PATCH v2 0/5] Remove typedef declarations in staging: octeon Message-ID: <20191023174304.GD18977@darkstar.musicnaut.iki.fi> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi, On Sat, Oct 12, 2019 at 08:35:19PM +0200, Julia Lawall wrote: > On Sat, 12 Oct 2019, Wambui Karuga wrote: > > This patchset removes the addition of new typedefs data types in octeon, > > along with replacing the previous uses with the new declaration format. > > > > v2 of the series removes the obsolete "_t" notation in the named types. > > > > Wambui Karuga (5): > > staging: octeon: remove typedef declaration for cvmx_wqe > > staging: octeon: remove typedef declaration for cvmx_helper_link_info > > staging: octeon: remove typedef declaration for cvmx_fau_reg_32 > > staging: octeon: remove typedef declartion for cvmx_pko_command_word0 > > staging: octeon: remove typedef declaration for cvmx_fau_op_size > > > > drivers/staging/octeon/ethernet-mdio.c | 6 +-- > > drivers/staging/octeon/ethernet-rgmii.c | 4 +- > > drivers/staging/octeon/ethernet-rx.c | 6 +-- > > drivers/staging/octeon/ethernet-tx.c | 4 +- > > drivers/staging/octeon/ethernet.c | 6 +-- > > drivers/staging/octeon/octeon-ethernet.h | 2 +- > > drivers/staging/octeon/octeon-stubs.h | 56 ++++++++++++------------ > > 7 files changed, 43 insertions(+), 41 deletions(-) > > For the series: > > Acked-by: Julia Lawall This series breaks the build on MIPS/OCTEON (the only actual HW using this driver): $ make ARCH=mips CROSS_COMPILE=mips64-linux-gnu- cavium_octeon_defconfig $ make ARCH=mips CROSS_COMPILE=mips64-linux-gnu- [...] CC drivers/staging/octeon/ethernet.o In file included from drivers/staging/octeon/ethernet.c:22: drivers/staging/octeon/octeon-ethernet.h:94:12: warning: 'union cvmx_helper_link_info' declared inside parameter list will not be visible outside of this definition or declaration union cvmx_helper_link_info li); ^~~~~~~~~~~~~~~~~~~~~ drivers/staging/octeon/ethernet.c: In function 'cvm_oct_free_work': drivers/staging/octeon/ethernet.c:177:21: error: dereferencing pointer to incomplete type 'struct cvmx_wqe' int segments = work->word2.s.bufs; ^~ drivers/staging/octeon/ethernet.c: In function 'cvm_oct_common_open': drivers/staging/octeon/ethernet.c:463:30: error: storage size of 'link_info' isn't known union cvmx_helper_link_info link_info; ^~~~~~~~~ etc. Probably all these patches need to be reverted. A. _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel