From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: devel@driverdev.osuosl.org, Julia Lawall <julia.lawall@lip6.fr>,
outreachy-kernel@googlegroups.com, linux-kernel@vger.kernel.org,
Wambui Karuga <wambui.karugax@gmail.com>
Subject: Re: [Outreachy kernel] [PATCH v2 0/5] Remove typedef declarations in staging: octeon
Date: Sat, 26 Oct 2019 20:47:16 +0200 [thread overview]
Message-ID: <20191026184716.GA753584@kroah.com> (raw)
In-Reply-To: <20191023174304.GD18977@darkstar.musicnaut.iki.fi>
On Wed, Oct 23, 2019 at 08:43:04PM +0300, Aaro Koskinen wrote:
> Hi,
>
> On Sat, Oct 12, 2019 at 08:35:19PM +0200, Julia Lawall wrote:
> > On Sat, 12 Oct 2019, Wambui Karuga wrote:
> > > This patchset removes the addition of new typedefs data types in octeon,
> > > along with replacing the previous uses with the new declaration format.
> > >
> > > v2 of the series removes the obsolete "_t" notation in the named types.
> > >
> > > Wambui Karuga (5):
> > > staging: octeon: remove typedef declaration for cvmx_wqe
> > > staging: octeon: remove typedef declaration for cvmx_helper_link_info
> > > staging: octeon: remove typedef declaration for cvmx_fau_reg_32
> > > staging: octeon: remove typedef declartion for cvmx_pko_command_word0
> > > staging: octeon: remove typedef declaration for cvmx_fau_op_size
> > >
> > > drivers/staging/octeon/ethernet-mdio.c | 6 +--
> > > drivers/staging/octeon/ethernet-rgmii.c | 4 +-
> > > drivers/staging/octeon/ethernet-rx.c | 6 +--
> > > drivers/staging/octeon/ethernet-tx.c | 4 +-
> > > drivers/staging/octeon/ethernet.c | 6 +--
> > > drivers/staging/octeon/octeon-ethernet.h | 2 +-
> > > drivers/staging/octeon/octeon-stubs.h | 56 ++++++++++++------------
> > > 7 files changed, 43 insertions(+), 41 deletions(-)
> >
> > For the series:
> >
> > Acked-by: Julia Lawall <julia.lawall@lip6.fr>
>
> This series breaks the build on MIPS/OCTEON (the only actual HW using this
> driver):
>
> $ make ARCH=mips CROSS_COMPILE=mips64-linux-gnu- cavium_octeon_defconfig
> $ make ARCH=mips CROSS_COMPILE=mips64-linux-gnu-
> [...]
> CC drivers/staging/octeon/ethernet.o
> In file included from drivers/staging/octeon/ethernet.c:22:
> drivers/staging/octeon/octeon-ethernet.h:94:12: warning: 'union cvmx_helper_link_info' declared inside parameter list will not be visible outside of this definition or declaration
> union cvmx_helper_link_info li);
> ^~~~~~~~~~~~~~~~~~~~~
> drivers/staging/octeon/ethernet.c: In function 'cvm_oct_free_work':
> drivers/staging/octeon/ethernet.c:177:21: error: dereferencing pointer to incomplete type 'struct cvmx_wqe'
> int segments = work->word2.s.bufs;
> ^~
> drivers/staging/octeon/ethernet.c: In function 'cvm_oct_common_open':
> drivers/staging/octeon/ethernet.c:463:30: error: storage size of 'link_info' isn't known
> union cvmx_helper_link_info link_info;
> ^~~~~~~~~
>
> etc.
>
> Probably all these patches need to be reverted.
Ick :(
What is the git commit ids here that should be reverted?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2019-10-26 18:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 18:04 [PATCH v2 0/5] Remove typedef declarations in staging: octeon Wambui Karuga
2019-10-12 18:04 ` [PATCH v2 1/5] staging: octeon: remove typedef declaration for cvmx_wqe Wambui Karuga
2019-10-24 5:00 ` Paul Burton
2019-10-24 5:26 ` [Outreachy kernel] " Julia Lawall
2019-10-24 10:00 ` Wambui Karuga
2019-10-24 20:54 ` Paul Burton
2019-10-24 20:57 ` Julia Lawall
2019-10-12 18:04 ` [PATCH v2 2/5] staging: octeon: remove typedef declaration for cvmx_helper_link_info Wambui Karuga
2019-10-12 18:04 ` [PATCH v2 3/5] staging: octeon: remove typedef declaration for cvmx_fau_reg_32 Wambui Karuga
2019-10-12 18:37 ` [Outreachy kernel] " Julia Lawall
2019-10-12 22:22 ` Wambui Karuga
2019-10-12 18:04 ` [PATCH v2 4/5] staging: octeon: remove typedef declartion for cvmx_pko_command_word0 Wambui Karuga
2019-10-12 18:04 ` [PATCH v2 5/5] staging: octeon: remove typedef declaration for cvmx_fau_op_size Wambui Karuga
2019-10-12 18:35 ` [Outreachy kernel] [PATCH v2 0/5] Remove typedef declarations in staging: octeon Julia Lawall
2019-10-23 17:43 ` Aaro Koskinen
2019-10-23 18:05 ` Wambui Karuga
2019-10-26 18:47 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191026184716.GA753584@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aaro.koskinen@iki.fi \
--cc=devel@driverdev.osuosl.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=wambui.karugax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).