From: Greg KH <gregkh@linuxfoundation.org>
To: Rama Kumar <ramakumar.kanasundara@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
nishadkamdar@gmail.com
Subject: Re: [PATCH] FBTFT: Changed delay function.
Date: Sun, 3 Nov 2019 16:59:03 +0100 [thread overview]
Message-ID: <20191103155903.GA673124@kroah.com> (raw)
In-Reply-To: <20191103154003.2739-1-ramakumar.kanasundara@gmail.com>
On Sun, Nov 03, 2019 at 09:40:03AM -0600, Rama Kumar wrote:
>
> Hi,
>
> Changed udelay() to usleep_range() based on the document in the path, "Documentation/timers/timers-howto.rst". It was suggested to use usleep_range() function for sleeping duration between 10us - 20 ms. original code used udelay() for sleeping 20 us.
>
> ---
> drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c
> index eeeeec97ad27..471a145e3c00 100644
> --- a/drivers/staging/fbtft/fb_agm1264k-fl.c
> +++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
> @@ -85,7 +85,7 @@ static void reset(struct fbtft_par *par)
> dev_dbg(par->info->device, "%s()\n", __func__);
>
> gpiod_set_value(par->gpio.reset, 0);
> - udelay(20);
> + usleep_range(20,20);
> gpiod_set_value(par->gpio.reset, 1);
> mdelay(120);
> }
> --
> Signed-off-by: Rama Kumar <ramakumar.kanasundara@gmail.com>
Always run checkptch.pl on patches you send out so you don't get grumpy
maintainers telling you to run checkpatch.pl on your patch :)
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2019-11-03 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-03 15:40 [PATCH] FBTFT: Changed delay function Rama Kumar
2019-11-03 15:59 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191103155903.GA673124@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nishadkamdar@gmail.com \
--cc=ramakumar.kanasundara@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).