* [PATCH] staging: rts5208: rewrite macro with GNU extension __auto_type
@ 2019-11-04 16:44 Jules Irenge
2019-11-04 16:51 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Jules Irenge @ 2019-11-04 16:44 UTC (permalink / raw)
To: outreachy-kernel; +Cc: devel, gregkh, Jules Irenge, linux-kernel
Rewrite macro function with GNU extension __auto_type
to remove issue detected by checkpatch tool.
CHECK: MACRO argument reuse - possible side-effects?
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/staging/rts5208/rtsx_chip.h | 92 +++++++++++++++++------------
1 file changed, 55 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.h b/drivers/staging/rts5208/rtsx_chip.h
index bac65784d4a1..4b986d5c68da 100644
--- a/drivers/staging/rts5208/rtsx_chip.h
+++ b/drivers/staging/rts5208/rtsx_chip.h
@@ -386,23 +386,31 @@ struct zone_entry {
/* SD card */
#define CHK_SD(sd_card) (((sd_card)->sd_type & 0xFF) == TYPE_SD)
-#define CHK_SD_HS(sd_card) (CHK_SD(sd_card) && \
- ((sd_card)->sd_type & SD_HS))
-#define CHK_SD_SDR50(sd_card) (CHK_SD(sd_card) && \
- ((sd_card)->sd_type & SD_SDR50))
-#define CHK_SD_DDR50(sd_card) (CHK_SD(sd_card) && \
- ((sd_card)->sd_type & SD_DDR50))
-#define CHK_SD_SDR104(sd_card) (CHK_SD(sd_card) && \
- ((sd_card)->sd_type & SD_SDR104))
-#define CHK_SD_HCXC(sd_card) (CHK_SD(sd_card) && \
- ((sd_card)->sd_type & SD_HCXC))
-#define CHK_SD_HC(sd_card) (CHK_SD_HCXC(sd_card) && \
- ((sd_card)->capacity <= 0x4000000))
-#define CHK_SD_XC(sd_card) (CHK_SD_HCXC(sd_card) && \
- ((sd_card)->capacity > 0x4000000))
-#define CHK_SD30_SPEED(sd_card) (CHK_SD_SDR50(sd_card) || \
- CHK_SD_DDR50(sd_card) || \
- CHK_SD_SDR104(sd_card))
+#define CHK_SD_HS(sd_card)\
+ ({__auto_type _sd = sd_card; CHK_SD(_sd) && \
+ (_sd->sd_type & SD_HS); })
+#define CHK_SD_SDR50(sd_card)\
+ ({__auto_type _sd = sd_card; CHK_SD(_sd) && \
+ (_sd->sd_type & SD_SDR50); })
+#define CHK_SD_DDR50(sd_card)\
+ ({__auto_type _sd = sd_card; CHK_SD(_sd) && \
+ (_sd->sd_type & SD_DDR50); })
+#define CHK_SD_SDR104(sd_card)\
+ ({__auto_type _sd = sd_card; CHK_SD(_sd) && \
+ (_sd->sd_type & SD_SDR104); })
+#define CHK_SD_HCXC(sd_card)\
+ ({__auto_type _sd = sd_card; CHK_SD(_sd) && \
+ (_sd->sd_type & SD_HCXC); })
+#define CHK_SD_HC(sd_card)\
+ ({__auto_type _sd = sd_card; CHK_SD_HCXC(_sd) && \
+ (_sd->capacity <= 0x4000000); })
+#define CHK_SD_XC(sd_card)\
+ ({__auto_type _sd = sd_card; CHK_SD_HCXC(_sd) && \
+ (_sd->capacity > 0x4000000); })
+#define CHK_SD30_SPEED(sd_card)\
+ ({__auto_type _sd = sd_card; CHK_SD_SDR50(_sd) || \
+ CHK_SD_DDR50(_sd) || \
+ CHK_SD_SDR104(_sd); })
#define SET_SD(sd_card) ((sd_card)->sd_type = TYPE_SD)
#define SET_SD_HS(sd_card) ((sd_card)->sd_type |= SD_HS)
@@ -420,18 +428,24 @@ struct zone_entry {
/* MMC card */
#define CHK_MMC(sd_card) (((sd_card)->sd_type & 0xFF) == \
TYPE_MMC)
-#define CHK_MMC_26M(sd_card) (CHK_MMC(sd_card) && \
- ((sd_card)->sd_type & MMC_26M))
-#define CHK_MMC_52M(sd_card) (CHK_MMC(sd_card) && \
- ((sd_card)->sd_type & MMC_52M))
-#define CHK_MMC_4BIT(sd_card) (CHK_MMC(sd_card) && \
- ((sd_card)->sd_type & MMC_4BIT))
-#define CHK_MMC_8BIT(sd_card) (CHK_MMC(sd_card) && \
- ((sd_card)->sd_type & MMC_8BIT))
-#define CHK_MMC_SECTOR_MODE(sd_card) (CHK_MMC(sd_card) && \
- ((sd_card)->sd_type & MMC_SECTOR_MODE))
-#define CHK_MMC_DDR52(sd_card) (CHK_MMC(sd_card) && \
- ((sd_card)->sd_type & MMC_DDR52))
+#define CHK_MMC_26M(sd_card)\
+ ({__auto_type _sd = sd_card; CHK_MMC(_sd) && \
+ (_sd->sd_type & MMC_26M); })
+#define CHK_MMC_52M(sd_card)\
+ ({__auto_type _sd = sd_card; CHK_MMC(_sd) && \
+ (_sd->sd_type & MMC_52M); })
+#define CHK_MMC_4BIT(sd_card)\
+ ({__auto_type _sd = sd_card; CHK_MMC(_sd) && \
+ (_sd->sd_type & MMC_4BIT); })
+#define CHK_MMC_8BIT(sd_card)\
+ ({__auto_type _sd = sd_card; CHK_MMC(_sd) && \
+ (_sd->sd_type & MMC_8BIT); })
+#define CHK_MMC_SECTOR_MODE(sd_card)\
+ ({__auto_type _sd = sd_card; CHK_MMC(_sd) && \
+ (_sd->sd_type & MMC_SECTOR_MODE); })
+#define CHK_MMC_DDR52(sd_card)\
+ ({__auto_type _sd = sd_card; CHK_MMC(_sd) && \
+ (_sd->sd_type & MMC_DDR52); })
#define SET_MMC(sd_card) ((sd_card)->sd_type = TYPE_MMC)
#define SET_MMC_26M(sd_card) ((sd_card)->sd_type |= MMC_26M)
@@ -448,8 +462,9 @@ struct zone_entry {
#define CLR_MMC_SECTOR_MODE(sd_card) ((sd_card)->sd_type &= ~MMC_SECTOR_MODE)
#define CLR_MMC_DDR52(sd_card) ((sd_card)->sd_type &= ~MMC_DDR52)
-#define CHK_MMC_HS(sd_card) (CHK_MMC_52M(sd_card) && \
- CHK_MMC_26M(sd_card))
+#define CHK_MMC_HS(sd_card)\
+ ({__auto_type _sd = sd_card; CHK_MMC_52M(_sd) && \
+ CHK_MMC_26M(_sd); })
#define CLR_MMC_HS(sd_card) \
do { \
CLR_MMC_DDR52(sd_card); \
@@ -560,12 +575,15 @@ struct xd_info {
#define HG8BIT (MS_HG | MS_8BIT)
#define CHK_MSPRO(ms_card) (((ms_card)->ms_type & 0xFF) == TYPE_MSPRO)
-#define CHK_HG8BIT(ms_card) (CHK_MSPRO(ms_card) && \
- (((ms_card)->ms_type & HG8BIT) == HG8BIT))
-#define CHK_MSXC(ms_card) (CHK_MSPRO(ms_card) && \
- ((ms_card)->ms_type & MS_XC))
-#define CHK_MSHG(ms_card) (CHK_MSPRO(ms_card) && \
- ((ms_card)->ms_type & MS_HG))
+#define CHK_HG8BIT(ms_card)\
+ ({__auto_type _ms = ms_card; CHK_MSPRO(_ms) && \
+ ((_ms->ms_type & HG8BIT) == HG8BIT); })
+#define CHK_MSXC(ms_card)\
+ ({__auto_type _ms = ms_card; CHK_MSPRO(_ms) && \
+ ((_ms)->ms_type & MS_XC); })
+#define CHK_MSHG(ms_card)\
+ ({__auto_type _ms = ms_card; CHK_MSPRO(_ms) && \
+ ((_ms)->ms_type & MS_HG); })
#define CHK_MS8BIT(ms_card) (((ms_card)->ms_type & MS_8BIT))
#define CHK_MS4BIT(ms_card) (((ms_card)->ms_type & MS_4BIT))
--
2.17.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rts5208: rewrite macro with GNU extension __auto_type
2019-11-04 16:44 [PATCH] staging: rts5208: rewrite macro with GNU extension __auto_type Jules Irenge
@ 2019-11-04 16:51 ` Greg KH
2019-11-04 17:07 ` Joe Perches
2019-11-05 11:09 ` Jules Irenge
0 siblings, 2 replies; 4+ messages in thread
From: Greg KH @ 2019-11-04 16:51 UTC (permalink / raw)
To: Jules Irenge; +Cc: devel, outreachy-kernel, linux-kernel
On Mon, Nov 04, 2019 at 04:44:00PM +0000, Jules Irenge wrote:
> Rewrite macro function with GNU extension __auto_type
> to remove issue detected by checkpatch tool.
> CHECK: MACRO argument reuse - possible side-effects?
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/staging/rts5208/rtsx_chip.h | 92 +++++++++++++++++------------
> 1 file changed, 55 insertions(+), 37 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx_chip.h b/drivers/staging/rts5208/rtsx_chip.h
> index bac65784d4a1..4b986d5c68da 100644
> --- a/drivers/staging/rts5208/rtsx_chip.h
> +++ b/drivers/staging/rts5208/rtsx_chip.h
> @@ -386,23 +386,31 @@ struct zone_entry {
>
> /* SD card */
> #define CHK_SD(sd_card) (((sd_card)->sd_type & 0xFF) == TYPE_SD)
> -#define CHK_SD_HS(sd_card) (CHK_SD(sd_card) && \
> - ((sd_card)->sd_type & SD_HS))
> -#define CHK_SD_SDR50(sd_card) (CHK_SD(sd_card) && \
> - ((sd_card)->sd_type & SD_SDR50))
> -#define CHK_SD_DDR50(sd_card) (CHK_SD(sd_card) && \
> - ((sd_card)->sd_type & SD_DDR50))
> -#define CHK_SD_SDR104(sd_card) (CHK_SD(sd_card) && \
> - ((sd_card)->sd_type & SD_SDR104))
> -#define CHK_SD_HCXC(sd_card) (CHK_SD(sd_card) && \
> - ((sd_card)->sd_type & SD_HCXC))
> -#define CHK_SD_HC(sd_card) (CHK_SD_HCXC(sd_card) && \
> - ((sd_card)->capacity <= 0x4000000))
> -#define CHK_SD_XC(sd_card) (CHK_SD_HCXC(sd_card) && \
> - ((sd_card)->capacity > 0x4000000))
> -#define CHK_SD30_SPEED(sd_card) (CHK_SD_SDR50(sd_card) || \
> - CHK_SD_DDR50(sd_card) || \
> - CHK_SD_SDR104(sd_card))
> +#define CHK_SD_HS(sd_card)\
> + ({__auto_type _sd = sd_card; CHK_SD(_sd) && \
> + (_sd->sd_type & SD_HS); })
> +#define CHK_SD_SDR50(sd_card)\
> + ({__auto_type _sd = sd_card; CHK_SD(_sd) && \
> + (_sd->sd_type & SD_SDR50); })
> +#define CHK_SD_DDR50(sd_card)\
> + ({__auto_type _sd = sd_card; CHK_SD(_sd) && \
> + (_sd->sd_type & SD_DDR50); })
> +#define CHK_SD_SDR104(sd_card)\
> + ({__auto_type _sd = sd_card; CHK_SD(_sd) && \
> + (_sd->sd_type & SD_SDR104); })
> +#define CHK_SD_HCXC(sd_card)\
> + ({__auto_type _sd = sd_card; CHK_SD(_sd) && \
> + (_sd->sd_type & SD_HCXC); })
> +#define CHK_SD_HC(sd_card)\
> + ({__auto_type _sd = sd_card; CHK_SD_HCXC(_sd) && \
> + (_sd->capacity <= 0x4000000); })
> +#define CHK_SD_XC(sd_card)\
> + ({__auto_type _sd = sd_card; CHK_SD_HCXC(_sd) && \
> + (_sd->capacity > 0x4000000); })
> +#define CHK_SD30_SPEED(sd_card)\
> + ({__auto_type _sd = sd_card; CHK_SD_SDR50(_sd) || \
> + CHK_SD_DDR50(_sd) || \
> + CHK_SD_SDR104(_sd); })
>
> #define SET_SD(sd_card) ((sd_card)->sd_type = TYPE_SD)
> #define SET_SD_HS(sd_card) ((sd_card)->sd_type |= SD_HS)
> @@ -420,18 +428,24 @@ struct zone_entry {
> /* MMC card */
> #define CHK_MMC(sd_card) (((sd_card)->sd_type & 0xFF) == \
> TYPE_MMC)
> -#define CHK_MMC_26M(sd_card) (CHK_MMC(sd_card) && \
> - ((sd_card)->sd_type & MMC_26M))
> -#define CHK_MMC_52M(sd_card) (CHK_MMC(sd_card) && \
> - ((sd_card)->sd_type & MMC_52M))
> -#define CHK_MMC_4BIT(sd_card) (CHK_MMC(sd_card) && \
> - ((sd_card)->sd_type & MMC_4BIT))
> -#define CHK_MMC_8BIT(sd_card) (CHK_MMC(sd_card) && \
> - ((sd_card)->sd_type & MMC_8BIT))
> -#define CHK_MMC_SECTOR_MODE(sd_card) (CHK_MMC(sd_card) && \
> - ((sd_card)->sd_type & MMC_SECTOR_MODE))
> -#define CHK_MMC_DDR52(sd_card) (CHK_MMC(sd_card) && \
> - ((sd_card)->sd_type & MMC_DDR52))
> +#define CHK_MMC_26M(sd_card)\
> + ({__auto_type _sd = sd_card; CHK_MMC(_sd) && \
> + (_sd->sd_type & MMC_26M); })
Ick, no. These are obviously pointers, which can not be "evaluated
twice" so this whole thing is just fine.
checkpatch is just a "hint" that you might want to look at the code.
This stuff is just fine, look at how it is being used for proof of that.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rts5208: rewrite macro with GNU extension __auto_type
2019-11-04 16:51 ` Greg KH
@ 2019-11-04 17:07 ` Joe Perches
2019-11-05 11:09 ` Jules Irenge
1 sibling, 0 replies; 4+ messages in thread
From: Joe Perches @ 2019-11-04 17:07 UTC (permalink / raw)
To: Greg KH, Jules Irenge; +Cc: devel, outreachy-kernel, linux-kernel
On Mon, 2019-11-04 at 17:51 +0100, Greg KH wrote:
> On Mon, Nov 04, 2019 at 04:44:00PM +0000, Jules Irenge wrote:
> > Rewrite macro function with GNU extension __auto_type
> > to remove issue detected by checkpatch tool.
> > CHECK: MACRO argument reuse - possible side-effects?
[]
> > diff --git a/drivers/staging/rts5208/rtsx_chip.h b/drivers/staging/rts5208/rtsx_chip.h
[]
> > @@ -386,23 +386,31 @@ struct zone_entry {
> >
> > /* SD card */
> > #define CHK_SD(sd_card) (((sd_card)->sd_type & 0xFF) == TYPE_SD)
> > -#define CHK_SD_HS(sd_card) (CHK_SD(sd_card) && \
> > - ((sd_card)->sd_type & SD_HS))
[]
> > +#define CHK_SD_HS(sd_card)\
> > + ({__auto_type _sd = sd_card; CHK_SD(_sd) && \
> > + (_sd->sd_type & SD_HS); })
[]
> Ick, no. These are obviously pointers, which can not be "evaluated
> twice" so this whole thing is just fine.
>
> checkpatch is just a "hint" that you might want to look at the code.
> This stuff is just fine, look at how it is being used for proof of that.
This would also be the first introduction and use of
__auto_type in the kernel.
That's not OK as __auto_type was first supported in
gcc 4.9 and the kernel still compiles with gcc 4.6.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rts5208: rewrite macro with GNU extension __auto_type
2019-11-04 16:51 ` Greg KH
2019-11-04 17:07 ` Joe Perches
@ 2019-11-05 11:09 ` Jules Irenge
1 sibling, 0 replies; 4+ messages in thread
From: Jules Irenge @ 2019-11-05 11:09 UTC (permalink / raw)
To: Greg KH; +Cc: devel, outreachy-kernel, Jules Irenge, linux-kernel
On Mon, 4 Nov 2019, Greg KH wrote:
> On Mon, Nov 04, 2019 at 04:44:00PM +0000, Jules Irenge wrote:
> > Rewrite macro function with GNU extension __auto_type
> > to remove issue detected by checkpatch tool.
> > CHECK: MACRO argument reuse - possible side-effects?
> >
> > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> > ---
> > drivers/staging/rts5208/rtsx_chip.h | 92 +++++++++++++++++------------
> > 1 file changed, 55 insertions(+), 37 deletions(-)
> >
> > diff --git a/drivers/staging/rts5208/rtsx_chip.h b/drivers/staging/rts5208/rtsx_chip.h
> > index bac65784d4a1..4b986d5c68da 100644
> > --- a/drivers/staging/rts5208/rtsx_chip.h
> > +++ b/drivers/staging/rts5208/rtsx_chip.h
> > @@ -386,23 +386,31 @@ struct zone_entry {
> >
> > /* SD card */
> > #define CHK_SD(sd_card) (((sd_card)->sd_type & 0xFF) == TYPE_SD)
> > -#define CHK_SD_HS(sd_card) (CHK_SD(sd_card) && \
> > - ((sd_card)->sd_type & SD_HS))
> > -#define CHK_SD_SDR50(sd_card) (CHK_SD(sd_card) && \
> > - ((sd_card)->sd_type & SD_SDR50))
> > -#define CHK_SD_DDR50(sd_card) (CHK_SD(sd_card) && \
> > - ((sd_card)->sd_type & SD_DDR50))
> > -#define CHK_SD_SDR104(sd_card) (CHK_SD(sd_card) && \
> > - ((sd_card)->sd_type & SD_SDR104))
> > -#define CHK_SD_HCXC(sd_card) (CHK_SD(sd_card) && \
> > - ((sd_card)->sd_type & SD_HCXC))
> > -#define CHK_SD_HC(sd_card) (CHK_SD_HCXC(sd_card) && \
> > - ((sd_card)->capacity <= 0x4000000))
> > -#define CHK_SD_XC(sd_card) (CHK_SD_HCXC(sd_card) && \
> > - ((sd_card)->capacity > 0x4000000))
> > -#define CHK_SD30_SPEED(sd_card) (CHK_SD_SDR50(sd_card) || \
> > - CHK_SD_DDR50(sd_card) || \
> > - CHK_SD_SDR104(sd_card))
> > +#define CHK_SD_HS(sd_card)\
> > + ({__auto_type _sd = sd_card; CHK_SD(_sd) && \
> > + (_sd->sd_type & SD_HS); })
> > +#define CHK_SD_SDR50(sd_card)\
> > + ({__auto_type _sd = sd_card; CHK_SD(_sd) && \
> > + (_sd->sd_type & SD_SDR50); })
> > +#define CHK_SD_DDR50(sd_card)\
> > + ({__auto_type _sd = sd_card; CHK_SD(_sd) && \
> > + (_sd->sd_type & SD_DDR50); })
> > +#define CHK_SD_SDR104(sd_card)\
> > + ({__auto_type _sd = sd_card; CHK_SD(_sd) && \
> > + (_sd->sd_type & SD_SDR104); })
> > +#define CHK_SD_HCXC(sd_card)\
> > + ({__auto_type _sd = sd_card; CHK_SD(_sd) && \
> > + (_sd->sd_type & SD_HCXC); })
> > +#define CHK_SD_HC(sd_card)\
> > + ({__auto_type _sd = sd_card; CHK_SD_HCXC(_sd) && \
> > + (_sd->capacity <= 0x4000000); })
> > +#define CHK_SD_XC(sd_card)\
> > + ({__auto_type _sd = sd_card; CHK_SD_HCXC(_sd) && \
> > + (_sd->capacity > 0x4000000); })
> > +#define CHK_SD30_SPEED(sd_card)\
> > + ({__auto_type _sd = sd_card; CHK_SD_SDR50(_sd) || \
> > + CHK_SD_DDR50(_sd) || \
> > + CHK_SD_SDR104(_sd); })
> >
> > #define SET_SD(sd_card) ((sd_card)->sd_type = TYPE_SD)
> > #define SET_SD_HS(sd_card) ((sd_card)->sd_type |= SD_HS)
> > @@ -420,18 +428,24 @@ struct zone_entry {
> > /* MMC card */
> > #define CHK_MMC(sd_card) (((sd_card)->sd_type & 0xFF) == \
> > TYPE_MMC)
> > -#define CHK_MMC_26M(sd_card) (CHK_MMC(sd_card) && \
> > - ((sd_card)->sd_type & MMC_26M))
> > -#define CHK_MMC_52M(sd_card) (CHK_MMC(sd_card) && \
> > - ((sd_card)->sd_type & MMC_52M))
> > -#define CHK_MMC_4BIT(sd_card) (CHK_MMC(sd_card) && \
> > - ((sd_card)->sd_type & MMC_4BIT))
> > -#define CHK_MMC_8BIT(sd_card) (CHK_MMC(sd_card) && \
> > - ((sd_card)->sd_type & MMC_8BIT))
> > -#define CHK_MMC_SECTOR_MODE(sd_card) (CHK_MMC(sd_card) && \
> > - ((sd_card)->sd_type & MMC_SECTOR_MODE))
> > -#define CHK_MMC_DDR52(sd_card) (CHK_MMC(sd_card) && \
> > - ((sd_card)->sd_type & MMC_DDR52))
> > +#define CHK_MMC_26M(sd_card)\
> > + ({__auto_type _sd = sd_card; CHK_MMC(_sd) && \
> > + (_sd->sd_type & MMC_26M); })
>
> Ick, no. These are obviously pointers, which can not be "evaluated
> twice" so this whole thing is just fine.
>
> checkpatch is just a "hint" that you might want to look at the code.
> This stuff is just fine, look at how it is being used for proof of that.
>
> thanks,
>
> greg k-h
>
Thanks for the feedback. It's good to know. I really appreciate.
Kind regards,
Jules
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-05 11:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-04 16:44 [PATCH] staging: rts5208: rewrite macro with GNU extension __auto_type Jules Irenge
2019-11-04 16:51 ` Greg KH
2019-11-04 17:07 ` Joe Perches
2019-11-05 11:09 ` Jules Irenge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).