From: Matthew Wilcox <willy@infradead.org>
To: Valery Ivanov <ivalery111@gmail.com>,
Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, wambui.karugax@gmail.com
Subject: Re: [PATCH v2] staging: octeon: fix missing a blank line after declaration
Date: Fri, 8 Nov 2019 07:01:41 -0800 [thread overview]
Message-ID: <20191108150141.GG11823@bombadil.infradead.org> (raw)
In-Reply-To: <20191108142329.GA3192@hwsrv-485799.hostwindsdns.com>
I would like to reiterate my opinion that this checkpatch warning is
bullshit. For large functions, sure. For this kind of function, it's
a waste of space.
On Fri, Nov 08, 2019 at 02:23:29PM +0000, Valery Ivanov wrote:
> This patch fixes "WARNING: Missing a blank line after declarations"
> Issue found by checkpatch.pl
>
> Signed-off-by: Valery Ivanov <ivalery111@gmail.com>
> ---
> Changes in v2:
> - fix huge indentation in commit message
> ---
> drivers/staging/octeon/octeon-stubs.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
> index d53bd801f440..ed9d44ff148b 100644
> --- a/drivers/staging/octeon/octeon-stubs.h
> +++ b/drivers/staging/octeon/octeon-stubs.h
> @@ -1375,6 +1375,7 @@ static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(
> int port)
> {
> union cvmx_gmxx_rxx_rx_inbnd r;
> +
> r.u64 = 0;
> return r;
> }
> --
> 2.17.1
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2019-11-08 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 14:23 [PATCH v2] staging: octeon: fix missing a blank line after declaration Valery Ivanov
2019-11-08 15:01 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108150141.GG11823@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=apw@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=ivalery111@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wambui.karugax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).