DriverDev-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: "René van Dorst" <opensource@vdorst.com>
Cc: devel@driverdev.osuosl.org, Weijie Gao <hackpascal@gmail.com>,
	gregkh@linuxfoundation.org,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	linux-kernel@vger.kernel.org, neil@brown.name, gerg@kernel.org,
	linux-mediatek@lists.infradead.org,
	Richard Weinberger <richard@nod.at>,
	DENG Qingfang <dengqf6@mail2.sysu.edu.cn>,
	linux-mtd@lists.infradead.org, blogic@openwrt.org
Subject: Re: [PATCH] mtd: rawnand: driver for Mediatek MT7621 SoC NAND flash controller
Date: Sun, 10 Nov 2019 12:35:31 +0100
Message-ID: <20191110123531.5a27206a@collabora.com> (raw)
In-Reply-To: <20191107092053.Horde.i3MVcW9RqZDOQBMADZX9fuc@www.vdorst.com>

+Richard and Miquel

On Thu, 07 Nov 2019 09:20:53 +0000
René van Dorst <opensource@vdorst.com> wrote:

> Quoting gerg@kernel.org:
> 
> > From: Greg Ungerer <gerg@kernel.org>
> >
> > Add a driver to support the NAND flash controller of the MediaTek MT7621
> > System-on-Chip device. (This one is the MIPS based parts from Mediatek).
> >
> > This code is a re-working of the earlier patches for this hardware that
> > have been floating around the internet for years:
> >
> > https://github.com/ReclaimYourPrivacy/cloak/blob/master/target/linux/ramips/patches-3.18/0045-mtd-add-mt7621-nand-support.patch
> >
> > This is a much cleaned up version, put in staging to start with.
> > It does still have some problems, mainly that it still uses a lot of the
> > mtd raw nand legacy support.
> >
> > The driver not only compiles, but it works well on the small range of
> > hardware platforms that it has been used on so far. I have been using
> > for quite a while now, cleaning up as I get time.
> >
> > So... I am looking for comments on the best approach forward with this.
> > At least in staging it can get some more eyeballs going over it.
> >
> > There is a mediatek nand driver already, mtk_nand.c, for their ARM based
> > System-on-Chip devices. That hardware module looks to have some hardware
> > similarities with this one. At this point I don't know if that can be
> > used on the 7621 based devices. (I tried a quick and dirty setup and had
> > no success using it on the 7621).
> >
> > Thoughts?  
> 
> +CC DENG Qingfang, Chuanhong Guo, Weijie Gao to the list.
> 
> Hi Greg,
> 
> Thanks for posting this driver.
> 
> But I would like to mention that the openwrt community is currently  
> working on a
> new version which is based a newer version of the MediaTek vendor driver.
> That version is currently targeted for the openwrt 4.19 kernel.
> See full pull request [1] and NAND driver patch [2]
> 
> It would be a shame if duplicate work has been done.

Sorry, but if there's duplicate effort that's kinda your (OpenWRT folks)
fault: since when OpenWRT is the central point for kernel drivers?
Correct me if I'm wrong, but I don't remember seeing this driver posted
to the MTD ML. Plus, the driver you're pointing to still implements the
legacy hooks and is based on 4.19, and it has been decided that all new
NAND controller drivers should implement the new ->exec_op() hook
instead.

> 
> Greats,
> 
> René
> 
> [1]: https://github.com/openwrt/openwrt/pull/2385
> [2]:  
> https://github.com/openwrt/openwrt/pull/2385/commits/b2569c0a5943fe8f94ba07c9540ecd14006d729a
> 
> <snip>
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  parent reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07  7:35 gerg
2019-11-07  8:40 ` Greg KH
2019-11-08  4:34   ` Greg Ungerer
2019-11-10 11:39   ` Boris Brezillon
2019-11-10 12:22     ` Boris Brezillon
2019-11-07  9:20 ` René van Dorst
2019-11-08  4:46   ` Greg Ungerer
2019-11-10 11:35   ` Boris Brezillon [this message]
2019-11-10 17:37     ` Andrey Jr. Melnikov
2019-11-07 11:15 ` Dan Carpenter
2019-11-08  6:16   ` Greg Ungerer

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191110123531.5a27206a@collabora.com \
    --to=boris.brezillon@collabora.com \
    --cc=blogic@openwrt.org \
    --cc=dengqf6@mail2.sysu.edu.cn \
    --cc=devel@driverdev.osuosl.org \
    --cc=gerg@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hackpascal@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=neil@brown.name \
    --cc=opensource@vdorst.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DriverDev-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/driverdev-devel/0 driverdev-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 driverdev-devel driverdev-devel/ https://lore.kernel.org/driverdev-devel \
		driverdev-devel@linuxdriverproject.org devel@driverdev.osuosl.org
	public-inbox-index driverdev-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxdriverproject.driverdev-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git