From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE0A1C43215 for ; Fri, 15 Nov 2019 16:49:55 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C19A220723 for ; Fri, 15 Nov 2019 16:49:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QYMnEMQd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C19A220723 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 936A38939C; Fri, 15 Nov 2019 16:49:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8qg2ggFwf3Tm; Fri, 15 Nov 2019 16:49:52 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id EC43F89395; Fri, 15 Nov 2019 16:49:51 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 2FB1C1BF2CB for ; Fri, 15 Nov 2019 16:49:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 2C9A386451 for ; Fri, 15 Nov 2019 16:49:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5sFj-eV6y_Iw for ; Fri, 15 Nov 2019 16:49:49 +0000 (UTC) X-Greylist: delayed 11:10:46 by SQLgrey-1.7.6 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 1CB8886449 for ; Fri, 15 Nov 2019 16:49:49 +0000 (UTC) Received: by mail-pl1-f193.google.com with SMTP id e3so5033552plt.7 for ; Fri, 15 Nov 2019 08:49:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ptqDM2bmHnot4adtaFSv3VaRZd83rjxzM9yPEL0ZiVQ=; b=QYMnEMQdAAVP1ErDUxIsFQ6DlszLOn9whrvq/Y2SkMm3zbUFH+xz7ZikY3RfYWSyFL CgLAPq64BHMWfuyf6WB4hq42WvHXD1+xlybGrdxKdVwbyB7Goxz+ZSO9LU3F6eWD2L5g ONFqp4+EO1xyjzoG/IdQWW4dq6e9+ckLUvZjQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ptqDM2bmHnot4adtaFSv3VaRZd83rjxzM9yPEL0ZiVQ=; b=qONU0uetjxAemiKRbmEyMIU7QD+wLMwfekmnsgjzy5b9pVeAgZURlIpUFrYP+xu9oW 4pzLBPcKs8jLqwLSu4RK0yGQZ/K+iD3+1teWt49jnw9UoU4BBWTyEThvDsIOwWQCk2fD /y9wgm1sK67F8pKksyXlzjEaZiuHxiEmAtcaPF1T9JJmv/hWfcm3DuWfk21KEU4BGIXE uEcY4UVc/z8ApApZUfEizCfi0WReDpfj2CuKFcpABQowjsEFfr0bY3+vxEOImCnhpKtp Lnvg44AXMLG1q/cSnmzXt1yCUbELNR/no4l5Ac/R59ZopNjavO0N5YYQ7efYzha+1V8E SSlg== X-Gm-Message-State: APjAAAURRZDzus+RAQU9bHY+ktGZZJE+88hU4OxQ1SKbhbfBWDF1B78D jYkD08erVm0F+MoMzL7ENur5fpvmFMM= X-Google-Smtp-Source: APXvYqx05o7Lzkd/xkkJdoxu2DTq4WyYxecLtO0mGNyWyc+EB6il/XJ0N+kSYVGwAcNEssnj4S4clA== X-Received: by 2002:a17:902:6903:: with SMTP id j3mr7357486plk.231.1573836588247; Fri, 15 Nov 2019 08:49:48 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x29sm11756518pfj.131.2019.11.15.08.49.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2019 08:49:47 -0800 (PST) Date: Fri, 15 Nov 2019 08:49:24 -0800 From: Kees Cook To: Greg Kroah-Hartman Subject: Re: [PATCH] staging: rtl*: Remove tasklet callback casts Message-ID: <201911150848.4518DFCA1@keescook> References: <201911142135.5656E23@keescook> <20191115061610.GA1034830@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191115061610.GA1034830@kroah.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Florian Schilhabel , kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org, Romain Perier , Larry Finger Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Fri, Nov 15, 2019 at 02:16:10PM +0800, Greg Kroah-Hartman wrote: > On Thu, Nov 14, 2019 at 09:39:00PM -0800, Kees Cook wrote: > > In order to make the entire kernel usable under Clang's Control Flow > > Integrity protections, function prototype casts need to be avoided > > because this will trip CFI checks at runtime (i.e. a mismatch between > > the caller's expected function prototype and the destination function's > > prototype). Many of these cases can be found with -Wcast-function-type, > > which found that the rtl wifi drivers had a bunch of needless function > > casts. Remove function casts for tasklet callbacks in the various drivers. > > > > Signed-off-by: Kees Cook > > --- > > drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 3 +-- > > drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 3 +-- > > drivers/staging/rtl8188eu/include/rtl8188e_recv.h | 2 +- > > drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 2 +- > > drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 4 ++-- > > drivers/staging/rtl8192e/rtllib_softmac.c | 7 +++---- > > .../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 7 +++---- > > drivers/staging/rtl8192u/r8192U_core.c | 8 ++++---- > > drivers/staging/rtl8712/rtl8712_recv.c | 11 +++++------ > > drivers/staging/rtl8712/rtl871x_xmit.c | 5 ++--- > > drivers/staging/rtl8712/rtl871x_xmit.h | 2 +- > > drivers/staging/rtl8712/usb_ops_linux.c | 4 ++-- > > drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 11 ++++------- > > 13 files changed, 30 insertions(+), 39 deletions(-) > > This fails to apply to my staging-next branch of staging.git. Can you > rebase and resend? Ah, hrm, sorry. I think I was based on Linus's master. I will adjust! -- Kees Cook _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel