DriverDev-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] staging: octeon: indent with tabs instead of spaces
@ 2019-11-18 18:38 Giovanni Gherdovich
  2019-11-18 19:01 ` Dan Carpenter
  0 siblings, 1 reply; 2+ messages in thread
From: Giovanni Gherdovich @ 2019-11-18 18:38 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: devel, Giovanni Gherdovich, linux-kernel, Aaro Koskinen

Remove a coding style error from the Octeon driver's tree and keep
checkpatch.pl a little quieter.

Being a white-spaces patch the chances of breakage are minimal; we don't
have the hardware to run this driver so we built it with COMPILE_TEST
enabled on an x86 machine.

Signed-off-by: Giovanni Gherdovich <bobdc9664@seznam.cz>
---
 drivers/staging/octeon/octeon-stubs.h | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index ed9d44ff148b..79213c045504 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -1140,22 +1140,22 @@ union cvmx_npi_rsl_int_blocks {
 union cvmx_pko_command_word0 {
 	uint64_t u64;
 	struct {
-	        uint64_t total_bytes:16;
-	        uint64_t segs:6;
-	        uint64_t dontfree:1;
-	        uint64_t ignore_i:1;
-	        uint64_t ipoffp1:7;
-	        uint64_t gather:1;
-	        uint64_t rsp:1;
-	        uint64_t wqp:1;
-	        uint64_t n2:1;
-	        uint64_t le:1;
-	        uint64_t reg0:11;
-	        uint64_t subone0:1;
-	        uint64_t reg1:11;
-	        uint64_t subone1:1;
-	        uint64_t size0:2;
-	        uint64_t size1:2;
+		uint64_t total_bytes:16;
+		uint64_t segs:6;
+		uint64_t dontfree:1;
+		uint64_t ignore_i:1;
+		uint64_t ipoffp1:7;
+		uint64_t gather:1;
+		uint64_t rsp:1;
+		uint64_t wqp:1;
+		uint64_t n2:1;
+		uint64_t le:1;
+		uint64_t reg0:11;
+		uint64_t subone0:1;
+		uint64_t reg1:11;
+		uint64_t subone1:1;
+		uint64_t size0:2;
+		uint64_t size1:2;
 	} s;
 };
 
-- 
2.16.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: octeon: indent with tabs instead of spaces
  2019-11-18 18:38 [PATCH] staging: octeon: indent with tabs instead of spaces Giovanni Gherdovich
@ 2019-11-18 19:01 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2019-11-18 19:01 UTC (permalink / raw)
  To: Giovanni Gherdovich
  Cc: devel, Greg Kroah-Hartman, linux-kernel, Aaro Koskinen

On Mon, Nov 18, 2019 at 07:38:52PM +0100, Giovanni Gherdovich wrote:
> Remove a coding style error from the Octeon driver's tree and keep
> checkpatch.pl a little quieter.
> 
> Being a white-spaces patch the chances of breakage are minimal; we don't
> have the hardware to run this driver so we built it with COMPILE_TEST
> enabled on an x86 machine.

Next time put this sort of comment under the --- cut off line so that we
sound like we're bursting with confidence in the permanent git log.  ;)

> 
> Signed-off-by: Giovanni Gherdovich <bobdc9664@seznam.cz>
> ---
  ^^^

>  drivers/staging/octeon/octeon-stubs.h | 32 ++++++++++++++++----------------
>  1 file changed, 16 insertions(+), 16 deletions(-)

Anyway, looks good.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 18:38 [PATCH] staging: octeon: indent with tabs instead of spaces Giovanni Gherdovich
2019-11-18 19:01 ` Dan Carpenter

DriverDev-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/driverdev-devel/0 driverdev-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 driverdev-devel driverdev-devel/ https://lore.kernel.org/driverdev-devel \
		driverdev-devel@linuxdriverproject.org devel@driverdev.osuosl.org
	public-inbox-index driverdev-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxdriverproject.driverdev-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git