DriverDev-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v1 1/1] staging: rtl8192e: rename camelcase variable 'ShortData'
@ 2019-11-27 18:13 Travis Davies
  2019-11-28  4:37 ` Dan Carpenter
  0 siblings, 1 reply; 2+ messages in thread
From: Travis Davies @ 2019-11-27 18:13 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Himadri Pandya, YueHaibing; +Cc: devel

This patch renames camelcase variable 'ShortData' to 'short_data' 
Fixes checkpatch message 'CHECK: Avoid CamelCase: <ShortData>

Signed-off-by: Travis Davies <tdavies@darkphysics.net>

---
 drivers/staging/rtl8192e/rtl819x_BA.h     | 2 +-
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h b/drivers/staging/rtl8192e/rtl819x_BA.h
index 8b6e4c26f0fb..34d66b8f5155 100644
--- a/drivers/staging/rtl8192e/rtl819x_BA.h
+++ b/drivers/staging/rtl8192e/rtl819x_BA.h
@@ -20,7 +20,7 @@
 #define	DELBA_REASON_UNKNOWN_BA	38
 #define	DELBA_REASON_TIMEOUT			39
 union sequence_control {
-	u16 ShortData;
+	u16 short_data;
 	struct {
 		u16	FragNum:4;
 		u16	SeqNum:12;
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 816d31c1d5c7..4d3dac55e189 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -61,7 +61,7 @@ void ResetBaEntry(struct ba_record *pBA)
 	pBA->BaParamSet.shortData	= 0;
 	pBA->BaTimeoutValue		= 0;
 	pBA->DialogToken		= 0;
-	pBA->BaStartSeqCtrl.ShortData	= 0;
+	pBA->BaStartSeqCtrl.short_data	= 0;
 }
 static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst,
 				    struct ba_record *pBA,
-- 
2.21.0

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v1 1/1] staging: rtl8192e: rename camelcase variable 'ShortData'
  2019-11-27 18:13 [PATCH v1 1/1] staging: rtl8192e: rename camelcase variable 'ShortData' Travis Davies
@ 2019-11-28  4:37 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2019-11-28  4:37 UTC (permalink / raw)
  To: Travis Davies; +Cc: devel, Greg Kroah-Hartman, YueHaibing

On Wed, Nov 27, 2019 at 10:13:31AM -0800, Travis Davies wrote:
> This patch renames camelcase variable 'ShortData' to 'short_data' 
> Fixes checkpatch message 'CHECK: Avoid CamelCase: <ShortData>
> 
> Signed-off-by: Travis Davies <tdavies@darkphysics.net>
> 
> ---
>  drivers/staging/rtl8192e/rtl819x_BA.h     | 2 +-
>  drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h b/drivers/staging/rtl8192e/rtl819x_BA.h
> index 8b6e4c26f0fb..34d66b8f5155 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BA.h
> +++ b/drivers/staging/rtl8192e/rtl819x_BA.h
> @@ -20,7 +20,7 @@
>  #define	DELBA_REASON_UNKNOWN_BA	38
>  #define	DELBA_REASON_TIMEOUT			39
>  union sequence_control {
> -	u16 ShortData;
> +	u16 short_data;
>  	struct {
>  		u16	FragNum:4;
>  		u16	SeqNum:12;
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index 816d31c1d5c7..4d3dac55e189 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -61,7 +61,7 @@ void ResetBaEntry(struct ba_record *pBA)
>  	pBA->BaParamSet.shortData	= 0;
>  	pBA->BaTimeoutValue		= 0;
>  	pBA->DialogToken		= 0;
> -	pBA->BaStartSeqCtrl.ShortData	= 0;
> +	pBA->BaStartSeqCtrl.short_data	= 0;

What does the name short data mean?  It seems like this is not used
anywhere or the patch would cause a compile error.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-27 18:13 [PATCH v1 1/1] staging: rtl8192e: rename camelcase variable 'ShortData' Travis Davies
2019-11-28  4:37 ` Dan Carpenter

DriverDev-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/driverdev-devel/0 driverdev-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 driverdev-devel driverdev-devel/ https://lore.kernel.org/driverdev-devel \
		driverdev-devel@linuxdriverproject.org devel@driverdev.osuosl.org
	public-inbox-index driverdev-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxdriverproject.driverdev-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git