DriverDev-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Christian Gromm <christian.gromm@microchip.com>
Cc: driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH RFC 2/6] staging: most: rename core.h to most.h
Date: Fri, 6 Dec 2019 15:35:28 +0100
Message-ID: <20191206143528.GA32126@kroah.com> (raw)
In-Reply-To: <1574697096-2942-3-git-send-email-christian.gromm@microchip.com>

On Mon, Nov 25, 2019 at 04:51:32PM +0100, Christian Gromm wrote:
> This patch renames the core header file core.h to most.h. The intention
> behind this is to have a meaningful name once this file is moved to the
> /include/linux directory.

Does everything in this .h file have to be exposed to the whole kernel?
Are there any things in here that are local only to the most "core"
code?

If this whole thing is public, you might want to clean up your naming of
some structures:

> +enum mbo_status_flags {

enum most_buffer_status_flags?


> +struct mbo {

struct most_buffer_object?

> +struct core_component {

struct most_core_component?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25 15:51 [PATCH RFC 0/6] staging: most: move core module out of staging area Christian Gromm
2019-11-25 15:51 ` [PATCH RFC 1/6] staging: most: fix improper SPDX-License comment style Christian Gromm
2019-11-25 15:51 ` [PATCH RFC 2/6] staging: most: rename core.h to most.h Christian Gromm
2019-12-06 14:35   ` Greg KH [this message]
2019-12-09 13:25     ` Christian.Gromm
2019-12-10  9:42       ` Greg KH
2019-11-25 15:51 ` [PATCH RFC 3/6] staging: most: use angle brackets in include path Christian Gromm
2019-11-25 15:51 ` [PATCH RFC 4/6] staging: most: move core files out of the staging area Christian Gromm
2019-12-06 14:35   ` Greg KH
2019-11-25 15:51 ` [PATCH RFC 5/6] staging: most: Documentation: update ABI description Christian Gromm
2019-11-25 15:51 ` [PATCH RFC 6/6] staging: most: Documentation: move ABI description files out of staging area Christian Gromm

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191206143528.GA32126@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=christian.gromm@microchip.com \
    --cc=driverdev-devel@linuxdriverproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DriverDev-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/driverdev-devel/0 driverdev-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 driverdev-devel driverdev-devel/ https://lore.kernel.org/driverdev-devel \
		driverdev-devel@linuxdriverproject.org devel@driverdev.osuosl.org
	public-inbox-index driverdev-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxdriverproject.driverdev-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git