From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31AA3C4332D for ; Thu, 19 Mar 2020 17:48:17 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 043C520754 for ; Thu, 19 Mar 2020 17:48:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="cDHAcd1C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 043C520754 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id D3C1786D9B; Thu, 19 Mar 2020 17:48:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p4P4pmS5Ms64; Thu, 19 Mar 2020 17:48:15 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 06E6C86D8D; Thu, 19 Mar 2020 17:48:15 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 9FE5D1BF20B for ; Thu, 19 Mar 2020 17:48:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 9C40C88189 for ; Thu, 19 Mar 2020 17:48:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OWpVDdxV01R3 for ; Thu, 19 Mar 2020 17:48:11 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by hemlock.osuosl.org (Postfix) with ESMTPS id 8BD4D88187 for ; Thu, 19 Mar 2020 17:48:11 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 18F68DC4; Thu, 19 Mar 2020 18:48:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1584640088; bh=muRfNh5vu7uoti9IKGxoYTDOSnB1SG2YiU3akIX1p/0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cDHAcd1CttFh1TV6F8AOFaQM8f/vHXwI08QWjwTnH1LKoh4ajd0MNenKWprm45YMj ZKY8mCezz94b7mV0DOtsNC9tYj63WmdxfLlEEtGDCY0/UUbaA+cY0vWguUYAzRdc7u 2+MDgK7xO3tQUNYW0YrS32+Q13zWmyxsyNOMuTLg= Date: Thu, 19 Mar 2020 19:48:02 +0200 From: Laurent Pinchart To: Alex Riesen Subject: Re: [PATCH v2 02/10] media: adv748x: include everything adv748x.h needs into the file Message-ID: <20200319174802.GH14585@pendragon.ideasonboard.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devel@driverdev.osuosl.org, Kuninori Morimoto , devicetree@vger.kernel.org, Kieran Bingham , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Rob Herring , Geert Uytterhoeven , Hans Verkuil , Mauro Carvalho Chehab , linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi Alexander, Thank you for the patch. On Thu, Mar 19, 2020 at 06:41:48PM +0100, Alex Riesen wrote: > To follow the established practice of not depending on others to > pull everything in. > > Signed-off-by: Alexander Riesen Good idea. While at it, could you include "adv748x.h" as the very first header in at least one of the C files ? That will help ensuring the header stays self-contained in the future. > --- > drivers/media/i2c/adv748x/adv748x-afe.c | 2 -- > drivers/media/i2c/adv748x/adv748x-core.c | 2 -- > drivers/media/i2c/adv748x/adv748x-csi2.c | 2 -- > drivers/media/i2c/adv748x/adv748x-hdmi.c | 2 -- > drivers/media/i2c/adv748x/adv748x.h | 2 ++ > 5 files changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/media/i2c/adv748x/adv748x-afe.c b/drivers/media/i2c/adv748x/adv748x-afe.c > index dbbb1e4d6363..ab0479641c10 100644 > --- a/drivers/media/i2c/adv748x/adv748x-afe.c > +++ b/drivers/media/i2c/adv748x/adv748x-afe.c > @@ -11,8 +11,6 @@ > #include > #include > > -#include > -#include > #include > #include > > diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c > index c3fb113cef62..345f009de121 100644 > --- a/drivers/media/i2c/adv748x/adv748x-core.c > +++ b/drivers/media/i2c/adv748x/adv748x-core.c > @@ -20,8 +20,6 @@ > #include > #include > > -#include > -#include > #include > #include > #include > diff --git a/drivers/media/i2c/adv748x/adv748x-csi2.c b/drivers/media/i2c/adv748x/adv748x-csi2.c > index c43ce5d78723..78d391009b5a 100644 > --- a/drivers/media/i2c/adv748x/adv748x-csi2.c > +++ b/drivers/media/i2c/adv748x/adv748x-csi2.c > @@ -8,8 +8,6 @@ > #include > #include > > -#include > -#include > #include > > #include "adv748x.h" > diff --git a/drivers/media/i2c/adv748x/adv748x-hdmi.c b/drivers/media/i2c/adv748x/adv748x-hdmi.c > index c557f8fdf11a..0dffcdf79ff2 100644 > --- a/drivers/media/i2c/adv748x/adv748x-hdmi.c > +++ b/drivers/media/i2c/adv748x/adv748x-hdmi.c > @@ -8,8 +8,6 @@ > #include > #include > > -#include > -#include > #include > #include > > diff --git a/drivers/media/i2c/adv748x/adv748x.h b/drivers/media/i2c/adv748x/adv748x.h > index fccb388ce179..09aab4138c3f 100644 > --- a/drivers/media/i2c/adv748x/adv748x.h > +++ b/drivers/media/i2c/adv748x/adv748x.h > @@ -19,6 +19,8 @@ > */ > > #include > +#include > +#include > > #ifndef _ADV748X_H_ > #define _ADV748X_H_ -- Regards, Laurent Pinchart _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel