From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6077C4332D for ; Thu, 19 Mar 2020 18:03:42 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D9B820789 for ; Thu, 19 Mar 2020 18:03:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="bLh0NBaz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D9B820789 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 5C1E38733E; Thu, 19 Mar 2020 18:03:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Tvb8-dliMtRd; Thu, 19 Mar 2020 18:03:41 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 1D01486DB2; Thu, 19 Mar 2020 18:03:41 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id D75441BF28A for ; Thu, 19 Mar 2020 18:03:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id D282686D0F for ; Thu, 19 Mar 2020 18:03:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XSYh_HEdz31n for ; Thu, 19 Mar 2020 18:03:39 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 17AEA86C34 for ; Thu, 19 Mar 2020 18:03:39 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 62F70A53; Thu, 19 Mar 2020 19:03:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1584641017; bh=HOUY95IFrKZRKfGjSsw5sMRF6MP3fYQPa1epjOauYxc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bLh0NBazFtysSiu+BJPR6fz6MWHFcZR2o8u4zE9vDkPwTVmMO43hTlNOyGXql5p46 34EPnvnwtuOFc0/5U/0U5lQM07k0buTa0E1aKTA4q0la/oEy4tDjuArHbAEkSJXwM2 hnWsc+pls1DSNxhrkqjTgE3a0M3QfQCIXRuT+xzQ= Date: Thu, 19 Mar 2020 20:03:31 +0200 From: Laurent Pinchart To: Alex Riesen Subject: Re: [PATCH v2 01/10] media: adv748x: fix end-of-line terminators in diagnostic statements Message-ID: <20200319180331.GK14585@pendragon.ideasonboard.com> References: <5272d873b4daf8b0bdb8aff81b08ab3508da9567.1584639664.git.alexander.riesen@cetitec.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5272d873b4daf8b0bdb8aff81b08ab3508da9567.1584639664.git.alexander.riesen@cetitec.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devel@driverdev.osuosl.org, Kuninori Morimoto , devicetree@vger.kernel.org, Kieran Bingham , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Rob Herring , Geert Uytterhoeven , Hans Verkuil , Mauro Carvalho Chehab , linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi Alex, Thank you for the patch. On Thu, Mar 19, 2020 at 06:41:43PM +0100, Alex Riesen wrote: > Signed-off-by: Alexander Riesen Reviewed-by: Laurent Pinchart > --- > drivers/media/i2c/adv748x/adv748x-core.c | 24 ++++++++++++------------ > drivers/media/i2c/adv748x/adv748x-csi2.c | 2 +- > 2 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c > index 23e02ff27b17..c3fb113cef62 100644 > --- a/drivers/media/i2c/adv748x/adv748x-core.c > +++ b/drivers/media/i2c/adv748x/adv748x-core.c > @@ -623,11 +623,11 @@ static int adv748x_parse_dt(struct adv748x_state *state) > > for_each_endpoint_of_node(state->dev->of_node, ep_np) { > of_graph_parse_endpoint(ep_np, &ep); > - adv_info(state, "Endpoint %pOF on port %d", ep.local_node, > + adv_info(state, "Endpoint %pOF on port %d\n", ep.local_node, > ep.port); > > if (ep.port >= ADV748X_PORT_MAX) { > - adv_err(state, "Invalid endpoint %pOF on port %d", > + adv_err(state, "Invalid endpoint %pOF on port %d\n", > ep.local_node, ep.port); > > continue; > @@ -635,7 +635,7 @@ static int adv748x_parse_dt(struct adv748x_state *state) > > if (state->endpoints[ep.port]) { > adv_err(state, > - "Multiple port endpoints are not supported"); > + "Multiple port endpoints are not supported\n"); > continue; > } > > @@ -702,62 +702,62 @@ static int adv748x_probe(struct i2c_client *client) > /* Discover and process ports declared by the Device tree endpoints */ > ret = adv748x_parse_dt(state); > if (ret) { > - adv_err(state, "Failed to parse device tree"); > + adv_err(state, "Failed to parse device tree\n"); > goto err_free_mutex; > } > > /* Configure IO Regmap region */ > ret = adv748x_configure_regmap(state, ADV748X_PAGE_IO); > if (ret) { > - adv_err(state, "Error configuring IO regmap region"); > + adv_err(state, "Error configuring IO regmap region\n"); > goto err_cleanup_dt; > } > > ret = adv748x_identify_chip(state); > if (ret) { > - adv_err(state, "Failed to identify chip"); > + adv_err(state, "Failed to identify chip\n"); > goto err_cleanup_dt; > } > > /* Configure remaining pages as I2C clients with regmap access */ > ret = adv748x_initialise_clients(state); > if (ret) { > - adv_err(state, "Failed to setup client regmap pages"); > + adv_err(state, "Failed to setup client regmap pages\n"); > goto err_cleanup_clients; > } > > /* SW reset ADV748X to its default values */ > ret = adv748x_reset(state); > if (ret) { > - adv_err(state, "Failed to reset hardware"); > + adv_err(state, "Failed to reset hardware\n"); > goto err_cleanup_clients; > } > > /* Initialise HDMI */ > ret = adv748x_hdmi_init(&state->hdmi); > if (ret) { > - adv_err(state, "Failed to probe HDMI"); > + adv_err(state, "Failed to probe HDMI\n"); > goto err_cleanup_clients; > } > > /* Initialise AFE */ > ret = adv748x_afe_init(&state->afe); > if (ret) { > - adv_err(state, "Failed to probe AFE"); > + adv_err(state, "Failed to probe AFE\n"); > goto err_cleanup_hdmi; > } > > /* Initialise TXA */ > ret = adv748x_csi2_init(state, &state->txa); > if (ret) { > - adv_err(state, "Failed to probe TXA"); > + adv_err(state, "Failed to probe TXA\n"); > goto err_cleanup_afe; > } > > /* Initialise TXB */ > ret = adv748x_csi2_init(state, &state->txb); > if (ret) { > - adv_err(state, "Failed to probe TXB"); > + adv_err(state, "Failed to probe TXB\n"); > goto err_cleanup_txa; > } > > diff --git a/drivers/media/i2c/adv748x/adv748x-csi2.c b/drivers/media/i2c/adv748x/adv748x-csi2.c > index 2091cda50935..c43ce5d78723 100644 > --- a/drivers/media/i2c/adv748x/adv748x-csi2.c > +++ b/drivers/media/i2c/adv748x/adv748x-csi2.c > @@ -72,7 +72,7 @@ static int adv748x_csi2_registered(struct v4l2_subdev *sd) > struct adv748x_state *state = tx->state; > int ret; > > - adv_dbg(state, "Registered %s (%s)", is_txa(tx) ? "TXA":"TXB", > + adv_dbg(state, "Registered %s (%s)\n", is_txa(tx) ? "TXA":"TXB", > sd->name); > > /* -- Regards, Laurent Pinchart _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel