From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2A15C4332B for ; Fri, 20 Mar 2020 11:12:25 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDC8F20732 for ; Fri, 20 Mar 2020 11:12:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDC8F20732 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cetitec.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 9007E87E59; Fri, 20 Mar 2020 11:12:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CBt-CNdz500O; Fri, 20 Mar 2020 11:12:24 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 40C5E87A33; Fri, 20 Mar 2020 11:12:24 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 506821BF300 for ; Fri, 20 Mar 2020 11:12:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id E5A0822622 for ; Fri, 20 Mar 2020 11:12:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZlbrMtap01qv for ; Fri, 20 Mar 2020 11:12:20 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.135]) by silver.osuosl.org (Postfix) with ESMTPS id 633512051E for ; Fri, 20 Mar 2020 11:12:20 +0000 (UTC) Received: from mail.cetitecgmbh.com ([87.190.42.90]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MwQGj-1jVx2Q3zC1-00sR4z; Fri, 20 Mar 2020 12:12:00 +0100 Received: from pflvmailgateway.corp.cetitec.com (unknown [127.0.0.1]) by mail.cetitecgmbh.com (Postfix) with ESMTP id D346464D8E7; Fri, 20 Mar 2020 11:11:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at cetitec.com Received: from mail.cetitecgmbh.com ([127.0.0.1]) by pflvmailgateway.corp.cetitec.com (pflvmailgateway.corp.cetitec.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hbhxwVzTYJeb; Fri, 20 Mar 2020 12:11:58 +0100 (CET) Received: from pfwsexchange.corp.cetitec.com (unknown [10.10.1.99]) by mail.cetitecgmbh.com (Postfix) with ESMTPS id 7E4DC64BDF2; Fri, 20 Mar 2020 12:11:58 +0100 (CET) Received: from pflmari.corp.cetitec.com (10.8.5.41) by PFWSEXCHANGE.corp.cetitec.com (10.10.1.99) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 20 Mar 2020 12:11:58 +0100 Received: by pflmari.corp.cetitec.com (Postfix, from userid 1000) id DDC578050D; Fri, 20 Mar 2020 12:11:57 +0100 (CET) Date: Fri, 20 Mar 2020 12:11:57 +0100 From: Alex Riesen To: Geert Uytterhoeven Subject: Re: [PATCH v2 05/10] media: adv748x: add support for HDMI audio Message-ID: <20200320111157.GH4344@pflmari> Mail-Followup-To: Alex Riesen , Geert Uytterhoeven , Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Rob Herring , Mark Rutland , Kuninori Morimoto , driverdevel , Linux Media Mailing List , Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas , linux-clk References: <252bb433f47b0ccb61bb077abdbd892091abc550.1584639664.git.alexander.riesen@cetitec.com> <20200320105846.GG4344@pflmari> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Originating-IP: [10.8.5.41] X-ClientProxiedBy: PFWSEXCHANGE.corp.cetitec.com (10.10.1.99) To PFWSEXCHANGE.corp.cetitec.com (10.10.1.99) X-EsetResult: clean, is OK X-EsetId: 37303A290D7F536A6D776A X-Provags-ID: V03:K1:YmOpyUa1MX2lar3B2/y59QLL71WDNBwoqzE32XfFiajWx1ZGlRb n0Eu/6ecTjm7w+oQXq5gUy4REoDz0ZOaz3lXwPFzceyx6i7mL99o2f0ImAoZCEkYuLakZuR GW6GdLy7a4CbkUqoEzP8MjkSf5f9JpKK+OS77rsxVyJ4VH7QTOPXsk/OnQthu0g7y/dP482 p0UYIgjNFGv/Sk0tSyKfA== X-UI-Out-Filterresults: notjunk:1;V03:K0:u/NT0LgJThw=:vTOcMP6mPnOiUJk3sPV2D6 PPwbPAoPvfmF8jrgslYHjumhiEy9NIQNL7LUhRo0RmsC8CXbpAxhZUXU9pAg4Uv4SM+mkL1S0 WQAYI5jFCgHWbk+FpTgBChzx7xD2WB5kiNvcVInp9fy/IGUnavrsgAH4SXs5nY7L78WTceQoB m2HAeXIjGF8y6EXKGL5j/nw7ik2miuvsVvkLUH+v7Zeuuv+ncyspaXaVbqxhvvTXWhL6671qS bexNOEWYOFeawVs62Fax4KoLGVtHHZDK3qRFD7mCUXLPMhSJ3HoDvcWX946YFPrRQUBCiC8Ze BxFuYYYCTQu7bKqLufipPxeJ7wX/5Cmsr7h28wBq4m54cDsg5KRXZgZ8ZvoYny0DrMa8dbz/B RWBXsEQQoraQeAR6KXtht7dySHtafFRg1m134QLqoZiwGlLNVcmKa+nnLJZ0YUpjX1RUu3rcn gV+s0txu7tJLbk0+N0lFEuvdXp3fuQGVQfmV7fFq4Yns9iIsc3HaGvXmm96wNsy7jJmkfK0ba yv8oKhKcbAMK1cBnZlAupU60+IwegjFM/WWwKtzPMtu9kZqHpNj4/gq+hvwhn5FEamMWnpl1S EVowToSwyOu+ShGWHxAPSXIokoQf4nSCpBrp/pxeLHmSDAoXpvy4iEJpPQ52BWGjFNZgYK6gX F8sp8mQKhRn2rgS5loGD/7Z+QXBR05UYm9OXcrGIN1CLDI4eQ3CW+QQq4rIDyQkf842NQ1Ma8 HeJ0hIdSWwOHyIR7uSWFpJ7o3exySMgGAJaUl5LnEfHUVc59aNZGF7lAjh7GjCypwV8LaCoiO h1uVdSsu6t+PgwFH6l/GH2OT3SlaqUgmEeNswRE11n7kdNNH2aWq1Tx5l2/B4i40XggL7fI X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , driverdevel , Kuninori Morimoto , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Kieran Bingham , Linux Kernel Mailing List , Linux-Renesas , Rob Herring , Laurent Pinchart , Hans Verkuil , Mauro Carvalho Chehab , linux-clk , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi Geert, Geert Uytterhoeven, Fri, Mar 20, 2020 12:05:20 +0100: > On Fri, Mar 20, 2020 at 11:58 AM Alex Riesen wrote: > > Geert Uytterhoeven, Fri, Mar 20, 2020 09:43:29 +0100: > > > On Thu, Mar 19, 2020 at 6:42 PM Alex Riesen wrote: > > > > This adds an implemention of SoC DAI driver which provides access to the > > > > I2S port of the device. > > > > I just noticed I don't do clk_prepare_enable anywhere. > > Shouldn't the clock master enable its clocks somewhere? > > Usually the consumer is responsible for doing that. > Does the rcar-sound driver do that? No, it does not (verified by /sys/kernel/debug/clk/clk_summary during transfer). > But in this case, perhaps the clock should be enabled implicitly in response > to a request from the audio subsystem, like you do below. Ok... > Note that you register a fixed-rate clock, which is assumed to be always > enabled. Perhaps a gateable clock type is more appropriate? The gated clock implementation requires use of an I/O register, which I don't have in this case (an I2C connected device). I considered implementing full clk_hw set of operations, but decided against it: it's a lot for this simple configuration. Few other drivers do that, too. Regards, Alex _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel