From: Alex Riesen <alexander.riesen@cetitec.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 08/10] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC
Date: Mon, 23 Mar 2020 08:35:57 +0100 [thread overview]
Message-ID: <20200323073557.GA4298@pflmari> (raw)
In-Reply-To: <87fte0lyjz.wl-kuninori.morimoto.gx@renesas.com>
Hi Morimoto-san,
Kuninori Morimoto, Mon, Mar 23, 2020 01:12:00 +0100:
> > As all known variants of the Salvator board have the HDMI decoder
> > chip (the ADV7482) connected to the SSI4 on R-Car SoC, the ADV7482
> > endpoint and the connection definitions are placed in the common board
> > file.
> > For the same reason, the CLK_C clock line and I2C configuration (similar
> > to the ak4613, on the same interface) are added into the common file.
> >
> > Signed-off-by: Alexander Riesen <alexander.riesen@cetitec.com>
> > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> (snip)
> > @@ -758,8 +769,19 @@ &rcar_sound {
> > <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>,
> > <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>,
> > <&audio_clk_a>, <&cs2000>,
> > - <&audio_clk_c>,
> > + <&adv7482_hdmi_in>,
> > <&cpg CPG_CORE CPG_AUDIO_CLK_I>;
> > + clock-names = "ssi-all",
> > + "ssi.9", "ssi.8", "ssi.7", "ssi.6",
> > + "ssi.5", "ssi.4", "ssi.3", "ssi.2",
> > + "ssi.1", "ssi.0",
> > + "src.9", "src.8", "src.7", "src.6",
> > + "src.5", "src.4", "src.3", "src.2",
> > + "src.1", "src.0",
> > + "mix.1", "mix.0",
> > + "ctu.1", "ctu.0",
> > + "dvc.0", "dvc.1",
> > + "clk_a", "clk_b", "clk_c", "clk_i";
>
> I think you don't need to overwrite clock-names here in this case ?
I vaguely remember something using the names and failing to enable clk_c
without the list spelled out...
I shall re-test though, perhaps it was my own code (since removed) using it.
Regards,
Alex
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-03-23 7:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 17:41 [PATCH v2 00/10] media: adv748x: add support for HDMI audio Alex Riesen
2020-03-19 17:41 ` [PATCH v2 01/10] media: adv748x: fix end-of-line terminators in diagnostic statements Alex Riesen
2020-03-19 18:03 ` Laurent Pinchart
2020-03-19 17:41 ` [PATCH v2 02/10] media: adv748x: include everything adv748x.h needs into the file Alex Riesen
2020-03-19 17:48 ` Laurent Pinchart
2020-03-20 8:23 ` Alex Riesen
2020-03-19 17:41 ` [PATCH v2 03/10] media: adv748x: reduce amount of code for bitwise modifications of device registers Alex Riesen
2020-03-19 18:06 ` Laurent Pinchart
2020-03-20 9:08 ` Alex Riesen
2020-03-19 17:41 ` [PATCH v2 04/10] media: adv748x: add definitions for audio output related registers Alex Riesen
2020-03-19 17:42 ` [PATCH v2 05/10] media: adv748x: add support for HDMI audio Alex Riesen
2020-03-20 8:43 ` Geert Uytterhoeven
2020-03-20 8:57 ` Alex Riesen
2020-03-20 9:10 ` Geert Uytterhoeven
2020-03-20 10:58 ` Alex Riesen
2020-03-20 11:05 ` Geert Uytterhoeven
2020-03-20 11:11 ` Alex Riesen
2020-03-19 17:42 ` [PATCH v2 06/10] media: adv748x: only activate DAI if it is described in device tree Alex Riesen
2020-03-19 17:42 ` [PATCH v2 07/10] dt-bindings: adv748x: add information about serial audio interface (I2S/TDM) Alex Riesen
2020-03-19 18:01 ` Laurent Pinchart
2020-03-20 8:44 ` Alex Riesen
2020-03-20 8:48 ` Geert Uytterhoeven
2020-03-20 9:03 ` Alex Riesen
2020-03-20 9:15 ` Geert Uytterhoeven
2020-03-20 9:18 ` Alex Riesen
2020-03-20 9:59 ` Laurent Pinchart
2020-03-20 16:15 ` Alex Riesen
2020-03-19 17:42 ` [PATCH v2 08/10] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC Alex Riesen
2020-03-23 0:12 ` Kuninori Morimoto
2020-03-23 7:35 ` Alex Riesen [this message]
2020-03-19 17:42 ` [PATCH v2 09/10] media: adv748x: add support for log_status ioctl Alex Riesen
2020-03-19 17:43 ` [PATCH v2 10/10] media: adv748x: allow the HDMI sub-device to accept EDID Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323073557.GA4298@pflmari \
--to=alexander.riesen@cetitec.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kieran.bingham@ideasonboard.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).