From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88BA9C43331 for ; Thu, 2 Apr 2020 08:20:12 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B9902078E for ; Thu, 2 Apr 2020 08:20:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="KUww6XPN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B9902078E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 2938086FCF; Thu, 2 Apr 2020 08:20:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KuGdjoq3-n86; Thu, 2 Apr 2020 08:20:11 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 17E2386F6A; Thu, 2 Apr 2020 08:20:11 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 1CA971BF3AF for ; Thu, 2 Apr 2020 08:20:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 189D988026 for ; Thu, 2 Apr 2020 08:20:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oiAk9Mc4rNXF for ; Thu, 2 Apr 2020 08:20:08 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by hemlock.osuosl.org (Postfix) with ESMTPS id 893FE87F73 for ; Thu, 2 Apr 2020 08:20:08 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0328In6m148305; Thu, 2 Apr 2020 08:20:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=S0KcJ+/HxSntHkE6YeHdP5O/WgQiF9EjD5DgCzgQWDU=; b=KUww6XPN5EVJX/b3dnxhJiNJrcq35B07mDJOfskt23N+RtGqvCc+Nr5mQz6joMGW7SbU c+6gjRGpYq7rW912nBhFQ9MnGL528P7ws3Mcl4qmzEC7CQsttj31oZ/MMKEY8MVR4me+ yC/9oRS5dSb4lEmw3PbH7O6N50Ox0J2BzNUPYzOSQgy4KtJ7ZIS6wmqtvSChW5uiOY1O xeuoNCcAGg/qLk3VX7FKs85BIHyGjTRquuweQsG4IcKyyITi5Mggri4kjUTbrqefr1L9 fuPhsTA9FEuflnaAJkmHOuwWGbV8MsDW5sBMjExP/97UweDyLrhGMXKHunIHQjBuNGvY NQ== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 303aqhtaj4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 Apr 2020 08:20:07 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0328H7fx126298; Thu, 2 Apr 2020 08:20:07 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 304sjnswnj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 Apr 2020 08:20:06 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0328K4Bo023025; Thu, 2 Apr 2020 08:20:04 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 02 Apr 2020 01:20:03 -0700 Date: Thu, 2 Apr 2020 11:19:56 +0300 From: Dan Carpenter To: aimannajjar Subject: Re: [PATCH v2 1/5] staging: rtl8712: fix checkpatch long-line warning Message-ID: <20200402081956.GF2001@kadam> References: <20200327080429.GB1627562@kroah.com> <6a4d94b4e5446f4665dc11290ed1351661554f01.1585353747.git.aiman.najjar@hurranet.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6a4d94b4e5446f4665dc11290ed1351661554f01.1585353747.git.aiman.najjar@hurranet.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9578 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 mlxscore=0 malwarescore=0 phishscore=0 suspectscore=2 mlxlogscore=999 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004020075 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9578 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 clxscore=1015 malwarescore=0 impostorscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=2 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004020075 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , Larry Finger , linux-kernel@vger.kernel.org, Florian Schilhabel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Fri, Mar 27, 2020 at 08:08:07PM -0400, aimannajjar wrote: > This patch fixes these two long-line checkpatch warnings > in rtl871x_xmit.c: > > WARNING: line over 80 characters > \#74: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:74: > + * Please allocate memory with the sz = (struct xmit_frame) * NR_XMITFRAME, > > WARNING: line over 80 characters > \#79: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:79: > + kmalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4, GFP_ATOMIC); > > Signed-off-by: aimannajjar > --- > drivers/staging/rtl8712/rtl871x_xmit.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c > index f0b85338b567..628e4bad1547 100644 > --- a/drivers/staging/rtl8712/rtl871x_xmit.c > +++ b/drivers/staging/rtl8712/rtl871x_xmit.c > @@ -71,12 +71,13 @@ int _r8712_init_xmit_priv(struct xmit_priv *pxmitpriv, > _init_queue(&pxmitpriv->apsd_queue); > _init_queue(&pxmitpriv->free_xmit_queue); > /* > - * Please allocate memory with the sz = (struct xmit_frame) * NR_XMITFRAME, > + * Please allocate memory with sz = (struct xmit_frame) * NR_XMITFRAME, > * and initialize free_xmit_frame below. > * Please also apply free_txobj to link_up all the xmit_frames... Probably you could delete the "Please ". regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel