From: Greg KH <gregkh@linuxfoundation.org>
To: Christian Gromm <christian.gromm@microchip.com>
Cc: driverdev-devel@linuxdriverproject.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/7] staging: most: usb: remove reference to USB error codes
Date: Thu, 14 May 2020 16:05:15 +0200 [thread overview]
Message-ID: <20200514140515.GD2581983@kroah.com> (raw)
In-Reply-To: <1589463989-30029-3-git-send-email-christian.gromm@microchip.com>
On Thu, May 14, 2020 at 03:46:24PM +0200, Christian Gromm wrote:
> This patch removes the reference to the driver API file for USB error
> codes.
>
> Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
> Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/staging/most/usb/usb.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c
> index 85d4fa0..76963c0 100644
> --- a/drivers/staging/most/usb/usb.c
> +++ b/drivers/staging/most/usb/usb.c
> @@ -477,8 +477,6 @@ static void hdm_write_completion(struct urb *urb)
> * controller use to indicate a transfer has failed because of device
> * disconnect. In the interval before the hub driver starts disconnect
> * processing, devices may receive such fault reports for every request.
> - *
> - * See <https://www.kernel.org/doc/Documentation/driver-api/usb/error-codes.rst>
Remove the whole text above this as well, as that just duplicates what
is written here and isn't needed at all as we all "know" the different
values that urb status returns.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-05-14 14:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 13:46 [PATCH 0/7] staging: most: usb: fix issues found in code audit Christian Gromm
2020-05-14 13:46 ` [PATCH 1/7] staging: most: usb: use dev_*() functions to print messages Christian Gromm
2020-05-14 13:46 ` [PATCH 2/7] staging: most: usb: remove reference to USB error codes Christian Gromm
2020-05-14 14:05 ` Greg KH [this message]
2020-05-14 13:46 ` [PATCH 3/7] staging: most: usb: check number of reported endpoints Christian Gromm
2020-05-14 14:06 ` Greg KH
2020-05-14 16:56 ` Christian.Gromm
2020-05-14 13:46 ` [PATCH 4/7] staging: most: usb: use dev_dbg function Christian Gromm
2020-05-14 13:46 ` [PATCH 5/7] staging: most: fix typo in Kconfig Christian Gromm
2020-05-14 13:46 ` [PATCH 6/7] staging: most: usb: use macro ATTRIBUTE_GROUPS Christian Gromm
2020-05-14 13:46 ` [PATCH 7/7] Documentation: ABI: correct sysfs attribute description of MOST driver Christian Gromm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514140515.GD2581983@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=christian.gromm@microchip.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).