DriverDev-Devel Archive on
 help / color / Atom feed
From: Matej Dujava <>
To: Greg Kroah-Hartman <>
	Forest Bond <>,
Subject: Re: [PATCH v3 2/2] staging: vt6655: vt6656: change order of makefile variable definitions
Date: Fri, 15 May 2020 16:55:38 +0200
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, May 15, 2020 at 03:48:59PM +0200, Greg Kroah-Hartman wrote:
>I still fail to understand the need for this patch at all.  It doesn't
>clean anything up, nor change anything.  There is no rule that this has
>to be in one order or the other, and in fact, I like the order that the
>files currently have :)
>greg k-h

Most of makefiles has pattern that `obj-${}` is before `driver-y` lines.
If this is not something that was intentional, then this patch is not
adding any value indeed.

Few examples that give me that impression:

./gnss/Makefile-# SPDX-License-Identifier: GPL-2.0
./gnss/Makefile-# Makefile for the GNSS subsystem.
./gnss/Makefile:obj-$(CONFIG_GNSS)          += gnss.o
./gnss/Makefile-gnss-y := core.o
./gnss/Makefile:obj-$(CONFIG_GNSS_SERIAL)       += gnss-serial.o
./gnss/Makefile-gnss-serial-y := serial.o
--snip end--

./.../go7007/Makefile-# SPDX-License-Identifier: GPL-2.0
./.../go7007/Makefile:obj-$(CONFIG_VIDEO_GO7007) += go7007.o
./.../go7007/Makefile:obj-$(CONFIG_VIDEO_GO7007_USB) += go7007-usb.o
./.../go7007/Makefile:obj-$(CONFIG_VIDEO_GO7007_LOADER) += go7007-loader.o
./.../go7007/Makefile:obj-$(CONFIG_VIDEO_GO7007_USB_S2250_BOARD) += s2250.o
./.../go7007/Makefile-go7007-y := go7007-v4l2.o go7007-driver.o go7007-i2c.
./.../go7007/Makefile-        snd-go7007.o
./.../go7007/Makefile-s2250-y := s2250-board.o
--snip end--

devel mailing list

      reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13 19:15 [PATCH v3 0/2] staging: vt6656: vt6655: cleaning Makefile Matej Dujava
2020-05-13 19:15 ` [PATCH v3 1/2] staging: vt6656: vt6655: removing unused macros definition Makefiles Matej Dujava
2020-05-13 19:15 ` [PATCH v3 2/2] staging: vt6655: vt6656: change order of makefile variable definitions Matej Dujava
2020-05-15 13:48   ` Greg Kroah-Hartman
2020-05-15 14:55     ` Matej Dujava [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DriverDev-Devel Archive on

Archives are clonable:
	git clone --mirror driverdev-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 driverdev-devel driverdev-devel/ \
	public-inbox-index driverdev-devel

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone