Remove below warning in das1800.c WARNING: possible condition with no effect (if == else) Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> --- drivers/staging/comedi/drivers/das1800.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c index f16aa7e9f4f3..7ab72e83d3d0 100644 --- a/drivers/staging/comedi/drivers/das1800.c +++ b/drivers/staging/comedi/drivers/das1800.c @@ -1299,12 +1299,6 @@ static int das1800_attach(struct comedi_device *dev, outb(DAC(i), dev->iobase + DAS1800_SELECT); outw(0, dev->iobase + DAS1800_DAC); } - } else if (board->id == DAS1800_ID_AO) { - /* - * 'ao' boards have waveform analog outputs that are not - * currently supported. - */ - s->type = COMEDI_SUBD_UNUSED; } else { s->type = COMEDI_SUBD_UNUSED; } -- 2.20.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sun, Jul 12, 2020 at 12:36:28PM +0530, Saurav Girepunje wrote: > Remove below warning in das1800.c > WARNING: possible condition with no effect (if == else) > > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> > --- > drivers/staging/comedi/drivers/das1800.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c > index f16aa7e9f4f3..7ab72e83d3d0 100644 > --- a/drivers/staging/comedi/drivers/das1800.c > +++ b/drivers/staging/comedi/drivers/das1800.c > @@ -1299,12 +1299,6 @@ static int das1800_attach(struct comedi_device *dev, > outb(DAC(i), dev->iobase + DAS1800_SELECT); > outw(0, dev->iobase + DAS1800_DAC); > } > - } else if (board->id == DAS1800_ID_AO) { > - /* > - * 'ao' boards have waveform analog outputs that are not > - * currently supported. > - */ > - s->type = COMEDI_SUBD_UNUSED; What gave that warning? The comment should show you why this is good to keep as-is, right? thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 13/07/2020 14:34, Greg KH wrote: > On Sun, Jul 12, 2020 at 12:36:28PM +0530, Saurav Girepunje wrote: >> Remove below warning in das1800.c >> WARNING: possible condition with no effect (if == else) >> >> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> >> --- >> drivers/staging/comedi/drivers/das1800.c | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c >> index f16aa7e9f4f3..7ab72e83d3d0 100644 >> --- a/drivers/staging/comedi/drivers/das1800.c >> +++ b/drivers/staging/comedi/drivers/das1800.c >> @@ -1299,12 +1299,6 @@ static int das1800_attach(struct comedi_device *dev, >> outb(DAC(i), dev->iobase + DAS1800_SELECT); >> outw(0, dev->iobase + DAS1800_DAC); >> } >> - } else if (board->id == DAS1800_ID_AO) { >> - /* >> - * 'ao' boards have waveform analog outputs that are not >> - * currently supported. >> - */ >> - s->type = COMEDI_SUBD_UNUSED; > > What gave that warning? The comment should show you why this is good to > keep as-is, right? One option is to move the comment into the '} else {' part that follows this part. -- -=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=- -=( MEV Ltd. is a company registered in England & Wales. )=- -=( Registered number: 02862268. Registered address: )=- -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=- _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Jul 13, 2020 at 02:41:19PM +0100, Ian Abbott wrote: > On 13/07/2020 14:34, Greg KH wrote: > > On Sun, Jul 12, 2020 at 12:36:28PM +0530, Saurav Girepunje wrote: > > > Remove below warning in das1800.c > > > WARNING: possible condition with no effect (if == else) > > > > > > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> > > > --- > > > drivers/staging/comedi/drivers/das1800.c | 6 ------ > > > 1 file changed, 6 deletions(-) > > > > > > diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c > > > index f16aa7e9f4f3..7ab72e83d3d0 100644 > > > --- a/drivers/staging/comedi/drivers/das1800.c > > > +++ b/drivers/staging/comedi/drivers/das1800.c > > > @@ -1299,12 +1299,6 @@ static int das1800_attach(struct comedi_device *dev, > > > outb(DAC(i), dev->iobase + DAS1800_SELECT); > > > outw(0, dev->iobase + DAS1800_DAC); > > > } > > > - } else if (board->id == DAS1800_ID_AO) { > > > - /* > > > - * 'ao' boards have waveform analog outputs that are not > > > - * currently supported. > > > - */ > > > - s->type = COMEDI_SUBD_UNUSED; > > > > What gave that warning? The comment should show you why this is good to > > keep as-is, right? > > One option is to move the comment into the '} else {' part that follows this > part. > > -- > -=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=- > -=( MEV Ltd. is a company registered in England & Wales. )=- > -=( Registered number: 02862268. Registered address: )=- > -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=- @gregkh : Got the warning using coccinelle. @Ian: Yes, we can move comment to else part. _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel