driverdev-devel.linuxdriverproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] staging: kpc2000: Replace depracated MSI API.
@ 2020-07-18 15:49 Suraj Upadhyay
  2020-07-19  4:33 ` Suraj Upadhyay
  0 siblings, 1 reply; 2+ messages in thread
From: Suraj Upadhyay @ 2020-07-18 15:49 UTC (permalink / raw)
  To: gregkh; +Cc: devel, linux-kernel


[-- Attachment #1.1: Type: text/plain, Size: 919 bytes --]

Replace depracated pci_enable_msi with pci_alloc_irq_vectors.
And as a result modify how the returned value is handled.

Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com>
---
Changes:
	v2: Removed the undefined variable.
	    Reported by kernel-bot.

 drivers/staging/kpc2000/kpc2000/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/kpc2000/kpc2000/core.c b/drivers/staging/kpc2000/kpc2000/core.c
index 358d7b2f4ad1..8339026ffb41 100644
--- a/drivers/staging/kpc2000/kpc2000/core.c
+++ b/drivers/staging/kpc2000/kpc2000/core.c
@@ -440,7 +440,7 @@ static int kp2000_pcie_probe(struct pci_dev *pdev,
 	dev_dbg(&pcard->pdev->dev,
 		"Using DMA mask %0llx\n", dma_get_mask(PCARD_TO_DEV(pcard)));
 
-	err = pci_enable_msi(pcard->pdev);
+	err = pci_alloc_irq_vectors(pcard->pdev, 1, 1, PCI_IRQ_MSI);
 	if (err < 0)
 		goto err_release_dma;
 
-- 
2.17.1


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 169 bytes --]

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] staging: kpc2000: Replace depracated MSI API.
  2020-07-18 15:49 [PATCH v2] staging: kpc2000: Replace depracated MSI API Suraj Upadhyay
@ 2020-07-19  4:33 ` Suraj Upadhyay
  0 siblings, 0 replies; 2+ messages in thread
From: Suraj Upadhyay @ 2020-07-19  4:33 UTC (permalink / raw)
  To: gregkh; +Cc: devel, linux-kernel

On Sat, Jul 18, 2020 at 09:19:51PM +0530, Suraj Upadhyay wrote:
> Replace depracated pci_enable_msi with pci_alloc_irq_vectors.
> And as a result modify how the returned value is handled.
> 
> Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com>
> ---
> Changes:
> 	v2: Removed the undefined variable.
> 	    Reported by kernel-bot.
> 
Don't merge it.
This patch is incomplete.
I have to replce pci_disable_msi too.
I hope this didn't cause any annoyances.

Thanks,

Suraj Upadhyay.

>  drivers/staging/kpc2000/kpc2000/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/kpc2000/kpc2000/core.c b/drivers/staging/kpc2000/kpc2000/core.c
> index 358d7b2f4ad1..8339026ffb41 100644
> --- a/drivers/staging/kpc2000/kpc2000/core.c
> +++ b/drivers/staging/kpc2000/kpc2000/core.c
> @@ -440,7 +440,7 @@ static int kp2000_pcie_probe(struct pci_dev *pdev,
>  	dev_dbg(&pcard->pdev->dev,
>  		"Using DMA mask %0llx\n", dma_get_mask(PCARD_TO_DEV(pcard)));
>  
> -	err = pci_enable_msi(pcard->pdev);
> +	err = pci_alloc_irq_vectors(pcard->pdev, 1, 1, PCI_IRQ_MSI);
>  	if (err < 0)
>  		goto err_release_dma;
>  
> -- 
> 2.17.1
> 


_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-19  4:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-18 15:49 [PATCH v2] staging: kpc2000: Replace depracated MSI API Suraj Upadhyay
2020-07-19  4:33 ` Suraj Upadhyay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).