From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIM_ADSP_ALL, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDCC0C433DF for ; Sat, 25 Jul 2020 12:51:04 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6AB4220674 for ; Sat, 25 Jul 2020 12:51:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=rere.qmqm.pl header.i=@rere.qmqm.pl header.b="eEtye1y8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AB4220674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rere.qmqm.pl Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 293B6889FC; Sat, 25 Jul 2020 12:51:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EGG8cqBg1gS4; Sat, 25 Jul 2020 12:51:03 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 1576A88A02; Sat, 25 Jul 2020 12:51:03 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id BEE031BF36C for ; Sat, 25 Jul 2020 12:51:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id B2EA92051C for ; Sat, 25 Jul 2020 12:51:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8CsVwWBiGRP6 for ; Sat, 25 Jul 2020 12:50:58 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from rere.qmqm.pl (rere.qmqm.pl [91.227.64.183]) by silver.osuosl.org (Postfix) with ESMTPS id 5043720528 for ; Sat, 25 Jul 2020 12:50:58 +0000 (UTC) Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 4BDQsq3DH3z4D; Sat, 25 Jul 2020 14:50:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1595681456; bh=lOrzlYaUy5M9mACsVH7i0G6RcZ9CCXP8CXf0i8hOFi4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eEtye1y8BrE5ycM2NcC5NcDjpHnETN6U6d+PeTEF30kF0HLofs8hEM7Ho4Q1qZG50 RHk05JxX5XLQ5wuGOCy7+KOgfv6P2c7E1qb3XvokNAIayz8zXE+6vS+zyIL3zHGrog iYI9yHuacTAKuadM4T6gr7p+ntadxLB9VTfpmKJc5f3i69bXRDTrvf8uRucigeQt6L 0RLRTDC21Kf4OMv3VH7wAOIgA1FnRbwruR9PIkee2zzVeNLNhD68jSzqm3peqbMisf J7xVYZTTiPfsGXMNkgDMUvpTTTftq9h7rq7q35BPWZM0WraeAObSmM17WA1aZtX8cm zztyEVWn2KT7A== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at mail Date: Sat, 25 Jul 2020 14:50:54 +0200 From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= To: Rohit K Bharadwaj Subject: Re: [PATCH v4] staging: nvec: change usage of slave to secondary Message-ID: <20200725125054.GB18633@qmqm.qmqm.pl> References: <20200724043633.7755-1-bharadwaj.rohit8@gmail.com> <20200725062938.15388-1-bharadwaj.rohit8@gmail.com> <20200725120146.GB26689@qmqm.qmqm.pl> <5597e949-b93c-9133-efdb-9714637f9ebc@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5597e949-b93c-9133-efdb-9714637f9ebc@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, Dan Carpenter , p.zabel@pengutronix.de, linux-tegra@vger.kernel.org, ac100@lists.launchpad.net Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Sat, Jul 25, 2020 at 06:01:19PM +0530, Rohit K Bharadwaj wrote: > On 25/07/20 5:31 pm, Micha=B3 Miros=B3aw wrote: > > On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote: > >> changed usage of slave (which is deprecated) to secondary without brea= king the driver > > = > > The relevant I2C and SMBus standards use master/slave terminology. Why = are > > you changing the names to something unfamiliar? > > = > > If the reason are the recent coding-style changes, then please note they > > are about avoiding introducing *NEW* uses of the specific words and not > > about blindly replacing existing occurrences. > = > I'm really sorry sir, I didn't knew about this, yes the reason for my cha= nge is according to the script checkpatch.pl to suit the coding style, I wo= uld try to fix some other coding style related issues if this patch seems t= o be a bad idea. I didn't know checkpatch does this (it doesn't in current Linus' master tree). I can see there is a commit in next adding this, but seems that it uses a test far from the original coding-style wording... Best Regards Micha=B3=A0Miros=B3aw _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel