From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CC57C433E3 for ; Sun, 26 Jul 2020 15:02:51 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E3382065F for ; Sun, 26 Jul 2020 15:02:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="FoDzpgFX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E3382065F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id D3243204BE; Sun, 26 Jul 2020 15:02:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7u2hyq7W1RkF; Sun, 26 Jul 2020 15:02:49 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 7FF54203ED; Sun, 26 Jul 2020 15:02:49 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 56B4D1BF46D for ; Sun, 26 Jul 2020 15:02:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 50CA085FA5 for ; Sun, 26 Jul 2020 15:02:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3xty-7DxHm0Q for ; Sun, 26 Jul 2020 15:02:47 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by fraxinus.osuosl.org (Postfix) with ESMTPS id C12D385FA3 for ; Sun, 26 Jul 2020 15:02:47 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 00B0E2065F; Sun, 26 Jul 2020 15:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595775767; bh=f3y4+0LTpamybnhtv3IjlJLojrpbCyRtRcCbDJsbJck=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FoDzpgFXVa63BwD6myxZjyYjnSp819WnkLpTTmaFPnG9qXuOfZcqlIbbkmIU378l2 mnpQTke+lH6n2C5eIPSjBhuk5z2TFLZLaWQxo1p2XQUQ66k5fx8CdMEh7S5cvHr/3d WSI5KB9gzuFXzoEy7PtKfTJzGRxI7UI9K5OW2krg= Date: Sun, 26 Jul 2020 17:02:44 +0200 From: Greg KH To: Aditya Jain Subject: Re: [PATCH v3 3/4] staging: rtl8723bs: include: Further clean up function declarations Message-ID: <20200726150244.GD452766@kroah.com> References: <20200726141831.2662-1-aditya.jainadityajain.jain@gmail.com> <20200726142013.2891-1-aditya.jainadityajain.jain@gmail.com> <20200726142013.2891-3-aditya.jainadityajain.jain@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200726142013.2891-3-aditya.jainadityajain.jain@gmail.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Sun, Jul 26, 2020 at 07:50:12PM +0530, Aditya Jain wrote: > Cleaning up messy multiline function declarations in hal_phy_cfg.h > > This patch is a continuation of patch "Clean up function declarations" This should be merged with that patch, no reason to make it separate. > > Signed-off-by: Aditya Jain > --- > .../staging/rtl8723bs/include/hal_phy_cfg.h | 56 ++++++------------- > 1 file changed, 16 insertions(+), 40 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h b/drivers/staging/rtl8723bs/include/hal_phy_cfg.h > index 3cec06e9f359..2b059c9c7851 100644 > --- a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h > +++ b/drivers/staging/rtl8723bs/include/hal_phy_cfg.h > @@ -46,49 +46,25 @@ s32 PHY_MACConfig8723B(struct adapter *padapter); > void PHY_SetTxPowerIndex(struct adapter *Adapter, u32 PowerIndex, > u8 RFPath, u8 Rate); > > -u8 > -PHY_GetTxPowerIndex( > -struct adapter *padapter, > -u8 RFPath, > -u8 Rate, > -enum CHANNEL_WIDTH BandWidth, > -u8 Channel > - ); > - > -void > -PHY_GetTxPowerLevel8723B( > -struct adapter *Adapter, > - s32 *powerlevel > - ); > - > -void > -PHY_SetTxPowerLevel8723B( > -struct adapter *Adapter, > -u8 channel > - ); > - > -void > -PHY_SetBWMode8723B( > -struct adapter *Adapter, > -enum CHANNEL_WIDTH Bandwidth, /* 20M or 40M */ > -unsigned char Offset /* Upper, Lower, or Don't care */ > -); > +u8 PHY_GetTxPowerIndex(struct adapter *padapter, u8 RFPath, u8 Rate, > + enum CHANNEL_WIDTH BandWidth, u8 Channel); > + > +void PHY_GetTxPowerLevel8723B(struct adapter *Adapter, s32 *powerlevel); > + > +void PHY_SetTxPowerLevel8723B(struct adapter *Adapter, u8 channel); > > -void > -PHY_SwChnl8723B(/* Call after initialization */ > -struct adapter *Adapter, > -u8 channel > - ); > - > -void > -PHY_SetSwChnlBWMode8723B( > -struct adapter *Adapter, > -u8 channel, > -enum CHANNEL_WIDTH Bandwidth, > -u8 Offset40, > -u8 Offset80 > +void PHY_SetBWMode8723B(struct adapter *Adapter, > + enum CHANNEL_WIDTH Bandwidth, /* 20M or 40M */ > + unsigned char Offset /* Upper, Lower, or Don't care */ Those comments should go at the top of the function declaration, in kernel doc format. thanks greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel