From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28588C433E0 for ; Thu, 30 Jul 2020 08:57:39 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC657206E6 for ; Thu, 30 Jul 2020 08:57:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ExO1+JBB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC657206E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 9DF6B20773; Thu, 30 Jul 2020 08:57:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L-ZVHGc-ePPK; Thu, 30 Jul 2020 08:57:37 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id A880F204FE; Thu, 30 Jul 2020 08:57:37 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 4FAFC1BF489 for ; Thu, 30 Jul 2020 08:57:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 4C32B870A9 for ; Thu, 30 Jul 2020 08:57:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d82znQUTqMYU for ; Thu, 30 Jul 2020 08:57:35 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by hemlock.osuosl.org (Postfix) with ESMTPS id 73C7586C3A for ; Thu, 30 Jul 2020 08:57:35 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BA220206E6; Thu, 30 Jul 2020 08:57:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596099455; bh=tynLa/+J3ayFr4WdQpJKnbHExIeegUOAxTPSGQvzMa4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ExO1+JBBmdpefXIyIv2fCFJj7uQvsdiqTqdTr8CZ6y8zi6YH8jScVYcqpcljHSmAh dXxmpYk9zQOblC2Q9Gf6pGaBnpl8RObxWHmTbATUYx0nY3Y5wFMoinvk/jHc6gzEcJ d3zpQ6VxV1Pk7hh6vbLyU1I5Z/P7HCccNwzoHw0M= Date: Thu, 30 Jul 2020 10:57:24 +0200 From: Greg KH To: Christian.Gromm@microchip.com Subject: Re: [PATCH] staging: most: usb: rename most_usb.ko Message-ID: <20200730085724.GB826534@kroah.com> References: <1596040728-3353-1-git-send-email-christian.gromm@microchip.com> <20200729170313.GA3668028@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: driverdev-devel@linuxdriverproject.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Thu, Jul 30, 2020 at 08:27:29AM +0000, Christian.Gromm@microchip.com wrote: > On Wed, 2020-07-29 at 19:03 +0200, Greg KH wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you > > know the content is safe > > > > On Wed, Jul 29, 2020 at 06:38:48PM +0200, Christian Gromm wrote: > > > To avoid a name conflict when adding the usb module to the > > > driver's directory in the stable branch, this patch simply > > > renames the kernel object. > > > > > > Signed-off-by: Christian Gromm > > > Reported-by: Greg Kroah-Hartman > > > --- > > > drivers/staging/most/usb/{most_usb.ko => most-usb.ko} | Bin > > > 1 file changed, 0 insertions(+), 0 deletions(-) > > > rename drivers/staging/most/usb/{most_usb.ko => most-usb.ko} > > > (100%) > > > > > > diff --git a/drivers/staging/most/usb/most_usb.ko > > > b/drivers/staging/most/usb/most-usb.ko > > > similarity index 100% > > > rename from drivers/staging/most/usb/most_usb.ko > > > rename to drivers/staging/most/usb/most-usb.ko > > > > You renamed a binary file??? That is not in the source tree? > > > > I know. And I was kind of confused that you chose this path (1). > I even had to mess up my git to do that. > > > > > No, I mean make the patch move the .c file from staging to the > > drivers/most directory and adjust the Kconfig/Makefiles for that > > movement. > > > > Huh, but this is exactly what I wanted to do in the first place. > Add it to the stable branch and change the staging files to > avoid the conflict. > But then you told me to not touch the staging files. Remember? Yes, but that would have made it impossible for people to review. > Anyways, here is what I am going to do now: > add the usb file to the stable branch, change the name of the > .ko inside the stable branch and then once the staging files > are removed, I'll rename it again to get the old name back. > > Does this make sense now? Yes, but I still think that's harder, just do it the original way you wanted to in the first place. Now that people have had a chance to review it, no one has objected, so let's just do it the simple way. thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel