Re: [PATCH v1] staging: fieldbus: Use %pM format specifier for MAC addresses

From: kernel test robot <lkp@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Sven Van Asbroeck <TheSven73@gmail.com>,
	devel@driverdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	kbuild-all@lists.01.org
Subject: Re: [PATCH v1] staging: fieldbus: Use %pM format specifier for MAC addresses
Date: Fri, 31 Jul 2020 01:34:22 +0800	[thread overview]
Message-ID: <202007310143.fSRLlEoC%lkp@intel.com> (raw)
In-Reply-To: <20200730152724.39250-1-andriy.shevchenko@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 2231 bytes --]

Hi Andy,

I love your patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/staging-fieldbus-Use-pM-format-specifier-for-MAC-addresses/20200730-232835
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git d8a0f85d394a0cc5dec2b290ebcf8ed3cfdc1a70
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   drivers/staging/fieldbus/anybuss/hms-profinet.c: In function 'profi_id_get':
>> drivers/staging/fieldbus/anybuss/hms-profinet.c:58:9: error: 'ETH_ALEN' undeclared (first use in this function)
      58 |  u8 mac[ETH_ALEN];
         |         ^~~~~~~~
   drivers/staging/fieldbus/anybuss/hms-profinet.c:58:9: note: each undeclared identifier is reported only once for each function it appears in
   drivers/staging/fieldbus/anybuss/hms-profinet.c:58:5: warning: unused variable 'mac' [-Wunused-variable]
      58 |  u8 mac[ETH_ALEN];
         |     ^~~
>> drivers/staging/fieldbus/anybuss/hms-profinet.c:65:1: warning: control reaches end of non-void function [-Wreturn-type]
      65 | }
         | ^

vim +/ETH_ALEN +58 drivers/staging/fieldbus/anybuss/hms-profinet.c

    53	
    54	static int profi_id_get(struct fieldbus_dev *fbdev, char *buf,
    55				size_t max_size)
    56	{
    57		struct profi_priv *priv = container_of(fbdev, struct profi_priv, fbdev);
  > 58		u8 mac[ETH_ALEN];
    59		int ret;
    60	
    61		ret = anybuss_recv_msg(priv->client, 0x0010, &mac, sizeof(mac));
    62		if (ret < 0)
    63			return ret;
    64		return snprintf(buf, max_size, "%pM\n", mac);
  > 65	}
    66	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 55834 bytes --]

[-- Attachment #3: Type: text/plain, Size: 169 bytes --]

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel